Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c358898a
Unverified
Commit
c358898a
authored
Nov 30, 2017
by
Alexandre Ardhuin
Committed by
GitHub
Nov 30, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
try lint avoid_unused_constructor_parameters (#13250)
parent
fcdbdfb4
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
3 additions
and
3 deletions
+3
-3
analysis_options.yaml
analysis_options.yaml
+1
-1
analysis_options_repo.yaml
analysis_options_repo.yaml
+1
-1
diagnostics.dart
packages/flutter/lib/src/foundation/diagnostics.dart
+0
-1
editable.dart
packages/flutter/lib/src/rendering/editable.dart
+1
-0
No files found.
analysis_options.yaml
View file @
c358898a
...
...
@@ -70,7 +70,7 @@ linter:
# - avoid_setters_without_getters # not yet tested
-
avoid_slow_async_io
# - avoid_types_on_closure_parameters # conflicts with always_specify_types
# - avoid_unused_constructor_parameters #
not yet tested
# - avoid_unused_constructor_parameters #
https://github.com/dart-lang/linter/pull/847
-
await_only_futures
-
camel_case_types
-
cancel_subscriptions
...
...
analysis_options_repo.yaml
View file @
c358898a
...
...
@@ -63,7 +63,7 @@ linter:
# - avoid_setters_without_getters # not yet tested
-
avoid_slow_async_io
# - avoid_types_on_closure_parameters # conflicts with always_specify_types
# - avoid_unused_constructor_parameters #
not yet tested
# - avoid_unused_constructor_parameters #
https://github.com/dart-lang/linter/pull/847
-
await_only_futures
-
camel_case_types
-
cancel_subscriptions
...
...
packages/flutter/lib/src/foundation/diagnostics.dart
View file @
c358898a
...
...
@@ -1955,7 +1955,6 @@ class DiagnosticableNode<T extends Diagnosticable> extends DiagnosticsNode {
String
name
,
@required
this
.
value
,
@required
DiagnosticsTreeStyle
style
,
String
emptyBodyDescription
,
})
:
assert
(
value
!=
null
),
super
(
name:
name
,
...
...
packages/flutter/lib/src/rendering/editable.dart
View file @
c358898a
...
...
@@ -127,6 +127,7 @@ class RenderEditable extends RenderBox {
_showCursor
=
showCursor
??
new
ValueNotifier
<
bool
>(
false
),
_hasFocus
=
hasFocus
??
false
,
_maxLines
=
maxLines
,
_selectionColor
=
selectionColor
,
_selection
=
selection
,
_offset
=
offset
{
assert
(
_showCursor
!=
null
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment