Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c2a93bd5
Commit
c2a93bd5
authored
May 20, 2019
by
Sam Rawlins
Committed by
Michael Goderbauer
May 20, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix missing return statements on function literals (#33058)
parent
539ff203
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
8 additions
and
4 deletions
+8
-4
leave_behind_demo.dart
.../flutter_gallery/lib/demo/material/leave_behind_demo.dart
+1
-0
nav_bar.dart
packages/flutter/lib/src/cupertino/nav_bar.dart
+1
-0
driver.dart
packages/flutter_driver/lib/src/driver/driver.dart
+1
-1
binding.dart
packages/flutter_test/lib/src/binding.dart
+1
-0
window_test.dart
packages/flutter_test/test/window_test.dart
+1
-1
testbed.dart
packages/flutter_tools/test/src/testbed.dart
+2
-1
test_compiler_test.dart
packages/flutter_tools/test/test_compiler_test.dart
+1
-1
No files found.
examples/flutter_gallery/lib/demo/material/leave_behind_demo.dart
View file @
c2a93bd5
...
@@ -243,6 +243,7 @@ class _LeaveBehindListItem extends StatelessWidget {
...
@@ -243,6 +243,7 @@ class _LeaveBehindListItem extends StatelessWidget {
case
DismissDirection
.
down
:
case
DismissDirection
.
down
:
assert
(
false
);
assert
(
false
);
}
}
return
true
;
},
},
background:
Container
(
background:
Container
(
color:
theme
.
primaryColor
,
color:
theme
.
primaryColor
,
...
...
packages/flutter/lib/src/cupertino/nav_bar.dart
View file @
c2a93bd5
...
@@ -2250,4 +2250,5 @@ final HeroFlightShuttleBuilder _navBarHeroFlightShuttleBuilder = (
...
@@ -2250,4 +2250,5 @@ final HeroFlightShuttleBuilder _navBarHeroFlightShuttleBuilder = (
topNavBar:
fromNavBar
,
topNavBar:
fromNavBar
,
);
);
}
}
return
null
;
};
};
packages/flutter_driver/lib/src/driver/driver.dart
View file @
c2a93bd5
...
@@ -101,7 +101,7 @@ Future<T> _warnIfSlow<T>({
...
@@ -101,7 +101,7 @@ Future<T> _warnIfSlow<T>({
assert
(
future
!=
null
);
assert
(
future
!=
null
);
assert
(
timeout
!=
null
);
assert
(
timeout
!=
null
);
assert
(
message
!=
null
);
assert
(
message
!=
null
);
return
future
..
timeout
(
timeout
,
onTimeout:
()
{
_log
.
warning
(
message
);
});
return
future
..
timeout
(
timeout
,
onTimeout:
()
{
_log
.
warning
(
message
);
return
null
;
});
}
}
/// A convenient accessor to frequently used finders.
/// A convenient accessor to frequently used finders.
...
...
packages/flutter_test/lib/src/binding.dart
View file @
c2a93bd5
...
@@ -764,6 +764,7 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
...
@@ -764,6 +764,7 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
final
Uint8List
encoded
=
Uint8List
.
fromList
(
asset
.
readAsBytesSync
());
final
Uint8List
encoded
=
Uint8List
.
fromList
(
asset
.
readAsBytesSync
());
return
Future
<
ByteData
>.
value
(
encoded
.
buffer
.
asByteData
());
return
Future
<
ByteData
>.
value
(
encoded
.
buffer
.
asByteData
());
}
}
return
null
;
});
});
}
}
}
}
...
...
packages/flutter_test/test/window_test.dart
View file @
c2a93bd5
...
@@ -164,7 +164,7 @@ void main() {
...
@@ -164,7 +164,7 @@ void main() {
);
);
});
});
testWidgets
(
'TestWindow can clear out fake properties all at once'
,
(
WidgetTester
tester
)
{
testWidgets
(
'TestWindow can clear out fake properties all at once'
,
(
WidgetTester
tester
)
async
{
final
double
originalDevicePixelRatio
=
ui
.
window
.
devicePixelRatio
;
final
double
originalDevicePixelRatio
=
ui
.
window
.
devicePixelRatio
;
final
double
originalTextScaleFactor
=
ui
.
window
.
textScaleFactor
;
final
double
originalTextScaleFactor
=
ui
.
window
.
textScaleFactor
;
final
TestWindow
testWindow
=
retrieveTestBinding
(
tester
).
window
;
final
TestWindow
testWindow
=
retrieveTestBinding
(
tester
).
window
;
...
...
packages/flutter_tools/test/src/testbed.dart
View file @
c2a93bd5
...
@@ -79,8 +79,9 @@ class Testbed {
...
@@ -79,8 +79,9 @@ class Testbed {
}
}
await
test
();
await
test
();
Cache
.
flutterRoot
=
originalFlutterRoot
;
Cache
.
flutterRoot
=
originalFlutterRoot
;
return
null
;
}
}
);
);
});
});
}
}
}
}
\ No newline at end of file
packages/flutter_tools/test/test_compiler_test.dart
View file @
c2a93bd5
...
@@ -19,7 +19,7 @@ void main() {
...
@@ -19,7 +19,7 @@ void main() {
setUp
(()
{
setUp
(()
{
testbed
=
Testbed
(
testbed
=
Testbed
(
setup:
()
{
setup:
()
async
{
fs
.
file
(
'pubspec.yaml'
).
createSync
();
fs
.
file
(
'pubspec.yaml'
).
createSync
();
fs
.
file
(
'.packages'
).
createSync
();
fs
.
file
(
'.packages'
).
createSync
();
fs
.
file
(
'test/foo.dart'
).
createSync
(
recursive:
true
);
fs
.
file
(
'test/foo.dart'
).
createSync
(
recursive:
true
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment