Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c15aa874
Unverified
Commit
c15aa874
authored
Apr 28, 2020
by
Jonah Williams
Committed by
GitHub
Apr 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
restore quit timeout, adjust some integration test behaviors (#55812)
parent
ffcf1db3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
25 additions
and
5 deletions
+25
-5
flutter_attach_test_android.dart
dev/devicelab/bin/tasks/flutter_attach_test_android.dart
+12
-4
resident_runner.dart
packages/flutter_tools/lib/src/resident_runner.dart
+13
-1
No files found.
dev/devicelab/bin/tasks/flutter_attach_test_android.dart
View file @
c15aa874
...
@@ -53,7 +53,12 @@ Future<void> testReload(Process process, { Future<void> Function() onListening }
...
@@ -53,7 +53,12 @@ Future<void> testReload(Process process, { Future<void> Function() onListening }
process
.
exitCode
.
then
<
void
>((
int
processExitCode
)
{
exitCode
=
processExitCode
;
});
process
.
exitCode
.
then
<
void
>((
int
processExitCode
)
{
exitCode
=
processExitCode
;
});
Future
<
dynamic
>
eventOrExit
(
Future
<
void
>
event
)
{
Future
<
dynamic
>
eventOrExit
(
Future
<
void
>
event
)
{
return
Future
.
any
<
dynamic
>(<
Future
<
dynamic
>>[
event
,
process
.
exitCode
]);
return
Future
.
any
<
dynamic
>(<
Future
<
dynamic
>>[
event
,
process
.
exitCode
,
// Keep the test from running for 15 minutes if it gets stuck.
Future
<
void
>.
delayed
(
const
Duration
(
seconds:
10
)),
]);
}
}
await
eventOrExit
(
listening
.
future
);
await
eventOrExit
(
listening
.
future
);
...
@@ -63,13 +68,16 @@ Future<void> testReload(Process process, { Future<void> Function() onListening }
...
@@ -63,13 +68,16 @@ Future<void> testReload(Process process, { Future<void> Function() onListening }
throw
TaskResult
.
failure
(
'Failed to attach to test app; command unexpected exited, with exit code
$exitCode
.'
);
throw
TaskResult
.
failure
(
'Failed to attach to test app; command unexpected exited, with exit code
$exitCode
.'
);
process
.
stdin
.
write
(
'r'
);
process
.
stdin
.
write
(
'r'
);
process
.
stdin
.
flush
();
print
(
'run:stdin: r'
);
await
process
.
stdin
.
flush
();
await
eventOrExit
(
reloaded
.
future
);
await
eventOrExit
(
reloaded
.
future
);
process
.
stdin
.
write
(
'R'
);
process
.
stdin
.
write
(
'R'
);
process
.
stdin
.
flush
();
print
(
'run:stdin: R'
);
await
process
.
stdin
.
flush
();
await
eventOrExit
(
restarted
.
future
);
await
eventOrExit
(
restarted
.
future
);
process
.
stdin
.
write
(
'q'
);
process
.
stdin
.
write
(
'q'
);
process
.
stdin
.
flush
();
print
(
'run:stdin: q'
);
await
process
.
stdin
.
flush
();
await
eventOrExit
(
finished
.
future
);
await
eventOrExit
(
finished
.
future
);
await
process
.
exitCode
;
await
process
.
exitCode
;
...
...
packages/flutter_tools/lib/src/resident_runner.dart
View file @
c15aa874
...
@@ -286,7 +286,19 @@ class FlutterDevice {
...
@@ -286,7 +286,19 @@ class FlutterDevice {
));
));
}
}
}
}
return
vmService
.
onDone
;
return
vmService
.
onDone
.
catchError
((
dynamic
error
,
StackTrace
stackTrace
)
{
globals
.
logger
.
printError
(
'unhanlded error waiting for vm service exit:
\n
$error
'
,
stackTrace:
stackTrace
,
);
})
.
timeout
(
const
Duration
(
seconds:
2
),
onTimeout:
()
{
// TODO(jonahwilliams): this only seems to fail on CI in the
// flutter_attach_android_test. This log should help verify this
// is where the tool is getting stuck.
globals
.
logger
.
printTrace
(
'error: vm service shutdown failed'
);
});
}
}
Future
<
Uri
>
setupDevFS
(
Future
<
Uri
>
setupDevFS
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment