Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c0d5fd23
Unverified
Commit
c0d5fd23
authored
Apr 30, 2019
by
Dan Field
Committed by
GitHub
Apr 30, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Handle notification errors (#31868)
parent
5e77d650
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
29 additions
and
2 deletions
+29
-2
driver.dart
packages/flutter_driver/lib/src/driver/driver.dart
+11
-2
vmservice.dart
packages/flutter_tools/lib/src/vmservice.dart
+10
-0
dart_vm.dart
...s/fuchsia_remote_debug_protocol/lib/src/dart/dart_vm.dart
+8
-0
No files found.
packages/flutter_driver/lib/src/driver/driver.dart
View file @
c0d5fd23
...
@@ -934,9 +934,18 @@ void restoreVmServiceConnectFunction() {
...
@@ -934,9 +934,18 @@ void restoreVmServiceConnectFunction() {
}
}
void
_unhandledJsonRpcError
(
dynamic
error
,
dynamic
stack
)
{
void
_unhandledJsonRpcError
(
dynamic
error
,
dynamic
stack
)
{
if
(
error
is
rpc
.
RpcException
)
{
final
rpc
.
RpcException
rpcException
=
error
;
if
(
rpcException
.
data
!=
null
&&
rpcException
.
data
[
'id'
]
==
null
)
{
// This can happen, e.g., if a client tries to call us before methods have
// been registered, but the client doesn't care for a response.
_log
.
trace
(
'RPC client sent a notification that resulted in an error:
\n
$error
'
);
return
;
}
assert
(
false
,
'json_rpc_2 failed to send an exception back to the client.'
);
}
_log
.
trace
(
'Unhandled RPC error:
\n
$error
\n
$stack
'
);
_log
.
trace
(
'Unhandled RPC error:
\n
$error
\n
$stack
'
);
// TODO(dnfield): https://github.com/flutter/flutter/issues/31813
assert
(
false
);
// assert(false);
}
}
/// Waits for a real Dart VM service to become available, then connects using
/// Waits for a real Dart VM service to become available, then connects using
...
...
packages/flutter_tools/lib/src/vmservice.dart
View file @
c0d5fd23
...
@@ -237,6 +237,16 @@ class VMService {
...
@@ -237,6 +237,16 @@ class VMService {
}
}
static
void
_unhandledError
(
dynamic
error
,
dynamic
stack
)
{
static
void
_unhandledError
(
dynamic
error
,
dynamic
stack
)
{
if
(
error
is
rpc
.
RpcException
)
{
final
rpc
.
RpcException
rpcException
=
error
;
if
(
rpcException
.
data
!=
null
&&
rpcException
.
data
[
'id'
]
==
null
)
{
// This can happen, e.g., if a client tries to call us before methods have
// been registered, but the client doesn't care for a response.
logger
.
printTrace
(
'RPC client sent a notification that resulted in an error:
\n
$error
'
);
return
;
}
assert
(
false
,
'json_rpc_2 failed to send an exception back to the client.'
);
}
logger
.
printTrace
(
'Error in internal implementation of JSON RPC.
\n
$error
\n
$stack
'
);
logger
.
printTrace
(
'Error in internal implementation of JSON RPC.
\n
$error
\n
$stack
'
);
assert
(
false
);
assert
(
false
);
}
}
...
...
packages/fuchsia_remote_debug_protocol/lib/src/dart/dart_vm.dart
View file @
c0d5fd23
...
@@ -33,6 +33,14 @@ RpcPeerConnectionFunction fuchsiaVmServiceConnectionFunction = _waitAndConnect;
...
@@ -33,6 +33,14 @@ RpcPeerConnectionFunction fuchsiaVmServiceConnectionFunction = _waitAndConnect;
void
_unhandledJsonRpcError
(
dynamic
error
,
dynamic
stack
)
{
void
_unhandledJsonRpcError
(
dynamic
error
,
dynamic
stack
)
{
if
(
error
is
json_rpc
.
RpcException
)
{
final
json_rpc
.
RpcException
rpcException
=
error
;
if
(
rpcException
.
data
!=
null
&&
rpcException
.
data
[
'id'
]
==
null
)
{
// This can happen, e.g., if a client tries to call us before methods have
// been registered, but the client doesn't care for a response.
return
;
}
}
_log
.
fine
(
'Error in internalimplementation of JSON RPC.
\n
$error
\n
$stack
'
);
_log
.
fine
(
'Error in internalimplementation of JSON RPC.
\n
$error
\n
$stack
'
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment