Unverified Commit c0772784 authored by Michael Goderbauer's avatar Michael Goderbauer Committed by GitHub

Migrate integration_tests/channels to null safety (#84145)

parent aaff3290
......@@ -19,7 +19,7 @@ void main() {
}
class TestApp extends StatefulWidget {
const TestApp({Key key}) : super(key: key);
const TestApp({Key? key}) : super(key: key);
@override
State<TestApp> createState() => _TestAppState();
......@@ -155,7 +155,7 @@ class _TestAppState extends State<TestApp> {
() => basicJsonMessageToUnknownChannel(),
() => basicStandardMessageToUnknownChannel(),
];
Future<TestStepResult> _result;
Future<TestStepResult>? _result;
int _step = 0;
void _executeNextStep() {
......
......@@ -42,22 +42,22 @@ class ExtendedStandardMessageCodec extends StandardMessageCodec {
}
}
Future<TestStepResult> basicBinaryHandshake(ByteData message) async {
const BasicMessageChannel<ByteData> channel =
BasicMessageChannel<ByteData>(
Future<TestStepResult> basicBinaryHandshake(ByteData? message) async {
const BasicMessageChannel<ByteData?> channel =
BasicMessageChannel<ByteData?>(
'binary-msg',
BinaryCodec(),
);
return _basicMessageHandshake<ByteData>(
return _basicMessageHandshake<ByteData?>(
'Binary >${toString(message)}<', channel, message);
}
Future<TestStepResult> basicStringHandshake(String message) async {
const BasicMessageChannel<String> channel = BasicMessageChannel<String>(
Future<TestStepResult> basicStringHandshake(String? message) async {
const BasicMessageChannel<String?> channel = BasicMessageChannel<String?>(
'string-msg',
StringCodec(),
);
return _basicMessageHandshake<String>('String >$message<', channel, message);
return _basicMessageHandshake<String?>('String >$message<', channel, message);
}
Future<TestStepResult> basicJsonHandshake(dynamic message) async {
......@@ -80,8 +80,8 @@ Future<TestStepResult> basicStandardHandshake(dynamic message) async {
}
Future<TestStepResult> basicBinaryMessageToUnknownChannel() async {
const BasicMessageChannel<ByteData> channel =
BasicMessageChannel<ByteData>(
const BasicMessageChannel<ByteData?> channel =
BasicMessageChannel<ByteData?>(
'binary-unknown',
BinaryCodec(),
);
......@@ -89,7 +89,7 @@ Future<TestStepResult> basicBinaryMessageToUnknownChannel() async {
}
Future<TestStepResult> basicStringMessageToUnknownChannel() async {
const BasicMessageChannel<String> channel = BasicMessageChannel<String>(
const BasicMessageChannel<String?> channel = BasicMessageChannel<String?>(
'string-unknown',
StringCodec(),
);
......@@ -122,11 +122,11 @@ Future<TestStepResult> basicStandardMessageToUnknownChannel() async {
/// the original message.
Future<TestStepResult> _basicMessageHandshake<T>(
String description,
BasicMessageChannel<T> channel,
BasicMessageChannel<T?> channel,
T message,
) async {
final List<dynamic> received = <dynamic>[];
channel.setMessageHandler((T message) async {
channel.setMessageHandler((T? message) async {
received.add(message);
return message;
});
......@@ -150,7 +150,7 @@ Future<TestStepResult> _basicMessageHandshake<T>(
/// Sends a message on a channel that no one listens on.
Future<TestStepResult> _basicMessageToUnknownChannel<T>(
String description,
BasicMessageChannel<T> channel,
BasicMessageChannel<T?> channel,
) async {
dynamic messageEcho = nothing;
dynamic error = nothing;
......
......@@ -44,12 +44,9 @@ class TestStepResult {
return const TestStepResult('Executing', nothing, TestStatus.pending);
case ConnectionState.done:
if (snapshot.hasData) {
return snapshot.data;
} else {
final TestStepResult result = snapshot.error as TestStepResult;
return result;
return snapshot.data!;
}
break;
return snapshot.error! as TestStepResult;
default:
throw 'Unsupported state ${snapshot.connectionState}';
}
......
......@@ -2,7 +2,7 @@ name: channels
description: Integration test for platform channels.
environment:
sdk: ">=2.0.0-dev.68.0 <3.0.0"
sdk: ">=2.12.0 <3.0.0"
dependencies:
flutter:
......
......@@ -7,7 +7,7 @@ import 'package:test/test.dart' hide TypeMatcher, isInstanceOf;
void main() {
group('channel suite', () {
FlutterDriver driver;
late FlutterDriver driver;
setUpAll(() async {
driver = await FlutterDriver.connect();
......@@ -28,7 +28,7 @@ void main() {
}, timeout: const Timeout(Duration(minutes: 1)));
tearDownAll(() async {
driver?.close();
driver.close();
});
});
}
......@@ -154,7 +154,7 @@ class JSONMethodCodec implements MethodCodec {
&& (decoded[1] == null || decoded[1] is String))
throw PlatformException(
code: decoded[0] as String,
message: decoded[1] as String,
message: decoded[1] as String?,
details: decoded[2],
);
if (decoded.length == 4
......@@ -163,9 +163,9 @@ class JSONMethodCodec implements MethodCodec {
&& (decoded[3] == null || decoded[3] is String))
throw PlatformException(
code: decoded[0] as String,
message: decoded[1] as String,
message: decoded[1] as String?,
details: decoded[2],
stacktrace: decoded[3] as String,
stacktrace: decoded[3] as String?,
);
throw FormatException('Invalid envelope: $decoded');
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment