Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c04f0a2b
Unverified
Commit
c04f0a2b
authored
3 years ago
by
Michael Goderbauer
Committed by
GitHub
3 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable vm:notify-debugger-on-exception for LayoutBuilder (#82835)
parent
0d79013a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
7 deletions
+6
-7
layout_builder.dart
packages/flutter/lib/src/widgets/layout_builder.dart
+5
-6
break_on_framework_exceptions_test.dart
...integration.shard/break_on_framework_exceptions_test.dart
+1
-1
No files found.
packages/flutter/lib/src/widgets/layout_builder.dart
View file @
c04f0a2b
...
...
@@ -115,11 +115,8 @@ class _LayoutBuilderElement<ConstraintType extends Constraints> extends RenderOb
}
void
_layout
(
ConstraintType
constraints
)
{
// TODO(goderbauer): When https://github.com/dart-lang/sdk/issues/45710 is
// fixed: refactor the anonymous closure below into a named one, apply the
// @pragma('vm:notify-debugger-on-exception') to it and enable the
// corresponding test in break_on_framework_exceptions_test.dart.
owner
!.
buildScope
(
this
,
()
{
@pragma
(
'vm:notify-debugger-on-exception'
)
void
layoutCallback
()
{
Widget
built
;
try
{
built
=
widget
.
builder
(
this
,
constraints
);
...
...
@@ -152,7 +149,9 @@ class _LayoutBuilderElement<ConstraintType extends Constraints> extends RenderOb
);
_child
=
updateChild
(
null
,
built
,
slot
);
}
});
}
owner
!.
buildScope
(
this
,
layoutCallback
);
}
@override
...
...
This diff is collapsed.
Click to expand it.
packages/flutter_tools/test/integration.shard/break_on_framework_exceptions_test.dart
View file @
c04f0a2b
...
...
@@ -388,7 +388,7 @@ void main() {
final
int
breakLine
=
(
await
flutter
.
getSourceLocation
()).
line
;
expect
(
breakLine
,
project
.
lineContaining
(
project
.
test
,
"throw 'LayoutBuilder.builder';"
));
}
,
skip:
'TODO(goderbauer): Once https://github.com/dart-lang/sdk/issues/45710 is fixed, fix TODO in _LayoutBuilderElement._layout and enable this test'
);
});
testWithoutContext
(
'breaks when _CallbackHookProvider callback throws'
,
()
async
{
final
TestProject
project
=
TestProject
(
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment