[flutter_tools] remove even more mocks (#81618)

packages/flutter_tools/test/general.shard/ios/ios_device_start_prebuilt_test.dart

@@ -20,7 +20,7 @@ import 'package:flutter_tools/src/ios/devices.dart';
 import 'package:flutter_tools/src/ios/ios_deploy.dart';
 import 'package:flutter_tools/src/ios/iproxy.dart';
 import 'package:flutter_tools/src/ios/mac.dart';
-import 'package:mockito/mockito.dart';
+import 'package:test/fake.dart';
 
 import '../../src/common.dart';
 import '../../src/fake_devices.dart';
@@ -86,12 +86,10 @@ stdout: '(lldb)     run\nsuccess',
 );
 
 void main() {
-  // TODO(jonahwilliams): This test doesn't really belong here but
-  // I don't have a better place for it for now.
   testWithoutContext('disposing device disposes the portForwarder and logReader', () async {
     final IOSDevice device = setUpIOSDevice();
-    final DevicePortForwarder devicePortForwarder = MockDevicePortForwarder();
-    final DeviceLogReader deviceLogReader = MockDeviceLogReader();
+    final FakeDevicePortForwarder devicePortForwarder = FakeDevicePortForwarder();
+    final FakeDeviceLogReader deviceLogReader = FakeDeviceLogReader();
     final IOSApp iosApp = PrebuiltIOSApp(
       projectBundleId: 'app',
       bundleName: 'Runner',
@@ -101,8 +99,8 @@ void main() {
     device.setLogReader(iosApp, deviceLogReader);
     await device.dispose();
 
-    verify(deviceLogReader.dispose()).called(1);
-    verify(devicePortForwarder.dispose()).called(1);
+    expect(deviceLogReader.disposed, true);
+    expect(devicePortForwarder.disposed, true);
   });
 
   testWithoutContext('IOSDevice.startApp attaches in debug mode via log reading on iOS 13+', () async {
@@ -384,5 +382,11 @@ IOSDevice setUpIOSDevice({
   );
 }
 
-class MockDevicePortForwarder extends Mock implements DevicePortForwarder {}
-class MockDeviceLogReader extends Mock implements DeviceLogReader {}
+class FakeDevicePortForwarder extends Fake implements DevicePortForwarder {
+  bool disposed = false;
+
+  @override
+  Future<void> dispose() async {
+    disposed = true;
+  }
+}

packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart

@@ -16,55 +16,17 @@ import 'package:flutter_tools/src/ios/xcode_build_settings.dart';
 import 'package:flutter_tools/src/ios/xcodeproj.dart';
 import 'package:flutter_tools/src/project.dart';
 import 'package:flutter_tools/src/reporting/reporting.dart';
-import 'package:mockito/mockito.dart';
 
 import '../../src/common.dart';
 import '../../src/context.dart';
-import '../../src/mocks.dart' as mocks;
 
 const String xcodebuild = '/usr/bin/xcodebuild';
 
 void main() {
   group('MockProcessManager', () {
-    mocks.MockProcessManager processManager;
-    XcodeProjectInterpreter xcodeProjectInterpreter;
-    FakePlatform platform;
-    BufferLogger logger;
-
     setUp(() {
-      processManager = mocks.MockProcessManager();
-      platform = FakePlatform(operatingSystem: 'macos');
       final FileSystem fileSystem = MemoryFileSystem.test();
       fileSystem.file(xcodebuild).createSync(recursive: true);
-      logger = BufferLogger.test();
-      xcodeProjectInterpreter = XcodeProjectInterpreter(
-        logger: logger,
-        fileSystem: fileSystem,
-        platform: platform,
-        processManager: processManager,
-        usage: null,
-      );
-    });
-
-    testUsingContext('xcodebuild build settings flakes', () async {
-      const Duration delay = Duration(seconds: 1);
-      processManager.processFactory = mocks.flakyProcessFactory(
-        flakes: 1,
-        delay: delay + const Duration(seconds: 1),
-      );
-      platform.environment = const <String, String>{};
-
-      when(processManager.runSync(<String>['which', 'sysctl']))
-          .thenReturn(ProcessResult(0, 0, '', ''));
-      when(processManager.runSync(<String>['sysctl', 'hw.optional.arm64']))
-          .thenReturn(ProcessResult(0, 1, '', ''));
-
-      expect(await xcodeProjectInterpreter.getBuildSettings('', buildContext: const XcodeProjectBuildContext(scheme: 'Runner'), timeout: delay),
-        const <String, String>{});
-      // build settings times out and is killed once, then succeeds.
-      verify(processManager.killPid(any)).called(1);
-      // The verbose logs should tell us something timed out.
-      expect(logger.traceText, contains('timed out'));
     });
   });
 

packages/flutter_tools/test/src/fake_devices.dart

@@ -184,6 +184,8 @@ class FakeDeviceLogReader extends DeviceLogReader {
 
   StreamController<String> _cachedLinesController;
 
+  bool disposed = false;
+
   final List<String> _lineQueue = <String>[];
   StreamController<String> get _linesController {
     _cachedLinesController ??= StreamController<String>
@@ -209,5 +211,6 @@ class FakeDeviceLogReader extends DeviceLogReader {
   Future<void> dispose() async {
     _lineQueue.clear();
     await _linesController.close();
+    disposed = true;
   }
 }

packages/flutter_tools/test/src/mocks.dart

-// Copyright 2014 The Flutter Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// @dart = 2.8
-
-import 'dart:async';
-
-import 'package:flutter_tools/src/base/io.dart';
-import 'package:mockito/mockito.dart';
-import 'package:process/process.dart';
-
-import 'fakes.dart';
-
-/// A strategy for creating Process objects from a list of commands.
-typedef _ProcessFactory = Process Function(List<String> command);
-
-/// A ProcessManager that starts Processes by delegating to a ProcessFactory.
-class MockProcessManager extends Mock implements ProcessManager {
-  _ProcessFactory processFactory = _defaulProcessFactory;
-  bool canRunSucceeds = true;
-  bool runSucceeds = true;
-  List<String> commands;
-
-  static Process _defaulProcessFactory(List<String> commands) => FakeProcess();
-
-  @override
-  bool canRun(dynamic command, { String workingDirectory }) => canRunSucceeds;
-
-  @override
-  Future<Process> start(
-    List<dynamic> command, {
-    String workingDirectory,
-    Map<String, String> environment,
-    bool includeParentEnvironment = true,
-    bool runInShell = false,
-    ProcessStartMode mode = ProcessStartMode.normal,
-  }) {
-    final List<String> commands = command.cast<String>();
-    if (!runSucceeds) {
-      final String executable = commands[0];
-      final List<String> arguments = commands.length > 1 ? commands.sublist(1) : <String>[];
-      throw ProcessException(executable, arguments);
-    }
-
-    this.commands = commands;
-    return Future<Process>.value(processFactory(commands));
-  }
-}
-
-/// A function that generates a process factory that gives processes that fail
-/// a given number of times before succeeding. The returned processes will
-/// fail after a delay if one is supplied.
-_ProcessFactory flakyProcessFactory({
-  int flakes,
-  bool Function(List<String> command) filter,
-  Duration delay,
-  Stream<List<int>> Function() stdout,
-  Stream<List<int>> Function() stderr,
-}) {
-  int flakesLeft = flakes;
-  stdout ??= () => const Stream<List<int>>.empty();
-  stderr ??= () => const Stream<List<int>>.empty();
-  return (List<String> command) {
-    if (filter != null && !filter(command)) {
-      return FakeProcess();
-    }
-    if (flakesLeft == 0) {
-      return FakeProcess(
-        exitCode: Future<int>.value(0),
-        stdout: stdout(),
-        stderr: stderr(),
-      );
-    }
-    flakesLeft = flakesLeft - 1;
-    Future<int> exitFuture;
-    if (delay == null) {
-      exitFuture = Future<int>.value(-9);
-    } else {
-      exitFuture = Future<int>.delayed(delay, () => Future<int>.value(-9));
-    }
-    return FakeProcess(
-      exitCode: exitFuture,
-      stdout: stdout(),
-      stderr: stderr(),
-    );
-  };
-}