Commit be9dd4b2 authored by Ian Hickson's avatar Ian Hickson Committed by Michael Goderbauer

Remove mention of directly landing on master (#11190)

It's probably too much of a foot gun.

Also, emphasize what you have to do in case people didn't read the design principles document.
parent cb35a1c7
...@@ -167,13 +167,15 @@ To send us a pull request: ...@@ -167,13 +167,15 @@ To send us a pull request:
Please make sure all your checkins have detailed commit messages explaining the patch. Please make sure all your checkins have detailed commit messages explaining the patch.
Once you've gotten an LGTM from a project maintainer, submit your changes to the Once you've gotten an LGTM from a project maintainer and once your PR has received
`master` branch using one of the following methods: the green light from all our automated testing (Travis, Appveyor, etc), and once
the tree is green (see the [design principles](https://flutter.io/design-principles/)
document for more details), submit your changes to the `master` branch using one of
the following methods:
* Wait for one of the project maintainers to submit it for you. * Wait for one of the project maintainers to submit it for you.
* Click the green "Merge pull request" button on the GitHub UI of your pull * Click the green "Merge pull request" button on the GitHub UI of your pull
request (requires commit access) request (requires commit access)
* `git push upstream name_of_your_branch:master` (requires commit access)
You must complete the You must complete the
[Contributor License Agreement](https://cla.developers.google.com/clas). [Contributor License Agreement](https://cla.developers.google.com/clas).
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment