Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
bc6f270c
Unverified
Commit
bc6f270c
authored
Jan 14, 2020
by
Jonah Williams
Committed by
GitHub
Jan 14, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "[flutter_tools] Enable fast start by default for Android (#48746)" (#48836)
This reverts commit
d5b0b3c8
.
parent
d5b0b3c8
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
7 deletions
+16
-7
run.dart
packages/flutter_tools/lib/src/commands/run.dart
+13
-4
run_test.dart
.../flutter_tools/test/commands.shard/hermetic/run_test.dart
+3
-3
No files found.
packages/flutter_tools/lib/src/commands/run.dart
View file @
bc6f270c
...
...
@@ -189,7 +189,8 @@ class RunCommand extends RunCommandBase {
)
..
addFlag
(
'fast-start'
,
negatable:
true
,
defaultsTo:
true
,
defaultsTo:
false
,
hide:
true
,
help:
'Whether to quickly bootstrap applications with a minimal app. '
'Currently this is only supported on Android devices. This option '
'cannot be paired with --use-application-binary.'
...
...
@@ -318,6 +319,10 @@ class RunCommand extends RunCommandBase {
await
super
.
validateCommand
();
}
if
(
boolArg
(
'fast-start'
)
&&
runningWithPrebuiltApplication
)
{
throwToolExit
(
'--fast-start is not supported with --use-application-binary'
);
}
devices
=
await
findAllTargetDevices
();
if
(
devices
==
null
)
{
throwToolExit
(
null
);
...
...
@@ -360,9 +365,7 @@ class RunCommand extends RunCommandBase {
vmserviceOutFile:
stringArg
(
'vmservice-out-file'
),
// Allow forcing fast-start to off to prevent doing more work on devices that
// don't support it.
fastStart:
boolArg
(
'fast-start'
)
&&
!
runningWithPrebuiltApplication
&&
devices
.
every
((
Device
device
)
=>
device
.
supportsFastStart
),
fastStart:
boolArg
(
'fast-start'
)
&&
devices
.
every
((
Device
device
)
=>
device
.
supportsFastStart
),
);
}
}
...
...
@@ -425,6 +428,12 @@ class RunCommand extends RunCommandBase {
}
for
(
final
Device
device
in
devices
)
{
if
(!
device
.
supportsFastStart
&&
boolArg
(
'fast-start'
))
{
globals
.
printStatus
(
'Using --fast-start option with device
${device.name}
, but this device '
'does not support it. Overriding the setting to false.'
);
}
if
(
await
device
.
isLocalEmulator
)
{
if
(
await
device
.
supportsHardwareRendering
)
{
final
bool
enableSoftwareRendering
=
boolArg
(
'enable-software-rendering'
)
==
true
;
...
...
packages/flutter_tools/test/commands.shard/hermetic/run_test.dart
View file @
bc6f270c
...
...
@@ -77,7 +77,7 @@ void main() {
]);
fail
(
'Expect exception'
);
}
catch
(
e
)
{
expect
(
e
.
toString
(),
isNot
(
contains
(
'--fast-start is not supported with --use-application-binary'
)
));
expect
(
e
.
toString
(),
contains
(
'--fast-start is not supported with --use-application-binary'
));
}
},
overrides:
<
Type
,
Generator
>{
FileSystem:
()
=>
MemoryFileSystem
(),
...
...
@@ -115,10 +115,10 @@ void main() {
}
final
BufferLogger
bufferLogger
=
globals
.
logger
as
BufferLogger
;
expect
(
bufferLogger
.
statusText
,
isNot
(
contains
(
expect
(
bufferLogger
.
statusText
,
contains
(
'Using --fast-start option with device mockdevice, but this device '
'does not support it. Overriding the setting to false.'
))
)
;
));
},
overrides:
<
Type
,
Generator
>{
FileSystem:
()
=>
MemoryFileSystem
(),
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment