Unverified Commit bc43b41d authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)

This option was defaulting to on, which was tickling some benchmarks
parent 084a7077
...@@ -25,7 +25,7 @@ class BuildCommand extends FlutterCommand { ...@@ -25,7 +25,7 @@ class BuildCommand extends FlutterCommand {
addSubcommand(BuildAarCommand()); addSubcommand(BuildAarCommand());
addSubcommand(BuildApkCommand(verboseHelp: verboseHelp)); addSubcommand(BuildApkCommand(verboseHelp: verboseHelp));
addSubcommand(BuildAppBundleCommand(verboseHelp: verboseHelp)); addSubcommand(BuildAppBundleCommand(verboseHelp: verboseHelp));
addSubcommand(BuildAotCommand(verboseHelp: verboseHelp)); addSubcommand(BuildAotCommand());
addSubcommand(BuildIOSCommand()); addSubcommand(BuildIOSCommand());
addSubcommand(BuildIOSFrameworkCommand( addSubcommand(BuildIOSFrameworkCommand(
aotBuilder: AotBuilder(), aotBuilder: AotBuilder(),
......
...@@ -14,7 +14,7 @@ import 'build.dart'; ...@@ -14,7 +14,7 @@ import 'build.dart';
/// Builds AOT snapshots into platform specific library containers. /// Builds AOT snapshots into platform specific library containers.
class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmentArtifacts { class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmentArtifacts {
BuildAotCommand({bool verboseHelp = false, this.aotBuilder}) { BuildAotCommand({this.aotBuilder}) {
addTreeShakeIconsFlag(); addTreeShakeIconsFlag();
usesTargetOption(); usesTargetOption();
addBuildModeFlags(); addBuildModeFlags();
...@@ -51,10 +51,6 @@ class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmen ...@@ -51,10 +51,6 @@ class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmen
help: 'Build the AOT bundle with bitcode. Requires a compatible bitcode engine.', help: 'Build the AOT bundle with bitcode. Requires a compatible bitcode engine.',
hide: true, hide: true,
); );
// --track-widget-creation is exposed as a flag here to deal with build
// invalidation issues, but it is ignored -- there are no plans to support
// it for AOT mode.
usesTrackWidgetCreation(hasEffect: false, verboseHelp: verboseHelp);
} }
AotBuilder aotBuilder; AotBuilder aotBuilder;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment