Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ba7cbea4
Unverified
Commit
ba7cbea4
authored
Oct 05, 2022
by
Ian Hickson
Committed by
GitHub
Oct 05, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix outdated comment about overflow (#112595)
parent
145904f6
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
7 deletions
+7
-7
refresh.dart
packages/flutter/lib/src/cupertino/refresh.dart
+7
-7
No files found.
packages/flutter/lib/src/cupertino/refresh.dart
View file @
ba7cbea4
...
...
@@ -380,13 +380,13 @@ class CupertinoSliverRefreshControl extends StatefulWidget {
)
{
final
double
percentageComplete
=
clampDouble
(
pulledExtent
/
refreshTriggerPullDistance
,
0.0
,
1.0
);
// Place the indicator at the top of the sliver that opens up.
Note that we're using
//
a Stack/Positioned widget because the CupertinoActivityIndicator does some internal
//
translations based on the current size (which grows as the user drags) that makes
//
Padding calculations difficult. Rather than be reliant on the internal implementation
//
of the activity indicator, the Positioned widget allows us to be explicit where the
//
widget gets placed. Also note that the indicator should appear over the top of the
//
dragged widget, hence the use of Overflow.visibl
e.
// Place the indicator at the top of the sliver that opens up.
We're using a
//
Stack/Positioned widget because the CupertinoActivityIndicator does some
//
internal translations based on the current size (which grows as the user drags)
//
that makes Padding calculations difficult. Rather than be reliant on the
//
internal implementation of the activity indicator, the Positioned widget allows
//
us to be explicit where the widget gets placed. The indicator should appear
//
over the top of the dragged widget, hence the use of Clip.non
e.
return
Center
(
child:
Stack
(
clipBehavior:
Clip
.
none
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment