Defensively handle case of VMservice message that has no id. (#8587)

b7f00a64 · Todd Volkert · GitHub · 44dbecc6 · b7f00a64
Commit b7f00a64 authored Mar 06, 2017 by Todd Volkert Committed by GitHub Mar 06, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

vmservice_record_replay.dart packages/flutter_tools/lib/src/vmservice_record_replay.dart +4 -0

No files found.
--- a/packages/flutter_tools/lib/src/vmservice_record_replay.dart
+++ b/packages/flutter_tools/lib/src/vmservice_record_replay.dart
@@ -83,6 +83,10 @@ abstract class _Message implements Comparable<_Message> {

  @override
  int compareTo(_Message other) {
+    if (id == null) {
+      printError('Invalid VMService message data detected: $data');
+      return -1;
+    }
    final int result = id.compareTo(other.id);
    if (result != 0) {
      return result;