Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b59982ec
Commit
b59982ec
authored
Feb 17, 2017
by
Todd Volkert
Committed by
GitHub
Feb 17, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Properly await future when starting app in daemon mode (#8227)
Fixes #8209
parent
90574b04
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
5 deletions
+5
-5
daemon.dart
packages/flutter_tools/lib/src/commands/daemon.dart
+4
-4
run.dart
packages/flutter_tools/lib/src/commands/run.dart
+1
-1
No files found.
packages/flutter_tools/lib/src/commands/daemon.dart
View file @
b59982ec
...
...
@@ -310,7 +310,7 @@ class AppDomain extends Domain {
BuildMode
buildMode
=
getBuildModeForName
(
mode
)
??
BuildMode
.
debug
;
AppInstance
app
=
startApp
(
AppInstance
app
=
await
startApp
(
device
,
projectDirectory
,
target
,
route
,
buildMode
,
startPaused
,
enableHotReload
);
...
...
@@ -322,14 +322,14 @@ class AppDomain extends Domain {
};
}
AppInstance
startApp
(
Future
<
AppInstance
>
startApp
(
Device
device
,
String
projectDirectory
,
String
target
,
String
route
,
BuildMode
buildMode
,
bool
startPaused
,
bool
enableHotReload
,
{
String
applicationBinary
,
String
projectRootPath
,
String
packagesFilePath
,
String
projectAssets
,
})
{
})
async
{
DebuggingOptions
options
;
switch
(
buildMode
)
{
...
...
@@ -401,7 +401,7 @@ class AppDomain extends Domain {
_sendAppEvent
(
app
,
'started'
);
});
app
.
_runInZone
(
this
,
()
async
{
a
wait
a
pp
.
_runInZone
(
this
,
()
async
{
try
{
await
runner
.
run
(
connectionInfoCompleter:
connectionInfoCompleter
,
...
...
packages/flutter_tools/lib/src/commands/run.dart
View file @
b59982ec
...
...
@@ -213,7 +213,7 @@ class RunCommand extends RunCommandBase {
notifyingLogger:
new
NotifyingLogger
(),
logToStdout:
true
);
AppInstance
app
;
try
{
app
=
daemon
.
appDomain
.
startApp
(
app
=
await
daemon
.
appDomain
.
startApp
(
device
,
fs
.
currentDirectory
.
path
,
targetFile
,
route
,
getBuildMode
(),
argResults
[
'start-paused'
],
hotMode
,
applicationBinary:
argResults
[
'use-application-binary'
],
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment