Unverified Commit b57499e7 authored by Stanislav Baranov's avatar Stanislav Baranov Committed by GitHub

Friendlier messages when using dynamic patching (#25863)

parent e4515824
...@@ -80,18 +80,17 @@ Future<void> build({ ...@@ -80,18 +80,17 @@ Future<void> build({
} else if (compilationTraceFilePath.isEmpty) { } else if (compilationTraceFilePath.isEmpty) {
// Disable JIT snapshotting if flag is empty. // Disable JIT snapshotting if flag is empty.
printStatus('JIT snapshot will be disabled for this build...'); printStatus('Code snapshot will be disabled for this build.');
compilationTraceFilePath = null; compilationTraceFilePath = null;
} else if (!fs.file(compilationTraceFilePath).existsSync()) { } else if (!fs.file(compilationTraceFilePath).existsSync()) {
// Be forgiving if compilation trace file is missing. // Be forgiving if compilation trace file is missing.
printError('Warning: Ignoring missing compiler training file $compilationTraceFilePath...'); printError('Warning: Ignoring missing compilation training file $compilationTraceFilePath.');
printStatus('JIT snapshot will not use compiler training...');
final File tmp = fs.systemTempDirectory.childFile('flutterEmptyCompilationTrace.txt'); final File tmp = fs.systemTempDirectory.childFile('flutterEmptyCompilationTrace.txt');
compilationTraceFilePath = (tmp..createSync(recursive: true)).path; compilationTraceFilePath = (tmp..createSync(recursive: true)).path;
} else { } else {
printStatus('JIT snapshot will use compiler training file $compilationTraceFilePath...'); printStatus('Code snapshot will use compilation training file $compilationTraceFilePath.');
} }
} }
......
...@@ -602,7 +602,7 @@ abstract class ResidentRunner { ...@@ -602,7 +602,7 @@ abstract class ResidentRunner {
for (FlutterDevice device in flutterDevices) { for (FlutterDevice device in flutterDevices) {
for (FlutterView view in device.views) { for (FlutterView view in device.views) {
final int index = device.views.indexOf(view); final int index = device.views.indexOf(view);
printStatus('Saving compilation trace for ' printStatus('Saving compilation training file for '
'${device.device.name}${index == 0 ? '' :'/Isolate$index'}...'); '${device.device.name}${index == 0 ? '' :'/Isolate$index'}...');
List<int> buffer; List<int> buffer;
...@@ -619,7 +619,7 @@ abstract class ResidentRunner { ...@@ -619,7 +619,7 @@ abstract class ResidentRunner {
outputFile.parent.createSync(recursive: true); outputFile.parent.createSync(recursive: true);
outputFile.writeAsBytesSync(buffer); outputFile.writeAsBytesSync(buffer);
printStatus('Compilation trace written to ${fs.path.relative(outputFile.path)}.'); printStatus('Compilation training written to ${fs.path.relative(outputFile.path)}.');
} }
} }
} }
......
...@@ -146,6 +146,9 @@ class ColdRunner extends ResidentRunner { ...@@ -146,6 +146,9 @@ class ColdRunner extends ResidentRunner {
} }
} }
if (haveDetails && !details) { if (haveDetails && !details) {
if (saveCompilationTrace) {
printStatus('Runtime compilation trace will be saved when flutter run quits...');
}
printStatus('For a more detailed help message, press "h". To quit, press "q".'); printStatus('For a more detailed help message, press "h". To quit, press "q".');
} else if (haveAnything) { } else if (haveAnything) {
printStatus('To repeat this help message, press "h". To quit, press "q".'); printStatus('To repeat this help message, press "h". To quit, press "q".');
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment