Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b468be30
Unverified
Commit
b468be30
authored
Aug 24, 2021
by
keyonghan
Committed by
GitHub
Aug 24, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use default value for `ResultData` when uploading metrics from test runner (#88749)
parent
b68cdfcf
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
6 deletions
+21
-6
metrics_center.dart
dev/devicelab/lib/framework/metrics_center.dart
+5
-3
metrics_center_test.dart
dev/devicelab/test/metrics_center_test.dart
+16
-3
No files found.
dev/devicelab/lib/framework/metrics_center.dart
View file @
b468be30
...
...
@@ -45,11 +45,13 @@ Future<FlutterDestination> connectFlutterDestination() async {
/// ]
/// }
List
<
MetricPoint
>
parse
(
Map
<
String
,
dynamic
>
resultsJson
)
{
final
List
<
String
>
scoreKeys
=
(
resultsJson
[
'BenchmarkScoreKeys'
]
as
List
<
dynamic
>).
cast
<
String
>();
final
Map
<
String
,
dynamic
>
resultData
=
resultsJson
[
'ResultData'
]
as
Map
<
String
,
dynamic
>;
final
List
<
String
>
scoreKeys
=
(
resultsJson
[
'BenchmarkScoreKeys'
]
as
List
<
dynamic
>?)?.
cast
<
String
>()
??
const
<
String
>[];
final
Map
<
String
,
dynamic
>
resultData
=
resultsJson
[
'ResultData'
]
as
Map
<
String
,
dynamic
>?
??
const
<
String
,
dynamic
>{};
final
String
gitBranch
=
(
resultsJson
[
'CommitBranch'
]
as
String
).
trim
();
final
String
gitSha
=
(
resultsJson
[
'CommitSha'
]
as
String
).
trim
();
final
String
builderName
=
resultsJson
[
'BuilderName'
]
as
String
;
final
String
builderName
=
(
resultsJson
[
'BuilderName'
]
as
String
).
trim
()
;
final
List
<
MetricPoint
>
metricPoints
=
<
MetricPoint
>[];
for
(
final
String
scoreKey
in
scoreKeys
)
{
metricPoints
.
add
(
...
...
dev/devicelab/test/metrics_center_test.dart
View file @
b468be30
...
...
@@ -16,17 +16,30 @@ void main() {
'BuilderName'
:
'test'
,
'ResultData'
:
<
String
,
dynamic
>{
'average_frame_build_time_millis'
:
0.4550425531914895
,
'90th_percentile_frame_build_time_millis'
:
0.473
'90th_percentile_frame_build_time_millis'
:
0.473
,
},
'BenchmarkScoreKeys'
:
<
String
>[
'average_frame_build_time_millis'
,
'90th_percentile_frame_build_time_millis'
]
'90th_percentile_frame_build_time_millis'
,
]
,
};
final
List
<
MetricPoint
>
metricPoints
=
parse
(
results
);
expect
(
metricPoints
[
0
].
value
,
equals
(
0.4550425531914895
));
expect
(
metricPoints
[
1
].
value
,
equals
(
0.473
));
});
test
(
'succeeds - null ResultData'
,
()
{
final
Map
<
String
,
dynamic
>
results
=
<
String
,
dynamic
>{
'CommitBranch'
:
'master'
,
'CommitSha'
:
'abc'
,
'BuilderName'
:
'test'
,
'ResultData'
:
null
,
'BenchmarkScoreKeys'
:
null
,
};
final
List
<
MetricPoint
>
metricPoints
=
parse
(
results
);
expect
(
metricPoints
.
length
,
0
);
});
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment