Unverified Commit b45a8f46 authored by Greg Spencer's avatar Greg Spencer Committed by GitHub

Revert "Remove unused --packages argument to gen_snapshot. (#28101)" (#28265)

This reverts commit 1c021506.

The pre-commit tests never actually ran, so it looked green when it wasn't. This breaks 16 tests that depend on the argument existing, even though it isn't actually used.
parent 5169ab59
......@@ -46,11 +46,13 @@ class GenSnapshot {
Future<int> run({
@required SnapshotType snapshotType,
@required String packagesPath,
IOSArch iosArch,
Iterable<String> additionalArgs = const <String>[],
}) {
final List<String> args = <String>[
'--causal_async_stacks',
'--packages=$packagesPath',
]..addAll(additionalArgs);
final String snapshotterPath = getSnapshotterPath(snapshotType);
......@@ -191,6 +193,7 @@ class AOTSnapshotter {
final SnapshotType snapshotType = SnapshotType(platform, buildMode);
final int genSnapshotExitCode = await genSnapshot.run(
snapshotType: snapshotType,
packagesPath: packageMap.packagesPath,
additionalArgs: genSnapshotArgs,
iosArch: iosArch,
);
......@@ -534,6 +537,7 @@ class JITSnapshotter {
final SnapshotType snapshotType = SnapshotType(platform, buildMode);
final int genSnapshotExitCode = await genSnapshot.run(
snapshotType: snapshotType,
packagesPath: packagesPath,
additionalArgs: genSnapshotArgs,
);
if (genSnapshotExitCode != 0) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment