Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b345ecc1
Unverified
Commit
b345ecc1
authored
Jul 09, 2020
by
Kate Lovett
Committed by
GitHub
Jul 09, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Skip Audit - Scheduler and Services libraries (#60934)
parent
00b1903b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
22 additions
and
16 deletions
+22
-16
asset_bundle_test.dart
packages/flutter/test/services/asset_bundle_test.dart
+1
-1
raw_keyboard_test.dart
packages/flutter/test/services/raw_keyboard_test.dart
+21
-15
No files found.
packages/flutter/test/services/asset_bundle_test.dart
View file @
b345ecc1
...
@@ -77,5 +77,5 @@ void main() {
...
@@ -77,5 +77,5 @@ void main() {
' Unable to load asset: key
\n
'
' Unable to load asset: key
\n
'
' HTTP status code: 404
\n
'
,
' HTTP status code: 404
\n
'
,
);
);
},
skip:
true
);
},
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/39998
}
}
packages/flutter/test/services/raw_keyboard_test.dart
View file @
b345ecc1
...
@@ -4,7 +4,6 @@
...
@@ -4,7 +4,6 @@
// @dart = 2.8
// @dart = 2.8
import
'package:flutter/foundation.dart'
;
import
'package:flutter/services.dart'
;
import
'package:flutter/services.dart'
;
import
'package:flutter/widgets.dart'
;
import
'package:flutter/widgets.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
...
@@ -107,7 +106,7 @@ void main() {
...
@@ -107,7 +106,7 @@ void main() {
expect
(
RawKeyboard
.
instance
.
keysPressed
,
isEmpty
,
reason:
'on
$platform
'
);
expect
(
RawKeyboard
.
instance
.
keysPressed
,
isEmpty
,
reason:
'on
$platform
'
);
}
}
}
}
},
skip:
kIsWeb
);
},
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/61021
testWidgets
(
'keysPressed is correct when modifier is released before key'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'keysPressed is correct when modifier is released before key'
,
(
WidgetTester
tester
)
async
{
for
(
final
String
platform
in
<
String
>[
'linux'
,
'android'
,
'macos'
,
'fuchsia'
,
'windows'
])
{
for
(
final
String
platform
in
<
String
>[
'linux'
,
'android'
,
'macos'
,
'fuchsia'
,
'windows'
])
{
...
@@ -152,7 +151,7 @@ void main() {
...
@@ -152,7 +151,7 @@ void main() {
await
simulateKeyUpEvent
(
LogicalKeyboardKey
.
keyA
,
platform:
platform
,
physicalKey:
PhysicalKeyboardKey
.
keyA
);
await
simulateKeyUpEvent
(
LogicalKeyboardKey
.
keyA
,
platform:
platform
,
physicalKey:
PhysicalKeyboardKey
.
keyA
);
expect
(
RawKeyboard
.
instance
.
keysPressed
,
isEmpty
,
reason:
'on
$platform
'
);
expect
(
RawKeyboard
.
instance
.
keysPressed
,
isEmpty
,
reason:
'on
$platform
'
);
}
}
}
,
skip:
kIsWeb
);
});
testWidgets
(
'keysPressed modifiers are synchronized with key events on macOS'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'keysPressed modifiers are synchronized with key events on macOS'
,
(
WidgetTester
tester
)
async
{
expect
(
RawKeyboard
.
instance
.
keysPressed
,
isEmpty
);
expect
(
RawKeyboard
.
instance
.
keysPressed
,
isEmpty
);
...
@@ -654,7 +653,8 @@ void main() {
...
@@ -654,7 +653,8 @@ void main() {
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
escape
));
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
escape
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
escape
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
escape
));
expect
(
data
.
keyLabel
,
isNull
);
expect
(
data
.
keyLabel
,
isNull
);
});
},
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/35347
test
(
'Modifier keyboard keys are correctly translated'
,
()
{
test
(
'Modifier keyboard keys are correctly translated'
,
()
{
final
RawKeyEvent
shiftLeftKeyEvent
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
final
RawKeyEvent
shiftLeftKeyEvent
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
'type'
:
'keydown'
,
'type'
:
'keydown'
,
...
@@ -667,8 +667,9 @@ void main() {
...
@@ -667,8 +667,9 @@ void main() {
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
keyLabel
,
isNull
);
expect
(
data
.
keyLabel
,
isNull
);
});
},
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/35347
},
skip:
isBrowser
);
});
group
(
'RawKeyEventDataMacOs'
,
()
{
group
(
'RawKeyEventDataMacOs'
,
()
{
const
Map
<
int
,
_ModifierCheck
>
modifierTests
=
<
int
,
_ModifierCheck
>{
const
Map
<
int
,
_ModifierCheck
>
modifierTests
=
<
int
,
_ModifierCheck
>{
RawKeyEventDataMacOs
.
modifierOption
|
RawKeyEventDataMacOs
.
modifierLeftOption
:
_ModifierCheck
(
ModifierKey
.
altModifier
,
KeyboardSide
.
left
),
RawKeyEventDataMacOs
.
modifierOption
|
RawKeyEventDataMacOs
.
modifierLeftOption
:
_ModifierCheck
(
ModifierKey
.
altModifier
,
KeyboardSide
.
left
),
...
@@ -784,7 +785,8 @@ void main() {
...
@@ -784,7 +785,8 @@ void main() {
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
escape
));
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
escape
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
escape
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
escape
));
expect
(
data
.
keyLabel
,
isNull
);
expect
(
data
.
keyLabel
,
isNull
);
});
},
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/35347
test
(
'Modifier keyboard keys are correctly translated'
,
()
{
test
(
'Modifier keyboard keys are correctly translated'
,
()
{
final
RawKeyEvent
shiftLeftKeyEvent
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
final
RawKeyEvent
shiftLeftKeyEvent
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
'type'
:
'keydown'
,
'type'
:
'keydown'
,
...
@@ -799,7 +801,8 @@ void main() {
...
@@ -799,7 +801,8 @@ void main() {
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
keyLabel
,
isNull
);
expect
(
data
.
keyLabel
,
isNull
);
});
},
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/35347
test
(
'Unprintable keyboard keys are correctly translated'
,
()
{
test
(
'Unprintable keyboard keys are correctly translated'
,
()
{
final
RawKeyEvent
leftArrowKey
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
final
RawKeyEvent
leftArrowKey
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
'type'
:
'keydown'
,
'type'
:
'keydown'
,
...
@@ -814,8 +817,8 @@ void main() {
...
@@ -814,8 +817,8 @@ void main() {
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
arrowLeft
));
expect
(
data
.
physicalKey
,
equals
(
PhysicalKeyboardKey
.
arrowLeft
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
arrowLeft
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
arrowLeft
));
expect
(
data
.
logicalKey
.
keyLabel
,
isNull
);
expect
(
data
.
logicalKey
.
keyLabel
,
isNull
);
}
);
}
,
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/35347
}
,
skip:
isBrowser
);
});
group
(
'RawKeyEventDataWindows'
,
()
{
group
(
'RawKeyEventDataWindows'
,
()
{
const
Map
<
int
,
_ModifierCheck
>
modifierTests
=
<
int
,
_ModifierCheck
>{
const
Map
<
int
,
_ModifierCheck
>
modifierTests
=
<
int
,
_ModifierCheck
>{
...
@@ -960,7 +963,8 @@ void main() {
...
@@ -960,7 +963,8 @@ void main() {
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
arrowLeft
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
arrowLeft
));
expect
(
data
.
logicalKey
.
keyLabel
,
isNull
);
expect
(
data
.
logicalKey
.
keyLabel
,
isNull
);
});
});
},
skip:
isBrowser
);
});
group
(
'RawKeyEventDataLinux-GFLW'
,
()
{
group
(
'RawKeyEventDataLinux-GFLW'
,
()
{
const
Map
<
int
,
_ModifierCheck
>
modifierTests
=
<
int
,
_ModifierCheck
>{
const
Map
<
int
,
_ModifierCheck
>
modifierTests
=
<
int
,
_ModifierCheck
>{
GLFWKeyHelper
.
modifierAlt
:
_ModifierCheck
(
ModifierKey
.
altModifier
,
KeyboardSide
.
any
),
GLFWKeyHelper
.
modifierAlt
:
_ModifierCheck
(
ModifierKey
.
altModifier
,
KeyboardSide
.
any
),
...
@@ -1112,7 +1116,8 @@ void main() {
...
@@ -1112,7 +1116,8 @@ void main() {
}
}
expect
(()
=>
_createFailingKey
(),
throwsAssertionError
);
expect
(()
=>
_createFailingKey
(),
throwsAssertionError
);
});
},
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/61039
test
(
'Control keyboard keys are correctly translated'
,
()
{
test
(
'Control keyboard keys are correctly translated'
,
()
{
final
RawKeyEvent
escapeKeyEvent
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
final
RawKeyEvent
escapeKeyEvent
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
'type'
:
'keydown'
,
'type'
:
'keydown'
,
...
@@ -1142,7 +1147,7 @@ void main() {
...
@@ -1142,7 +1147,7 @@ void main() {
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
keyLabel
,
isNull
);
expect
(
data
.
keyLabel
,
isNull
);
});
});
}
,
skip:
isBrowser
);
});
group
(
'RawKeyEventDataLinux-GTK'
,
()
{
group
(
'RawKeyEventDataLinux-GTK'
,
()
{
const
Map
<
int
,
_ModifierCheck
>
modifierTests
=
<
int
,
_ModifierCheck
>{
const
Map
<
int
,
_ModifierCheck
>
modifierTests
=
<
int
,
_ModifierCheck
>{
...
@@ -1295,7 +1300,8 @@ void main() {
...
@@ -1295,7 +1300,8 @@ void main() {
}
}
expect
(()
=>
_createFailingKey
(),
throwsAssertionError
);
expect
(()
=>
_createFailingKey
(),
throwsAssertionError
);
});
},
skip:
isBrowser
);
// https://github.com/flutter/flutter/issues/61039
test
(
'Control keyboard keys are correctly translated'
,
()
{
test
(
'Control keyboard keys are correctly translated'
,
()
{
final
RawKeyEvent
escapeKeyEvent
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
final
RawKeyEvent
escapeKeyEvent
=
RawKeyEvent
.
fromMessage
(
const
<
String
,
dynamic
>{
'type'
:
'keydown'
,
'type'
:
'keydown'
,
...
@@ -1325,7 +1331,7 @@ void main() {
...
@@ -1325,7 +1331,7 @@ void main() {
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
logicalKey
,
equals
(
LogicalKeyboardKey
.
shiftLeft
));
expect
(
data
.
keyLabel
,
isNull
);
expect
(
data
.
keyLabel
,
isNull
);
});
});
}
,
skip:
isBrowser
);
});
group
(
'RawKeyEventDataWeb'
,
()
{
group
(
'RawKeyEventDataWeb'
,
()
{
const
Map
<
int
,
ModifierKey
>
modifierTests
=
<
int
,
ModifierKey
>{
const
Map
<
int
,
ModifierKey
>
modifierTests
=
<
int
,
ModifierKey
>{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment