Commit b329894b authored by Hans Muller's avatar Hans Muller Committed by GitHub

Added byTooltip() to CommonFinders (#6178)

parent 4d8f4f42
...@@ -6,12 +6,6 @@ import 'package:flutter/material.dart'; ...@@ -6,12 +6,6 @@ import 'package:flutter/material.dart';
import 'package:flutter_gallery/gallery/app.dart'; import 'package:flutter_gallery/gallery/app.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
Finder byTooltip(WidgetTester tester, String message) {
return find.byWidgetPredicate((Widget widget) {
return widget is Tooltip && widget.message == message;
});
}
void main() { void main() {
TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized(); TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized();
if (binding is LiveTestWidgetsFlutterBinding) if (binding is LiveTestWidgetsFlutterBinding)
...@@ -44,7 +38,7 @@ void main() { ...@@ -44,7 +38,7 @@ void main() {
await tester.pump(); // start animation await tester.pump(); // start animation
await tester.pump(const Duration(seconds: 1)); // end animation await tester.pump(const Duration(seconds: 1)); // end animation
await tester.tap(byTooltip(tester, 'Show example code')); await tester.tap(find.byTooltip('Show example code'));
await tester.pump(); // start animation await tester.pump(); // start animation
await tester.pump(const Duration(seconds: 1)); // end animation await tester.pump(const Duration(seconds: 1)); // end animation
......
...@@ -6,16 +6,6 @@ import 'package:flutter/material.dart'; ...@@ -6,16 +6,6 @@ import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
import 'package:flutter_gallery/gallery/app.dart'; import 'package:flutter_gallery/gallery/app.dart';
Finder byTooltip(WidgetTester tester, String message) {
return find.byWidgetPredicate((Widget widget) {
return widget is Tooltip && widget.message == message;
});
}
Finder findNavigationMenuButton(WidgetTester tester) {
return byTooltip(tester, 'Open navigation menu');
}
void main() { void main() {
TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized(); TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized();
if (binding is LiveTestWidgetsFlutterBinding) if (binding is LiveTestWidgetsFlutterBinding)
......
...@@ -24,17 +24,6 @@ Finder findGalleryItemByRouteName(WidgetTester tester, String routeName) { ...@@ -24,17 +24,6 @@ Finder findGalleryItemByRouteName(WidgetTester tester, String routeName) {
}); });
} }
Finder byTooltip(WidgetTester tester, String message) {
return find.byWidgetPredicate((Widget widget) {
return widget is Tooltip && widget.message == message;
});
}
Finder findNavigationMenuButton(WidgetTester tester) =>
byTooltip(tester, 'Open navigation menu');
Finder findBackButton(WidgetTester tester) => byTooltip(tester, 'Back');
// Start a gallery demo and then go back. This function assumes that the // Start a gallery demo and then go back. This function assumes that the
// we're starting on the home route and that the submenu that contains // we're starting on the home route and that the submenu that contains
// the item for a demo that pushes route 'routeName' is already open. // the item for a demo that pushes route 'routeName' is already open.
...@@ -50,7 +39,7 @@ Future<Null> smokeDemo(WidgetTester tester, String routeName) async { ...@@ -50,7 +39,7 @@ Future<Null> smokeDemo(WidgetTester tester, String routeName) async {
expect(find.text(kCaption), findsNothing); expect(find.text(kCaption), findsNothing);
// Go back // Go back
Finder backButton = findBackButton(tester); Finder backButton = find.byTooltip('Back');
expect(backButton, findsOneWidget); expect(backButton, findsOneWidget);
await tester.tap(backButton); await tester.tap(backButton);
await tester.pump(); // Start the pop "back" operation. await tester.pump(); // Start the pop "back" operation.
...@@ -86,7 +75,7 @@ void main() { ...@@ -86,7 +75,7 @@ void main() {
tester.binding.debugAssertNoTransientCallbacks('A transient callback was still active after leaving route $routeName'); tester.binding.debugAssertNoTransientCallbacks('A transient callback was still active after leaving route $routeName');
} }
Finder navigationMenuButton = findNavigationMenuButton(tester); Finder navigationMenuButton = find.byTooltip('Open navigation menu');
expect(navigationMenuButton, findsOneWidget); expect(navigationMenuButton, findsOneWidget);
await tester.tap(navigationMenuButton); await tester.tap(navigationMenuButton);
await tester.pump(); // Start opening drawer. await tester.pump(); // Start opening drawer.
......
...@@ -2,7 +2,6 @@ ...@@ -2,7 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
import 'package:flutter_gallery/gallery/app.dart'; import 'package:flutter_gallery/gallery/app.dart';
...@@ -11,14 +10,6 @@ Future<String> mockUpdateUrlFetcher() { ...@@ -11,14 +10,6 @@ Future<String> mockUpdateUrlFetcher() {
return new Future<String>.value('http://www.example.com/'); return new Future<String>.value('http://www.example.com/');
} }
Finder byTooltip(WidgetTester tester, String message) {
return find.byWidgetPredicate((Widget widget) {
return widget is Tooltip && widget.message == message;
});
}
Finder findBackButton(WidgetTester tester) => byTooltip(tester, 'Back');
void main() { void main() {
TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized(); TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized();
if (binding is LiveTestWidgetsFlutterBinding) binding.allowAllFrames = true; if (binding is LiveTestWidgetsFlutterBinding) binding.allowAllFrames = true;
...@@ -38,7 +29,7 @@ void main() { ...@@ -38,7 +29,7 @@ void main() {
await tester.pump(); // Launch shrine await tester.pump(); // Launch shrine
await tester.pump(const Duration(seconds: 1)); // transition is complete await tester.pump(const Duration(seconds: 1)); // transition is complete
Finder backButton = findBackButton(tester); Finder backButton = find.byTooltip('Back');
expect(backButton, findsOneWidget); expect(backButton, findsOneWidget);
await tester.tap(backButton); await tester.tap(backButton);
await tester.pump(); // Start the pop "back" operation. await tester.pump(); // Start the pop "back" operation.
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
import 'package:flutter/widgets.dart'; import 'package:flutter/material.dart';
import 'all_elements.dart'; import 'all_elements.dart';
...@@ -124,6 +124,21 @@ class CommonFinders { ...@@ -124,6 +124,21 @@ class CommonFinders {
return new _WidgetPredicateFinder(predicate, skipOffstage: skipOffstage); return new _WidgetPredicateFinder(predicate, skipOffstage: skipOffstage);
} }
/// Finds Tooltip widgets with the given message.
///
/// Example:
///
/// expect(tester, hasWidget(find.byTooltip('Back')));
///
/// If the `skipOffstage` argument is true (the default), then this skips
/// nodes that are [Offstage] or that are from inactive [Route]s.
Finder byTooltip(String message, { bool skipOffstage: true }) {
return byWidgetPredicate(
(Widget widget) => widget is Tooltip && widget.message == message,
skipOffstage: skipOffstage,
);
}
/// Finds widgets using an element predicate. /// Finds widgets using an element predicate.
/// ///
/// Example: /// Example:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment