Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b264b614
Unverified
Commit
b264b614
authored
Apr 28, 2022
by
apeltop
Committed by
GitHub
Apr 28, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Correct typos (#102487)
parent
57a688c1
Changes
8
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
12 additions
and
12 deletions
+12
-12
binding.dart
packages/flutter/lib/src/foundation/binding.dart
+1
-1
ink_sparkle.dart
packages/flutter/lib/src/material/ink_sparkle.dart
+4
-4
material_state.dart
packages/flutter/lib/src/material/material_state.dart
+1
-1
default_text_editing_shortcuts.dart
...utter/lib/src/widgets/default_text_editing_shortcuts.dart
+1
-1
keyboard_listener.dart
packages/flutter/lib/src/widgets/keyboard_listener.dart
+1
-1
dialog_test.dart
packages/flutter/test/material/dialog_test.dart
+2
-2
paginated_data_table_test.dart
...ages/flutter/test/material/paginated_data_table_test.dart
+1
-1
hardware_keyboard_test.dart
packages/flutter/test/services/hardware_keyboard_test.dart
+1
-1
No files found.
packages/flutter/lib/src/foundation/binding.dart
View file @
b264b614
...
@@ -370,7 +370,7 @@ abstract class BindingBase {
...
@@ -370,7 +370,7 @@ abstract class BindingBase {
/// before the point in the application code that wants to initialize the binding, or
/// before the point in the application code that wants to initialize the binding, or
/// to verify that the binding is the one that is expected.
/// to verify that the binding is the one that is expected.
///
///
/// For example, if an application uses [Zone]s to report uncaught ex
ec
ptions, it may
/// For example, if an application uses [Zone]s to report uncaught ex
ce
ptions, it may
/// need to ensure that `ensureInitialized()` has not yet been invoked on any binding
/// need to ensure that `ensureInitialized()` has not yet been invoked on any binding
/// at the point where it configures the zone and initializes the binding.
/// at the point where it configures the zone and initializes the binding.
///
///
...
...
packages/flutter/lib/src/material/ink_sparkle.dart
View file @
b264b614
...
@@ -89,7 +89,7 @@ class InkSparkle extends InteractiveInkFeature {
...
@@ -89,7 +89,7 @@ class InkSparkle extends InteractiveInkFeature {
/// is clipped with [rectCallback].
/// is clipped with [rectCallback].
/// When the ripple is removed, [onRemoved] will be called.
/// When the ripple is removed, [onRemoved] will be called.
///
///
/// [turbulenceSeed] can be passed if a non random seed shold be used for
/// [turbulenceSeed] can be passed if a non random seed sho
u
ld be used for
/// the turbulence and sparkles. By default, the seed is a random number
/// the turbulence and sparkles. By default, the seed is a random number
/// between 0.0 and 1000.0.
/// between 0.0 and 1000.0.
///
///
...
@@ -291,7 +291,7 @@ class InkSparkle extends InteractiveInkFeature {
...
@@ -291,7 +291,7 @@ class InkSparkle extends InteractiveInkFeature {
double
get
_height
=>
referenceBox
.
size
.
height
;
double
get
_height
=>
referenceBox
.
size
.
height
;
/// All double values for uniforms come from the Android 12 ripple
/// All double values for uniforms come from the Android 12 ripple
/// implentation from the following files:
/// imple
me
ntation from the following files:
/// - https://cs.android.com/android/platform/superproject/+/master:frameworks/base/graphics/java/android/graphics/drawable/RippleShader.java
/// - https://cs.android.com/android/platform/superproject/+/master:frameworks/base/graphics/java/android/graphics/drawable/RippleShader.java
/// - https://cs.android.com/android/platform/superproject/+/master:frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
/// - https://cs.android.com/android/platform/superproject/+/master:frameworks/base/graphics/java/android/graphics/drawable/RippleDrawable.java
/// - https://cs.android.com/android/platform/superproject/+/master:frameworks/base/graphics/java/android/graphics/drawable/RippleAnimationSession.java
/// - https://cs.android.com/android/platform/superproject/+/master:frameworks/base/graphics/java/android/graphics/drawable/RippleAnimationSession.java
...
@@ -319,11 +319,11 @@ class InkSparkle extends InteractiveInkFeature {
...
@@ -319,11 +319,11 @@ class InkSparkle extends InteractiveInkFeature {
uSparkleAlpha:
_sparkleAlpha
.
value
,
uSparkleAlpha:
_sparkleAlpha
.
value
,
// The following uniforms are driven by the turbulence phase and change
// The following uniforms are driven by the turbulence phase and change
// each frame of the animation. The
ese unifro
ms are uses to modify the
// each frame of the animation. The
se unifor
ms are uses to modify the
// default (if these fields are unset or 0) circular outer ring to a
// default (if these fields are unset or 0) circular outer ring to a
// non-uniform shape that is more like an actual ink splash. In addition
// non-uniform shape that is more like an actual ink splash. In addition
// to the positional based triangular noise created in the shader, these
// to the positional based triangular noise created in the shader, these
// uniforms also vary the appear
e
nce of the sparkles even when the same
// uniforms also vary the appear
a
nce of the sparkles even when the same
// location is tapped.
// location is tapped.
uTurbulencePhase:
turbulencePhase
,
uTurbulencePhase:
turbulencePhase
,
uNoisePhase:
noisePhase
/
1000.0
,
uNoisePhase:
noisePhase
/
1000.0
,
...
...
packages/flutter/lib/src/material/material_state.dart
View file @
b264b614
...
@@ -561,7 +561,7 @@ abstract class MaterialStateUnderlineInputBorder extends UnderlineInputBorder im
...
@@ -561,7 +561,7 @@ abstract class MaterialStateUnderlineInputBorder extends UnderlineInputBorder im
/// Creates a [MaterialStateUnderlineInputBorder] from a [MaterialPropertyResolver<InputBorder>]
/// Creates a [MaterialStateUnderlineInputBorder] from a [MaterialPropertyResolver<InputBorder>]
/// callback function.
/// callback function.
///
///
/// If used as a regular i
onput bort
der, the border resolved in the default state (the
/// If used as a regular i
nput bor
der, the border resolved in the default state (the
/// empty set of states) will be used.
/// empty set of states) will be used.
///
///
/// The given callback parameter must return a non-null text style in the default
/// The given callback parameter must return a non-null text style in the default
...
...
packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart
View file @
b264b614
...
@@ -157,7 +157,7 @@ class DefaultTextEditingShortcuts extends Shortcuts {
...
@@ -157,7 +157,7 @@ class DefaultTextEditingShortcuts extends Shortcuts {
);
);
// These are shortcuts are shared between most platforms except macOS for it
// These are shortcuts are shared between most platforms except macOS for it
// uses different modifier keys as the line/word modifer.
// uses different modifier keys as the line/word modif
i
er.
static
final
Map
<
ShortcutActivator
,
Intent
>
_commonShortcuts
=
<
ShortcutActivator
,
Intent
>{
static
final
Map
<
ShortcutActivator
,
Intent
>
_commonShortcuts
=
<
ShortcutActivator
,
Intent
>{
// Delete Shortcuts.
// Delete Shortcuts.
for
(
final
bool
pressShift
in
const
<
bool
>[
true
,
false
])
for
(
final
bool
pressShift
in
const
<
bool
>[
true
,
false
])
...
...
packages/flutter/lib/src/widgets/keyboard_listener.dart
View file @
b264b614
...
@@ -23,7 +23,7 @@ export 'package:flutter/services.dart' show KeyEvent;
...
@@ -23,7 +23,7 @@ export 'package:flutter/services.dart' show KeyEvent;
///
///
/// The [KeyboardListener] is different from [RawKeyboardListener] in that
/// The [KeyboardListener] is different from [RawKeyboardListener] in that
/// [KeyboardListener] uses the newer [HardwareKeyboard] API, which is
/// [KeyboardListener] uses the newer [HardwareKeyboard] API, which is
/// prefer
r
able.
/// preferable.
///
///
/// See also:
/// See also:
///
///
...
...
packages/flutter/test/material/dialog_test.dart
View file @
b264b614
...
@@ -639,7 +639,7 @@ void main() {
...
@@ -639,7 +639,7 @@ void main() {
tester
.
getBottomRight
(
_findButtonBar
()).
dx
-
8.0
,
tester
.
getBottomRight
(
_findButtonBar
()).
dx
-
8.0
,
);
// right
);
// right
// Dismiss it and test mater
ai
l 3 dialog
// Dismiss it and test mater
ia
l 3 dialog
await
tester
.
tapAt
(
const
Offset
(
10.0
,
10.0
));
await
tester
.
tapAt
(
const
Offset
(
10.0
,
10.0
));
await
tester
.
pumpAndSettle
();
await
tester
.
pumpAndSettle
();
...
@@ -2266,7 +2266,7 @@ void main() {
...
@@ -2266,7 +2266,7 @@ void main() {
expect
(
tester
.
getTopLeft
(
find
.
byKey
(
actionKey
)).
dx
,
800
-
20
);
expect
(
tester
.
getTopLeft
(
find
.
byKey
(
actionKey
)).
dx
,
800
-
20
);
expect
(
tester
.
getTopRight
(
find
.
byKey
(
actionKey
)).
dx
,
800
);
expect
(
tester
.
getTopRight
(
find
.
byKey
(
actionKey
)).
dx
,
800
);
// All possible al
gi
nment values
// All possible al
ig
nment values
await
tester
.
pumpWidget
(
buildFrame
(
MainAxisAlignment
.
start
));
await
tester
.
pumpWidget
(
buildFrame
(
MainAxisAlignment
.
start
));
expect
(
tester
.
getTopLeft
(
find
.
byKey
(
actionKey
)).
dx
,
0
);
expect
(
tester
.
getTopLeft
(
find
.
byKey
(
actionKey
)).
dx
,
0
);
...
...
packages/flutter/test/material/paginated_data_table_test.dart
View file @
b264b614
...
@@ -776,7 +776,7 @@ void main() {
...
@@ -776,7 +776,7 @@ void main() {
const
double
height
=
400
;
const
double
height
=
400
;
// By default, the margin of a Card is 4 in all directions, so
// By default, the margin of a Card is 4 in all directions, so
// the size of the DataTable (inside the Card) is horizont
ic
ally
// the size of the DataTable (inside the Card) is horizontally
// reduced by 4 * 2; the left and right margins.
// reduced by 4 * 2; the left and right margins.
const
double
cardMargin
=
8
;
const
double
cardMargin
=
8
;
...
...
packages/flutter/test/services/hardware_keyboard_test.dart
View file @
b264b614
...
@@ -332,7 +332,7 @@ void main() {
...
@@ -332,7 +332,7 @@ void main() {
// In that case, the key data should not be converted to any [KeyEvent]s,
// In that case, the key data should not be converted to any [KeyEvent]s,
// but is only used so that *a* key data comes before the raw key message
// but is only used so that *a* key data comes before the raw key message
// and makes [KeyEventManager] infer [KeyDataTransitMode.keyDataThenRawKeyData].
// and makes [KeyEventManager] infer [KeyDataTransitMode.keyDataThenRawKeyData].
testWidgets
(
'Empty keyData yields no event but triggers infer
r
ence'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'Empty keyData yields no event but triggers inference'
,
(
WidgetTester
tester
)
async
{
final
List
<
KeyEvent
>
events
=
<
KeyEvent
>[];
final
List
<
KeyEvent
>
events
=
<
KeyEvent
>[];
final
List
<
RawKeyEvent
>
rawEvents
=
<
RawKeyEvent
>[];
final
List
<
RawKeyEvent
>
rawEvents
=
<
RawKeyEvent
>[];
tester
.
binding
.
keyboard
.
addHandler
((
KeyEvent
event
)
{
tester
.
binding
.
keyboard
.
addHandler
((
KeyEvent
event
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment