Remove TODOs added for HTTP abort() change in dart sdk (#63924)

b1c17313 · zichangg · GitHub · b2c0970a · b1c17313 · b1c17313
Unverified Commit b1c17313 authored Aug 17, 2020 by zichangg Committed by GitHub Aug 17, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 4 deletions

_binding_io.dart packages/flutter_test/lib/src/_binding_io.dart +0 -2

testbed.dart packages/flutter_tools/test/src/testbed.dart +0 -2

No files found.
--- a/packages/flutter_test/lib/src/_binding_io.dart
+++ b/packages/flutter_test/lib/src/_binding_io.dart
@@ -228,9 +228,7 @@ class _MockHttpRequest extends HttpClientRequest {
    return Future<HttpClientResponse>.value(_MockHttpResponse());
  }

-  // TODO(zichangguo): remove the ignore after the change in dart:io lands.
  @override
-  // ignore: override_on_non_overriding_member
  void abort([Object exception, StackTrace stackTrace]) {}

  @override

--- a/packages/flutter_tools/test/src/testbed.dart
+++ b/packages/flutter_tools/test/src/testbed.dart
@@ -378,9 +378,7 @@ class FakeHttpClientRequest implements HttpClientRequest {
  @override
  void writeln([Object obj = '']) {}

-  // TODO(zichangguo): remove the ignore after the change in dart:io lands.
  @override
-  // ignore: override_on_non_overriding_member
  void abort([Object exception, StackTrace stackTrace]) {}
 }