Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b1330eff
Unverified
Commit
b1330eff
authored
Apr 24, 2018
by
Alexander Aprelev
Committed by
GitHub
Apr 24, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fail test execution if compiler reported errors. (#16895)
Fixes
https://github.com/flutter/flutter/issues/16496
parent
de8a53c5
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
5 deletions
+5
-5
flutter_platform.dart
packages/flutter_tools/lib/src/test/flutter_platform.dart
+5
-5
No files found.
packages/flutter_tools/lib/src/test/flutter_platform.dart
View file @
b1330eff
...
...
@@ -151,11 +151,11 @@ class _Compiler {
request
.
path
);
final
String
outputPath
=
compilerOutput
?.
outputFilename
;
//
Check if the compiler produced the output. If it failed the
n
//
outputPath would be null. In this case pass null upwards to
the
// co
nsumer and shutdown the compiler to avoid reusing compiler
//
that might have gotten into
a weird state.
if
(
outputPath
==
null
)
{
//
In case compiler didn't produce output or reported compilatio
n
//
errors, pass [null] upwards to the consumer and shutdown
the
// co
mpiler to avoid reusing compiler that might have gotten into
// a weird state.
if
(
outputPath
==
null
||
compilerOutput
.
errorCount
>
0
)
{
request
.
result
.
complete
(
null
);
await
shutdown
();
}
else
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment