Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
afb6b955
Unverified
Commit
afb6b955
authored
Dec 04, 2020
by
Jonah Williams
Committed by
GitHub
Dec 04, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tool] fix incorrect coverage file generation (#71726)
parent
e5f2236a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
3 deletions
+6
-3
test.dart
packages/flutter_tools/lib/src/commands/test.dart
+2
-1
coverage_collector.dart
packages/flutter_tools/lib/src/test/coverage_collector.dart
+0
-1
coverage_collection_test.dart
...ools/test/integration.shard/coverage_collection_test.dart
+4
-1
No files found.
packages/flutter_tools/lib/src/commands/test.dart
View file @
afb6b955
...
...
@@ -251,7 +251,8 @@ class TestCommand extends FlutterCommand {
verbose:
!
machine
,
libraryPredicate:
(
String
libraryName
)
=>
libraryName
.
contains
(
projectName
),
// TODO(jonahwilliams): file bug for incorrect URI handling on windows
packagesPath:
globals
.
fs
.
path
.
absolute
(
'.packages'
),
packagesPath:
globals
.
fs
.
file
(
buildInfo
.
packagesPath
)
.
parent
.
parent
.
childFile
(
'.packages'
).
path
);
}
...
...
packages/flutter_tools/lib/src/test/coverage_collector.dart
View file @
afb6b955
...
...
@@ -117,7 +117,6 @@ class CoverageCollector extends TestWatcher {
Future
<
String
>
finalizeCoverage
({
coverage
.
Formatter
formatter
,
Directory
coverageDirectory
,
String
packagesPath
,
})
async
{
if
(
_globalHitmap
==
null
)
{
return
null
;
...
...
packages/flutter_tools/test/integration.shard/coverage_collection_test.dart
View file @
afb6b955
...
...
@@ -29,6 +29,9 @@ void main() {
await
flutter
.
test
(
coverage:
true
);
await
flutter
.
done
;
expect
(
tempDir
.
childDirectory
(
'coverage'
).
childFile
(
'lcov.info'
),
exists
);
final
File
lcovFile
=
tempDir
.
childDirectory
(
'coverage'
).
childFile
(
'lcov.info'
);
expect
(
lcovFile
,
exists
);
expect
(
lcovFile
.
readAsStringSync
(),
contains
(
'main.dart'
));
// either 'SF:lib/main.dart or SF:lib\\main.dart
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment