Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
aecb7d96
Unverified
Commit
aecb7d96
authored
Jun 12, 2018
by
Keerti Parthasarathy
Committed by
GitHub
Jun 12, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes for Dart 2 failures in tests (#18371)
parent
b8b34def
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
5 deletions
+5
-5
android_device.dart
packages/flutter_tools/lib/src/android/android_device.dart
+1
-1
device.dart
packages/flutter_tools/lib/src/device.dart
+1
-1
mac.dart
packages/flutter_tools/lib/src/ios/mac.dart
+1
-1
simulators.dart
packages/flutter_tools/lib/src/ios/simulators.dart
+2
-2
No files found.
packages/flutter_tools/lib/src/android/android_device.dart
View file @
aecb7d96
...
...
@@ -510,7 +510,7 @@ class AndroidDevice extends Device {
bool
get
supportsScreenshot
=>
true
;
@override
Future
<
Null
>
takeScreenshot
(
File
outputFile
)
async
{
Future
<
void
>
takeScreenshot
(
File
outputFile
)
async
{
const
String
remotePath
=
'/data/local/tmp/flutter_screenshot.png'
;
await
runCheckedAsync
(
adbCommandForDevice
(<
String
>[
'shell'
,
'screencap'
,
'-p'
,
remotePath
]));
await
runCheckedAsync
(
adbCommandForDevice
(<
String
>[
'pull'
,
remotePath
,
outputFile
.
path
]));
...
...
packages/flutter_tools/lib/src/device.dart
View file @
aecb7d96
...
...
@@ -277,7 +277,7 @@ abstract class Device {
bool
get
supportsScreenshot
=>
false
;
Future
<
Null
>
takeScreenshot
(
File
outputFile
)
=>
new
Future
<
Null
>.
error
(
'unimplemented'
);
Future
<
void
>
takeScreenshot
(
File
outputFile
)
=>
new
Future
<
Null
>.
error
(
'unimplemented'
);
/// Find the apps that are currently running on this device.
Future
<
List
<
DiscoveredApp
>>
discoverApps
()
=>
...
...
packages/flutter_tools/lib/src/ios/mac.dart
View file @
aecb7d96
...
...
@@ -98,7 +98,7 @@ class IMobileDevice {
Future
<
Process
>
startLogger
()
=>
runCommand
(<
String
>[
'idevicesyslog'
]);
/// Captures a screenshot to the specified outputFile.
Future
<
Null
>
takeScreenshot
(
File
outputFile
)
{
Future
<
void
>
takeScreenshot
(
File
outputFile
)
{
return
runCheckedAsync
(<
String
>[
'idevicescreenshot'
,
outputFile
.
path
]);
}
}
...
...
packages/flutter_tools/lib/src/ios/simulators.dart
View file @
aecb7d96
...
...
@@ -137,7 +137,7 @@ class SimControl {
return
runCheckedAsync
(
args
);
}
Future
<
Null
>
takeScreenshot
(
String
deviceId
,
String
outputPath
)
{
Future
<
void
>
takeScreenshot
(
String
deviceId
,
String
outputPath
)
{
return
runCheckedAsync
(<
String
>[
_xcrunPath
,
'simctl'
,
'io'
,
deviceId
,
'screenshot'
,
outputPath
]);
}
}
...
...
@@ -458,7 +458,7 @@ class IOSSimulator extends Device {
bool
get
supportsScreenshot
=>
_xcodeVersionSupportsScreenshot
;
@override
Future
<
Null
>
takeScreenshot
(
File
outputFile
)
{
Future
<
void
>
takeScreenshot
(
File
outputFile
)
{
return
SimControl
.
instance
.
takeScreenshot
(
id
,
outputFile
.
path
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment