Unverified Commit adb3f138 authored by Michael Goderbauer's avatar Michael Goderbauer Committed by GitHub

Enable vm:notify-debugger-on-exception on handlePlatformMessage (#81987)

parent 8eca86de
...@@ -288,10 +288,7 @@ class _DefaultBinaryMessenger extends BinaryMessenger { ...@@ -288,10 +288,7 @@ class _DefaultBinaryMessenger extends BinaryMessenger {
} }
@override @override
// TODO(goderbauer): Add pragma (and enable test in @pragma('vm:notify-debugger-on-exception')
// break_on_framework_exceptions_test.dart) when it works on async methods,
// https://github.com/dart-lang/sdk/issues/45673
// @pragma('vm:notify-debugger-on-exception')
Future<void> handlePlatformMessage( Future<void> handlePlatformMessage(
String channel, String channel,
ByteData? data, ByteData? data,
......
...@@ -122,7 +122,7 @@ void main() { ...@@ -122,7 +122,7 @@ void main() {
final int breakLine = (await flutter.getSourceLocation()).line; final int breakLine = (await flutter.getSourceLocation()).line;
expect(breakLine, project.lineContaining(project.test, "throw 'platform message callback';")); expect(breakLine, project.lineContaining(project.test, "throw 'platform message callback';"));
}, skip: 'TODO(goderbauer): add pragma to _DefaultBinaryMessenger.handlePlatformMessage when async methods are supported (https://github.com/dart-lang/sdk/issues/45673) and enable this test'); });
testWithoutContext('breaks when SliverChildBuilderDelegate.builder throws', () async { testWithoutContext('breaks when SliverChildBuilderDelegate.builder throws', () async {
final TestProject project = TestProject( final TestProject project = TestProject(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment