Commit ad718a8d authored by Adam Barth's avatar Adam Barth

Teach flutter logs to show only new logs

After this patch, the flutter logs command on Android shows only log messages
since the command was run. Previously, it showed historical logs, which was
confusing.

Fixes #2013
parent ed345073
...@@ -297,7 +297,7 @@ class AndroidDevice extends Device { ...@@ -297,7 +297,7 @@ class AndroidDevice extends Device {
// Return the most recent timestamp in the Android log. The format can be // Return the most recent timestamp in the Android log. The format can be
// passed to logcat's -T option. // passed to logcat's -T option.
String lastLogcatTimestamp() { String get lastLogcatTimestamp {
String output = runCheckedSync(adbCommandForDevice(<String>[ String output = runCheckedSync(adbCommandForDevice(<String>[
'-s', id, 'logcat', '-v', 'time', '-t', '1' '-s', id, 'logcat', '-v', 'time', '-t', '1'
])); ]));
...@@ -310,7 +310,7 @@ class AndroidDevice extends Device { ...@@ -310,7 +310,7 @@ class AndroidDevice extends Device {
Future<String> stopTracing(AndroidApk apk, { String outPath }) async { Future<String> stopTracing(AndroidApk apk, { String outPath }) async {
// Workaround for logcat -c not always working: // Workaround for logcat -c not always working:
// http://stackoverflow.com/questions/25645012/logcat-on-android-l-not-clearing-after-unplugging-and-reconnecting // http://stackoverflow.com/questions/25645012/logcat-on-android-l-not-clearing-after-unplugging-and-reconnecting
String beforeStop = lastLogcatTimestamp(); String beforeStop = lastLogcatTimestamp;
runCheckedSync(adbCommandForDevice(<String>[ runCheckedSync(adbCommandForDevice(<String>[
'shell', 'shell',
'am', 'am',
...@@ -472,6 +472,8 @@ class _AdbLogReader extends DeviceLogReader { ...@@ -472,6 +472,8 @@ class _AdbLogReader extends DeviceLogReader {
'logcat', 'logcat',
'-v', '-v',
'tag', // Only log the tag and the message 'tag', // Only log the tag and the message
'-T',
device.lastLogcatTimestamp,
'-s', '-s',
'flutter:V', 'flutter:V',
'ActivityManager:W', 'ActivityManager:W',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment