Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ac88d4ba
Unverified
Commit
ac88d4ba
authored
Oct 08, 2021
by
Konstantin Scheglov
Committed by
GitHub
Oct 08, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix avoid_renaming_method_parameters for pending analyzer change. (#85482)
parent
a44f3732
Changes
8
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
42 additions
and
42 deletions
+42
-42
recorder.dart
dev/benchmarks/macrobenchmarks/lib/src/web/recorder.dart
+4
-4
material_localizations.dart
...ages/flutter/lib/src/material/material_localizations.dart
+2
-2
message_codecs.dart
packages/flutter/lib/src/services/message_codecs.dart
+6
-6
autofill.dart
packages/flutter/lib/src/widgets/autofill.dart
+1
-1
scrollable.dart
packages/flutter/lib/src/widgets/scrollable.dart
+4
-4
scrollbar.dart
packages/flutter/lib/src/widgets/scrollbar.dart
+14
-14
widget_inspector.dart
packages/flutter/lib/src/widgets/widget_inspector.dart
+4
-4
material_localizations.dart
...flutter_localizations/lib/src/material_localizations.dart
+7
-7
No files found.
dev/benchmarks/macrobenchmarks/lib/src/web/recorder.dart
View file @
ac88d4ba
...
...
@@ -347,8 +347,8 @@ abstract class WidgetRecorder extends Recorder implements FrameRecorder {
final
List
<
VoidCallback
>
_didStopCallbacks
=
<
VoidCallback
>[];
@override
void
registerDidStop
(
VoidCallback
fn
)
{
_didStopCallbacks
.
add
(
fn
);
void
registerDidStop
(
VoidCallback
cb
)
{
_didStopCallbacks
.
add
(
cb
);
}
@override
...
...
@@ -443,8 +443,8 @@ abstract class WidgetBuildRecorder extends Recorder implements FrameRecorder {
final
List
<
VoidCallback
>
_didStopCallbacks
=
<
VoidCallback
>[];
@override
void
registerDidStop
(
VoidCallback
fn
)
{
_didStopCallbacks
.
add
(
fn
);
void
registerDidStop
(
VoidCallback
cb
)
{
_didStopCallbacks
.
add
(
cb
);
}
@override
...
...
packages/flutter/lib/src/material/material_localizations.dart
View file @
ac88d4ba
...
...
@@ -762,10 +762,10 @@ class DefaultMaterialLocalizations implements MaterialLocalizations {
String
get
dateRangeEndLabel
=>
'End Date'
;
@override
String
dateRangeStartDateSemanticLabel
(
String
f
ullDate
)
=>
'Start date
$full
Date
'
;
String
dateRangeStartDateSemanticLabel
(
String
f
ormattedDate
)
=>
'Start date
$formatted
Date
'
;
@override
String
dateRangeEndDateSemanticLabel
(
String
f
ullDate
)
=>
'End date
$full
Date
'
;
String
dateRangeEndDateSemanticLabel
(
String
f
ormattedDate
)
=>
'End date
$formatted
Date
'
;
@override
String
get
invalidDateFormatLabel
=>
'Invalid format.'
;
...
...
packages/flutter/lib/src/services/message_codecs.dart
View file @
ac88d4ba
...
...
@@ -123,10 +123,10 @@ class JSONMethodCodec implements MethodCodec {
const
JSONMethodCodec
();
@override
ByteData
encodeMethodCall
(
MethodCall
c
all
)
{
ByteData
encodeMethodCall
(
MethodCall
methodC
all
)
{
return
const
JSONMessageCodec
().
encodeMessage
(<
String
,
Object
?>{
'method'
:
c
all
.
method
,
'args'
:
c
all
.
arguments
,
'method'
:
methodC
all
.
method
,
'args'
:
methodC
all
.
arguments
,
})!;
}
...
...
@@ -555,10 +555,10 @@ class StandardMethodCodec implements MethodCodec {
final
StandardMessageCodec
messageCodec
;
@override
ByteData
encodeMethodCall
(
MethodCall
c
all
)
{
ByteData
encodeMethodCall
(
MethodCall
methodC
all
)
{
final
WriteBuffer
buffer
=
WriteBuffer
();
messageCodec
.
writeValue
(
buffer
,
c
all
.
method
);
messageCodec
.
writeValue
(
buffer
,
c
all
.
arguments
);
messageCodec
.
writeValue
(
buffer
,
methodC
all
.
method
);
messageCodec
.
writeValue
(
buffer
,
methodC
all
.
arguments
);
return
buffer
.
done
();
}
...
...
packages/flutter/lib/src/widgets/autofill.dart
View file @
ac88d4ba
...
...
@@ -129,7 +129,7 @@ class AutofillGroupState extends State<AutofillGroup> with AutofillScopeMixin {
bool
_isTopmostAutofillGroup
=
false
;
@override
AutofillClient
?
getAutofillClient
(
String
tag
)
=>
_clients
[
tag
];
AutofillClient
?
getAutofillClient
(
String
autofillId
)
=>
_clients
[
autofillId
];
@override
Iterable
<
AutofillClient
>
get
autofillClients
{
...
...
packages/flutter/lib/src/widgets/scrollable.dart
View file @
ac88d4ba
...
...
@@ -539,10 +539,10 @@ class ScrollableState extends State<Scrollable> with TickerProviderStateMixin, R
@override
@protected
void
setCanDrag
(
bool
canDrag
)
{
if
(
canDrag
==
_lastCanDrag
&&
(!
canDrag
||
widget
.
axis
==
_lastAxisDirection
))
void
setCanDrag
(
bool
value
)
{
if
(
value
==
_lastCanDrag
&&
(!
value
||
widget
.
axis
==
_lastAxisDirection
))
return
;
if
(!
canDrag
)
{
if
(!
value
)
{
_gestureRecognizers
=
const
<
Type
,
GestureRecognizerFactory
>{};
// Cancel the active hold/drag (if any) because the gesture recognizers
// will soon be disposed by our RawGestureDetector, and we won't be
...
...
@@ -592,7 +592,7 @@ class ScrollableState extends State<Scrollable> with TickerProviderStateMixin, R
break
;
}
}
_lastCanDrag
=
canDrag
;
_lastCanDrag
=
value
;
_lastAxisDirection
=
widget
.
axis
;
if
(
_gestureDetectorKey
.
currentState
!=
null
)
_gestureDetectorKey
.
currentState
!.
replaceGestureRecognizers
(
_gestureRecognizers
);
...
...
packages/flutter/lib/src/widgets/scrollbar.dart
View file @
ac88d4ba
...
...
@@ -686,21 +686,21 @@ class ScrollbarPainter extends ChangeNotifier implements CustomPainter {
}
@override
bool
shouldRepaint
(
ScrollbarPainter
old
)
{
bool
shouldRepaint
(
ScrollbarPainter
old
Delegate
)
{
// Should repaint if any properties changed.
return
color
!=
old
.
color
||
trackColor
!=
old
.
trackColor
||
trackBorderColor
!=
old
.
trackBorderColor
||
textDirection
!=
old
.
textDirection
||
thickness
!=
old
.
thickness
||
fadeoutOpacityAnimation
!=
old
.
fadeoutOpacityAnimation
||
mainAxisMargin
!=
old
.
mainAxisMargin
||
crossAxisMargin
!=
old
.
crossAxisMargin
||
radius
!=
old
.
radius
||
minLength
!=
old
.
minLength
||
padding
!=
old
.
padding
||
minOverscrollLength
!=
old
.
minOverscrollLength
||
scrollbarOrientation
!=
old
.
scrollbarOrientation
;
return
color
!=
old
Delegate
.
color
||
trackColor
!=
old
Delegate
.
trackColor
||
trackBorderColor
!=
old
Delegate
.
trackBorderColor
||
textDirection
!=
old
Delegate
.
textDirection
||
thickness
!=
old
Delegate
.
thickness
||
fadeoutOpacityAnimation
!=
old
Delegate
.
fadeoutOpacityAnimation
||
mainAxisMargin
!=
old
Delegate
.
mainAxisMargin
||
crossAxisMargin
!=
old
Delegate
.
crossAxisMargin
||
radius
!=
old
Delegate
.
radius
||
minLength
!=
old
Delegate
.
minLength
||
padding
!=
old
Delegate
.
padding
||
minOverscrollLength
!=
old
Delegate
.
minOverscrollLength
||
scrollbarOrientation
!=
old
Delegate
.
scrollbarOrientation
;
}
@override
...
...
packages/flutter/lib/src/widgets/widget_inspector.dart
View file @
ac88d4ba
...
...
@@ -3247,14 +3247,14 @@ class InspectorSerializationDelegate implements DiagnosticsSerializationDelegate
}
@override
List
<
DiagnosticsNode
>
filterChildren
(
List
<
DiagnosticsNode
>
children
,
DiagnosticsNode
owner
)
{
return
service
.
_filterChildren
(
children
,
this
);
List
<
DiagnosticsNode
>
filterChildren
(
List
<
DiagnosticsNode
>
nodes
,
DiagnosticsNode
owner
)
{
return
service
.
_filterChildren
(
nodes
,
this
);
}
@override
List
<
DiagnosticsNode
>
filterProperties
(
List
<
DiagnosticsNode
>
properti
es
,
DiagnosticsNode
owner
)
{
List
<
DiagnosticsNode
>
filterProperties
(
List
<
DiagnosticsNode
>
nod
es
,
DiagnosticsNode
owner
)
{
final
bool
createdByLocalProject
=
_nodesCreatedByLocalProject
.
contains
(
owner
);
return
properti
es
.
where
((
DiagnosticsNode
node
)
{
return
nod
es
.
where
((
DiagnosticsNode
node
)
{
return
!
node
.
isFiltered
(
createdByLocalProject
?
DiagnosticLevel
.
fine
:
DiagnosticLevel
.
info
);
}).
toList
();
}
...
...
packages/flutter_localizations/lib/src/material_localizations.dart
View file @
ac88d4ba
...
...
@@ -246,8 +246,8 @@ abstract class GlobalMaterialLocalizations implements MaterialLocalizations {
String
get
dateRangeStartDateSemanticLabelRaw
;
@override
String
dateRangeStartDateSemanticLabel
(
String
f
ull
Date
)
{
return
dateRangeStartDateSemanticLabelRaw
.
replaceFirst
(
r'$fullDate'
,
f
ull
Date
);
String
dateRangeStartDateSemanticLabel
(
String
f
ormatted
Date
)
{
return
dateRangeStartDateSemanticLabelRaw
.
replaceFirst
(
r'$fullDate'
,
f
ormatted
Date
);
}
/// The raw version of [dateRangeEndDateSemanticLabel], with `$fullDate` verbatim
...
...
@@ -256,8 +256,8 @@ abstract class GlobalMaterialLocalizations implements MaterialLocalizations {
String
get
dateRangeEndDateSemanticLabelRaw
;
@override
String
dateRangeEndDateSemanticLabel
(
String
f
ull
Date
)
{
return
dateRangeEndDateSemanticLabelRaw
.
replaceFirst
(
r'$fullDate'
,
f
ull
Date
);
String
dateRangeEndDateSemanticLabel
(
String
f
ormatted
Date
)
{
return
dateRangeEndDateSemanticLabelRaw
.
replaceFirst
(
r'$fullDate'
,
f
ormatted
Date
);
}
/// The raw version of [aboutListTileTitle], with `$applicationName` verbatim
...
...
@@ -646,9 +646,9 @@ abstract class GlobalMaterialLocalizations implements MaterialLocalizations {
String
get
remainingTextFieldCharacterCountOther
;
@override
String
remainingTextFieldCharacterCount
(
int
remaining
Count
)
{
String
remainingTextFieldCharacterCount
(
int
remaining
)
{
return
intl
.
Intl
.
pluralLogic
(
remaining
Count
,
remaining
,
zero:
remainingTextFieldCharacterCountZero
,
one:
remainingTextFieldCharacterCountOne
,
two:
remainingTextFieldCharacterCountTwo
,
...
...
@@ -656,7 +656,7 @@ abstract class GlobalMaterialLocalizations implements MaterialLocalizations {
few:
remainingTextFieldCharacterCountFew
,
other:
remainingTextFieldCharacterCountOther
,
locale:
_localeName
,
).
replaceFirst
(
r'$remainingCount'
,
formatDecimal
(
remaining
Count
));
).
replaceFirst
(
r'$remainingCount'
,
formatDecimal
(
remaining
));
}
@override
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment