Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ac20b614
Unverified
Commit
ac20b614
authored
Apr 16, 2020
by
Jonah Williams
Committed by
GitHub
Apr 16, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] ensure EventPrinter handles a null parent (#54918)
parent
457972b7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
24 additions
and
3 deletions
+24
-3
event_printer.dart
packages/flutter_tools/lib/src/test/event_printer.dart
+3
-3
event_printer_test.dart
...r_tools/test/general.shard/tester/event_printer_test.dart
+21
-0
No files found.
packages/flutter_tools/lib/src/test/event_printer.dart
View file @
ac20b614
...
...
@@ -24,17 +24,17 @@ class EventPrinter extends TestWatcher {
@override
Future
<
void
>
handleTestCrashed
(
ProcessEvent
event
)
async
{
return
_parent
.
handleTestCrashed
(
event
);
return
_parent
?
.
handleTestCrashed
(
event
);
}
@override
Future
<
void
>
handleTestTimedOut
(
ProcessEvent
event
)
async
{
return
_parent
.
handleTestTimedOut
(
event
);
return
_parent
?
.
handleTestTimedOut
(
event
);
}
@override
Future
<
void
>
handleFinishedTest
(
ProcessEvent
event
)
async
{
return
_parent
.
handleFinishedTest
(
event
);
return
_parent
?
.
handleFinishedTest
(
event
);
}
void
_sendEvent
(
String
name
,
[
dynamic
params
])
{
...
...
packages/flutter_tools/test/general.shard/tester/event_printer_test.dart
0 → 100644
View file @
ac20b614
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'package:flutter_tools/src/test/event_printer.dart'
;
import
'package:flutter_tools/src/test/watcher.dart'
;
import
'../../src/common.dart'
;
import
'../../src/mocks.dart'
;
void
main
(
)
{
testWithoutContext
(
'EventPrinter handles a null parent'
,
()
{
final
EventPrinter
eventPrinter
=
EventPrinter
(
out:
StringBuffer
());
final
ProcessEvent
processEvent
=
ProcessEvent
(
0
,
FakeProcess
());
expect
(()
=>
eventPrinter
.
handleFinishedTest
(
processEvent
),
returnsNormally
);
expect
(()
=>
eventPrinter
.
handleStartedProcess
(
processEvent
),
returnsNormally
);
expect
(()
=>
eventPrinter
.
handleTestCrashed
(
processEvent
),
returnsNormally
);
expect
(()
=>
eventPrinter
.
handleTestTimedOut
(
processEvent
),
returnsNormally
);
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment