Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ac0c44fc
Unverified
Commit
ac0c44fc
authored
Jun 05, 2018
by
xster
Committed by
GitHub
Jun 05, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Small fidelity adjustments for Cupertino (#18104)
parent
f11c8d96
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
10 additions
and
7 deletions
+10
-7
goldens.version
bin/internal/goldens.version
+1
-1
icons.dart
packages/flutter/lib/src/cupertino/icons.dart
+3
-0
nav_bar.dart
packages/flutter/lib/src/cupertino/nav_bar.dart
+3
-3
nav_bar_test.dart
packages/flutter/test/cupertino/nav_bar_test.dart
+3
-3
No files found.
bin/internal/goldens.version
View file @
ac0c44fc
17b9d558228edad27729a0c1823430d73cb26608
760320e3fc8ccd12deb4066bd4033a98d078359f
packages/flutter/lib/src/cupertino/icons.dart
View file @
ac0c44fc
...
...
@@ -86,6 +86,9 @@ class CupertinoIcons {
/// A thicker left chevron used in iOS for the navigation bar back button.
static
const
IconData
back
=
const
IconData
(
0xf3cf
,
fontFamily:
iconFont
,
fontPackage:
iconFontPackage
,
matchTextDirection:
true
);
/// A thicker right chevron that's the reverse of [back].
static
const
IconData
forward
=
const
IconData
(
0xf3d1
,
fontFamily:
iconFont
,
fontPackage:
iconFontPackage
,
matchTextDirection:
true
);
/// Outline of a simple front-facing house.
static
const
IconData
home
=
const
IconData
(
0xf447
,
fontFamily:
iconFont
,
fontPackage:
iconFontPackage
);
...
...
packages/flutter/lib/src/cupertino/nav_bar.dart
View file @
ac0c44fc
...
...
@@ -18,7 +18,7 @@ const double _kNavBarPersistentHeight = 44.0;
/// Size increase from expanding the navigation bar into an iOS-11-style large title
/// form in a [CustomScrollView].
const
double
_kNavBarLargeTitleHeightExtension
=
5
6
.0
;
const
double
_kNavBarLargeTitleHeightExtension
=
5
2
.0
;
/// Number of logical pixels scrolled down before the title text is transferred
/// from the normal navigation bar to a big title below the navigation bar.
...
...
@@ -46,10 +46,10 @@ const Border _kDefaultNavBarBorder = const Border(
);
const
TextStyle
_kLargeTitleTextStyle
=
const
TextStyle
(
fontFamily:
'.SF
UI Text
'
,
fontFamily:
'.SF
Pro Display
'
,
fontSize:
34.0
,
fontWeight:
FontWeight
.
w700
,
letterSpacing:
-
0.26
,
letterSpacing:
0.24
,
color:
CupertinoColors
.
black
,
);
...
...
packages/flutter/test/cupertino/nav_bar_test.dart
View file @
ac0c44fc
...
...
@@ -171,7 +171,7 @@ void main() {
expect
(
tester
.
getTopRight
(
find
.
byKey
(
trailingKey
)),
const
Offset
(
800.0
-
16.0
-
40.0
,
10.0
));
// Top and left padding is applied to large title.
expect
(
tester
.
getTopLeft
(
find
.
byKey
(
titleKey
)),
const
Offset
(
16.0
+
20.0
,
5
8
.0
+
10.0
));
expect
(
tester
.
getTopLeft
(
find
.
byKey
(
titleKey
)),
const
Offset
(
16.0
+
20.0
,
5
4
.0
+
10.0
));
});
testWidgets
(
'Large title nav bar scrolls'
,
(
WidgetTester
tester
)
async
{
...
...
@@ -229,7 +229,7 @@ void main() {
]);
expect
(
tester
.
getTopLeft
(
find
.
widgetWithText
(
OverflowBox
,
'Title'
)).
dy
,
44.0
);
expect
(
tester
.
getSize
(
find
.
widgetWithText
(
OverflowBox
,
'Title'
)).
height
,
5
6
.0
);
expect
(
tester
.
getSize
(
find
.
widgetWithText
(
OverflowBox
,
'Title'
)).
height
,
5
2
.0
);
scrollController
.
jumpTo
(
600.0
);
await
tester
.
pump
();
// Once to trigger the opacity animation.
...
...
@@ -313,7 +313,7 @@ void main() {
isNull
,
);
expect
(
tester
.
getBottomLeft
(
find
.
text
(
'Title'
)).
dy
,
44.0
+
5
6
.0
-
8.0
);
// Static part + extension - padding.
expect
(
tester
.
getBottomLeft
(
find
.
text
(
'Title'
)).
dy
,
44.0
+
5
2
.0
-
8.0
);
// Static part + extension - padding.
scrollController
.
jumpTo
(
600.0
);
await
tester
.
pump
();
// Once to trigger the opacity animation.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment