Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
abb555fe
Commit
abb555fe
authored
Apr 25, 2019
by
Kate Lovett
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Modified platform specific golden file test.
parent
04ad0ffa
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
2 deletions
+3
-2
widget_inspector_test.dart
packages/flutter/test/widgets/widget_inspector_test.dart
+2
-1
client.dart
packages/flutter_goldens_client/lib/client.dart
+1
-1
No files found.
packages/flutter/test/widgets/widget_inspector_test.dart
View file @
abb555fe
...
...
@@ -1999,9 +1999,10 @@ class TestWidgetInspectorService extends Object with WidgetInspectorService {
);
// Add a margin so that the clip icon shows up in the screenshot.
// This golden image is platform dependent due to the clip icon.
final
String
platform
=
Platform
.
operatingSystem
;
await
expectLater
(
clipRectScreenshot
,
matchesSkiaGoldFile
(
'inspector.clipRect_debugPaint_margin.png'
),
matchesSkiaGoldFile
(
'inspector.clipRect_debugPaint_margin.
$platform
.
png'
),
);
// Verify we get the same image if we go through the service extension
...
...
packages/flutter_goldens_client/lib/client.dart
View file @
abb555fe
...
...
@@ -189,7 +189,7 @@ class SkiaGoldClient {
Future
<
String
>
_getCommitHash
()
async
{
// TODO(katelovett): Remove after pre-commit tests can be ingested by Skia Gold
return
'
d4e4726ac262b9f78b002b696f915f552fed3fc8
'
;
return
'
e51947241b37790a9e4e33bfdef59aaa9b930851
'
;
// if (!flutterRoot.existsSync()) {
// return null;
// } else {
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment