Skip to content

F
Front-End
Unverified Commit ab7f6e5c authored by Zachary Anderson's avatar Zachary Anderson Committed by GitHub
Browse files
Options

Pass --verbosity=error to the Dart front-end (#104020)

parent 02c4bd8f
Hide whitespace changes
Inline Side-by-side
Showing with 28 additions and 6 deletions
packages/flutter_tools/lib/src/compile.dart
View file @ ab7f6e5c
...@@ -329,6 +329,8 @@ class KernelCompiler { ...@@ -329,6 +329,8 @@ class KernelCompiler {
'package:flutter/src/dart_plugin_registrant.dart', 'package:flutter/src/dart_plugin_registrant.dart',
'-Dflutter.dart_plugin_registrant=${dartPluginRegistrant.uri}', '-Dflutter.dart_plugin_registrant=${dartPluginRegistrant.uri}',
], ],
// See: https://github.com/flutter/flutter/issues/103994
'--verbosity=error',
...?extraFrontEndOptions, ...?extraFrontEndOptions,
mainUri, mainUri,
]; ];
...@@ -795,6 +797,8 @@ class DefaultResidentCompiler implements ResidentCompiler { ...@@ -795,6 +797,8 @@ class DefaultResidentCompiler implements ResidentCompiler {
platformDill!, platformDill!,
], ],
if (unsafePackageSerialization == true) '--unsafe-package-serialization', if (unsafePackageSerialization == true) '--unsafe-package-serialization',
// See: https://github.com/flutter/flutter/issues/103994
'--verbosity=error',
...?extraFrontEndOptions, ...?extraFrontEndOptions,
]; ];
_logger.printTrace(command.join(' ')); _logger.printTrace(command.join(' '));
......
packages/flutter_tools/test/general.shard/build_system/targets/common_test.dart
View file @ ab7f6e5c
...@@ -102,6 +102,7 @@ void main() { ...@@ -102,6 +102,7 @@ void main() {
'$build/app.dill', '$build/app.dill',
'--depfile', '--depfile',
'$build/kernel_snapshot.d', '$build/kernel_snapshot.d',
'--verbosity=error',
'file:///lib/main.dart', 'file:///lib/main.dart',
], exitCode: 1), ], exitCode: 1),
]); ]);
...@@ -139,6 +140,7 @@ void main() { ...@@ -139,6 +140,7 @@ void main() {
'$build/app.dill', '$build/app.dill',
'--depfile', '--depfile',
'$build/kernel_snapshot.d', '$build/kernel_snapshot.d',
'--verbosity=error',
'file:///lib/main.dart', 'file:///lib/main.dart',
], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey $build/app.dill 0\n'), ], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey $build/app.dill 0\n'),
]); ]);
...@@ -177,6 +179,7 @@ void main() { ...@@ -177,6 +179,7 @@ void main() {
'$build/app.dill', '$build/app.dill',
'--depfile', '--depfile',
'$build/kernel_snapshot.d', '$build/kernel_snapshot.d',
'--verbosity=error',
'file:///lib/main.dart', 'file:///lib/main.dart',
], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey $build/app.dill 0\n'), ], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey $build/app.dill 0\n'),
]); ]);
...@@ -216,6 +219,7 @@ void main() { ...@@ -216,6 +219,7 @@ void main() {
'$build/app.dill', '$build/app.dill',
'--depfile', '--depfile',
'$build/kernel_snapshot.d', '$build/kernel_snapshot.d',
'--verbosity=error',
'foo', 'foo',
'bar', 'bar',
'file:///lib/main.dart', 'file:///lib/main.dart',
...@@ -255,6 +259,7 @@ void main() { ...@@ -255,6 +259,7 @@ void main() {
'$build/app.dill', '$build/app.dill',
'--depfile', '--depfile',
'$build/kernel_snapshot.d', '$build/kernel_snapshot.d',
'--verbosity=error',
'file:///lib/main.dart', 'file:///lib/main.dart',
], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey $build/app.dill 0\n'), ], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey $build/app.dill 0\n'),
]); ]);
...@@ -292,6 +297,7 @@ void main() { ...@@ -292,6 +297,7 @@ void main() {
'$build/app.dill', '$build/app.dill',
'--depfile', '--depfile',
'$build/kernel_snapshot.d', '$build/kernel_snapshot.d',
'--verbosity=error',
'file:///lib/main.dart', 'file:///lib/main.dart',
], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey $build/app.dill 0\n'), ], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey $build/app.dill 0\n'),
]); ]);
...@@ -344,6 +350,7 @@ void main() { ...@@ -344,6 +350,7 @@ void main() {
'$build/app.dill', '$build/app.dill',
'--depfile', '--depfile',
'$build/kernel_snapshot.d', '$build/kernel_snapshot.d',
'--verbosity=error',
'file:///lib/main.dart', 'file:///lib/main.dart',
], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey /build/653e11a8e6908714056a57cd6b4f602a/app.dill 0\n'), ], stdout: 'result $kBoundaryKey\n$kBoundaryKey\n$kBoundaryKey /build/653e11a8e6908714056a57cd6b4f602a/app.dill 0\n'),
]); ]);
......
packages/flutter_tools/test/general.shard/compile_batch_test.dart
View file @ ab7f6e5c
...@@ -66,6 +66,7 @@ void main() { ...@@ -66,6 +66,7 @@ void main() {
'--no-link-platform', '--no-link-platform',
'--packages', '--packages',
'.packages', '.packages',
'--verbosity=error',
'file:///path/to/main.dart', 'file:///path/to/main.dart',
], completer: completer), ], completer: completer),
]), ]),
...@@ -111,6 +112,7 @@ void main() { ...@@ -111,6 +112,7 @@ void main() {
'--no-link-platform', '--no-link-platform',
'--packages', '--packages',
'.packages', '.packages',
'--verbosity=error',
'file:///path/to/main.dart', 'file:///path/to/main.dart',
], completer: completer), ], completer: completer),
]), ]),
...@@ -156,6 +158,7 @@ void main() { ...@@ -156,6 +158,7 @@ void main() {
'--no-link-platform', '--no-link-platform',
'--packages', '--packages',
'.packages', '.packages',
'--verbosity=error',
'file:///path/to/main.dart', 'file:///path/to/main.dart',
], completer: completer, exitCode: 127), ], completer: completer, exitCode: 127),
]), ]),
...@@ -203,6 +206,7 @@ void main() { ...@@ -203,6 +206,7 @@ void main() {
'--tfa', '--tfa',
'--packages', '--packages',
'.packages', '.packages',
'--verbosity=error',
'file:///path/to/main.dart', 'file:///path/to/main.dart',
], completer: completer), ], completer: completer),
]), ]),
...@@ -251,6 +255,7 @@ void main() { ...@@ -251,6 +255,7 @@ void main() {
'--tfa', '--tfa',
'--packages', '--packages',
'.packages', '.packages',
'--verbosity=error',
'file:///path/to/main.dart', 'file:///path/to/main.dart',
], completer: completer), ], completer: completer),
]), ]),
...@@ -299,6 +304,7 @@ void main() { ...@@ -299,6 +304,7 @@ void main() {
'--no-link-platform', '--no-link-platform',
'--packages', '--packages',
'.packages', '.packages',
'--verbosity=error',
'file:///path/to/main.dart', 'file:///path/to/main.dart',
], completer: completer), ], completer: completer),
]), ]),
...@@ -348,6 +354,7 @@ void main() { ...@@ -348,6 +354,7 @@ void main() {
'--no-link-platform', '--no-link-platform',
'--packages', '--packages',
'.packages', '.packages',
'--verbosity=error',
'scheme:///main.dart', 'scheme:///main.dart',
], completer: completer), ], completer: completer),
]), ]),
...@@ -402,6 +409,7 @@ void main() { ...@@ -402,6 +409,7 @@ void main() {
'--source', '--source',
'package:flutter/src/dart_plugin_registrant.dart', 'package:flutter/src/dart_plugin_registrant.dart',
'-Dflutter.dart_plugin_registrant=.dart_tools/flutter_build/dart_plugin_registrant.dart', '-Dflutter.dart_plugin_registrant=.dart_tools/flutter_build/dart_plugin_registrant.dart',
'--verbosity=error',
'scheme:///main.dart', 'scheme:///main.dart',
], completer: completer), ], completer: completer),
]), ]),
......
packages/flutter_tools/test/general.shard/compile_incremental_test.dart
View file @ ab7f6e5c
...@@ -80,7 +80,7 @@ void main() { ...@@ -80,7 +80,7 @@ void main() {
testWithoutContext('incremental compile single dart compile', () async { testWithoutContext('incremental compile single dart compile', () async {
fakeProcessManager.addCommand(FakeCommand( fakeProcessManager.addCommand(FakeCommand(
command: frontendServerCommand, command: const <String>[...frontendServerCommand, '--verbosity=error'],
stdout: 'result abc\nline1\nline2\nabc\nabc /path/to/main.dart.dill 0', stdout: 'result abc\nline1\nline2\nabc\nabc /path/to/main.dart.dill 0',
stdin: frontendServerStdIn, stdin: frontendServerStdIn,
)); ));
...@@ -107,6 +107,7 @@ void main() { ...@@ -107,6 +107,7 @@ void main() {
'/foo/bar/fizz', '/foo/bar/fizz',
'--filesystem-scheme', '--filesystem-scheme',
'scheme', 'scheme',
'--verbosity=error',
], ],
stdout: 'result abc\nline1\nline2\nabc\nabc /path/to/main.dart.dill 0', stdout: 'result abc\nline1\nline2\nabc\nabc /path/to/main.dart.dill 0',
stdin: frontendServerStdIn, stdin: frontendServerStdIn,
...@@ -128,7 +129,7 @@ void main() { ...@@ -128,7 +129,7 @@ void main() {
testWithoutContext('incremental compile single dart compile abnormally terminates', () async { testWithoutContext('incremental compile single dart compile abnormally terminates', () async {
fakeProcessManager.addCommand(FakeCommand( fakeProcessManager.addCommand(FakeCommand(
command: frontendServerCommand, command: const <String>[...frontendServerCommand, '--verbosity=error'],
stdin: frontendServerStdIn, stdin: frontendServerStdIn,
)); ));
...@@ -144,7 +145,7 @@ void main() { ...@@ -144,7 +145,7 @@ void main() {
testWithoutContext('incremental compile single dart compile abnormally terminates via exitCode', () async { testWithoutContext('incremental compile single dart compile abnormally terminates via exitCode', () async {
fakeProcessManager.addCommand(FakeCommand( fakeProcessManager.addCommand(FakeCommand(
command: frontendServerCommand, command: const <String>[...frontendServerCommand, '--verbosity=error'],
stdin: frontendServerStdIn, stdin: frontendServerStdIn,
exitCode: 1, exitCode: 1,
)); ));
...@@ -162,7 +163,7 @@ void main() { ...@@ -162,7 +163,7 @@ void main() {
testWithoutContext('incremental compile and recompile', () async { testWithoutContext('incremental compile and recompile', () async {
final Completer<void> completer = Completer<void>(); final Completer<void> completer = Completer<void>();
fakeProcessManager.addCommand(FakeCommand( fakeProcessManager.addCommand(FakeCommand(
command: frontendServerCommand, command: const <String>[...frontendServerCommand, '--verbosity=error'],
stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0', stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0',
stdin: frontendServerStdIn, stdin: frontendServerStdIn,
completer: completer, completer: completer,
...@@ -211,6 +212,7 @@ void main() { ...@@ -211,6 +212,7 @@ void main() {
'/foo/bar/fizz', '/foo/bar/fizz',
'--filesystem-scheme', '--filesystem-scheme',
'scheme', 'scheme',
'--verbosity=error',
], ],
stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0', stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0',
stdin: frontendServerStdIn, stdin: frontendServerStdIn,
...@@ -274,6 +276,7 @@ void main() { ...@@ -274,6 +276,7 @@ void main() {
'/foo/bar/fizz', '/foo/bar/fizz',
'--filesystem-scheme', '--filesystem-scheme',
'scheme', 'scheme',
'--verbosity=error',
], ],
stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0', stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0',
stdin: frontendServerStdIn, stdin: frontendServerStdIn,
...@@ -324,7 +327,7 @@ void main() { ...@@ -324,7 +327,7 @@ void main() {
testWithoutContext('incremental compile can suppress errors', () async { testWithoutContext('incremental compile can suppress errors', () async {
final Completer<void> completer = Completer<void>(); final Completer<void> completer = Completer<void>();
fakeProcessManager.addCommand(FakeCommand( fakeProcessManager.addCommand(FakeCommand(
command: frontendServerCommand, command: const <String>[...frontendServerCommand, '--verbosity=error'],
stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0', stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0',
stdin: frontendServerStdIn, stdin: frontendServerStdIn,
completer: completer, completer: completer,
...@@ -363,7 +366,7 @@ void main() { ...@@ -363,7 +366,7 @@ void main() {
testWithoutContext('incremental compile and recompile twice', () async { testWithoutContext('incremental compile and recompile twice', () async {
final Completer<void> completer = Completer<void>(); final Completer<void> completer = Completer<void>();
fakeProcessManager.addCommand(FakeCommand( fakeProcessManager.addCommand(FakeCommand(
command: frontendServerCommand, command: const <String>[...frontendServerCommand, '--verbosity=error'],
stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0', stdout: 'result abc\nline0\nline1\nabc\nabc /path/to/main.dart.dill 0',
stdin: frontendServerStdIn, stdin: frontendServerStdIn,
completer: completer, completer: completer,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab