Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
a9643aea
Commit
a9643aea
authored
Aug 19, 2015
by
Hixie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
The ScrollDirection argument needs a default all the way through.
Fixes the Stocks crash on startup.
parent
7f4aa210
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
4 deletions
+8
-4
scrollable.dart
packages/flutter/lib/widgets/scrollable.dart
+8
-4
No files found.
packages/flutter/lib/widgets/scrollable.dart
View file @
a9643aea
...
...
@@ -39,7 +39,7 @@ abstract class Scrollable extends StatefulComponent {
this
.
scrollDirection
:
ScrollDirection
.
vertical
})
:
super
(
key:
key
)
{
assert
(
scrollDirection
==
ScrollDirection
.
vertical
||
scrollDirection
==
ScrollDirection
.
horizontal
);
scrollDirection
==
ScrollDirection
.
horizontal
);
}
ScrollDirection
scrollDirection
;
...
...
@@ -347,8 +347,12 @@ class ScrollableBlock extends Component {
// about offscreen widgets consuming resources.
abstract
class
FixedHeightScrollable
extends
Scrollable
{
FixedHeightScrollable
({
Key
key
,
ScrollDirection
scrollDirection
,
this
.
itemExtent
,
this
.
padding
})
:
super
(
key:
key
,
scrollDirection:
scrollDirection
)
{
FixedHeightScrollable
({
Key
key
,
ScrollDirection
scrollDirection:
ScrollDirection
.
vertical
,
this
.
itemExtent
,
this
.
padding
})
:
super
(
key:
key
,
scrollDirection:
scrollDirection
)
{
assert
(
itemExtent
!=
null
);
}
...
...
@@ -468,7 +472,7 @@ typedef Widget ItemBuilder<T>(T item);
class
ScrollableList
<
T
>
extends
FixedHeightScrollable
{
ScrollableList
({
Key
key
,
ScrollDirection
scrollDirection
,
ScrollDirection
scrollDirection
:
ScrollDirection
.
vertical
,
this
.
items
,
this
.
itemBuilder
,
double
itemExtent
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment