Unverified Commit a6d8ca29 authored by Greg Spencer's avatar Greg Spencer Committed by GitHub

Post submit review changes for chip (#15835)

parent e9168394
...@@ -53,7 +53,7 @@ const double _kEdgePadding = 4.0; ...@@ -53,7 +53,7 @@ const double _kEdgePadding = 4.0;
/// * [CircleAvatar], which shows images or initials of people. /// * [CircleAvatar], which shows images or initials of people.
/// * <https://material.google.com/components/chips.html> /// * <https://material.google.com/components/chips.html>
class Chip extends StatelessWidget { class Chip extends StatelessWidget {
/// Creates a material design chip /// Creates a material design chip.
/// ///
/// The [label] and [border] arguments may not be null. /// The [label] and [border] arguments may not be null.
const Chip({ const Chip({
...@@ -714,6 +714,14 @@ class _RenderChip extends RenderBox { ...@@ -714,6 +714,14 @@ class _RenderChip extends RenderBox {
} }
} }
doPaint(container);
doPaint(avatar);
doPaint(deleteIcon);
doPaint(label);
}
@override
void debugPaint(PaintingContext context, Offset offset) {
assert(!_debugShowTapTargetOutlines || assert(!_debugShowTapTargetOutlines ||
() { () {
// Draws a rect around the tap targets to help with visualizing where // Draws a rect around the tap targets to help with visualizing where
...@@ -731,11 +739,6 @@ class _RenderChip extends RenderBox { ...@@ -731,11 +739,6 @@ class _RenderChip extends RenderBox {
); );
return true; return true;
}()); }());
doPaint(container);
doPaint(avatar);
doPaint(deleteIcon);
doPaint(label);
} }
@override @override
......
...@@ -170,9 +170,9 @@ class _TooltipState extends State<Tooltip> with SingleTickerProviderStateMixin { ...@@ -170,9 +170,9 @@ class _TooltipState extends State<Tooltip> with SingleTickerProviderStateMixin {
@override @override
void deactivate() { void deactivate() {
super.deactivate();
if (_entry != null) if (_entry != null)
_controller.reverse(); _controller.reverse();
super.deactivate();
} }
@override @override
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment