Unverified Commit a6b9c404 authored by Dan Field's avatar Dan Field Committed by GitHub

Remove dead code from attach.dart (#83187)

* Remove dead code from attach.dart

Remove dead code (see https://github.com/flutter/flutter/pull/30857/files#diff-70164e71957eed4bf8b4119543e779e808e3ddfedeceef98d4a24ab23efc99ecR214)
parent cdf6d62f
...@@ -225,19 +225,6 @@ known, it can be explicitly provided to attach via the command-line, e.g. ...@@ -225,19 +225,6 @@ known, it can be explicitly provided to attach via the command-line, e.g.
Future<void> _attachToDevice(Device device) async { Future<void> _attachToDevice(Device device) async {
final FlutterProject flutterProject = FlutterProject.current(); final FlutterProject flutterProject = FlutterProject.current();
Future<int> getDevicePort() async {
if (debugPort != null) {
return debugPort;
}
// This call takes a non-trivial amount of time, and only iOS devices and
// simulators support it.
// If/when we do this on Android or other platforms, we can update it here.
if (device is IOSDevice || device is IOSSimulator) {
}
return null;
}
final int devicePort = await getDevicePort();
final Daemon daemon = boolArg('machine') final Daemon daemon = boolArg('machine')
? Daemon( ? Daemon(
stdinCommandStream, stdinCommandStream,
...@@ -255,7 +242,7 @@ known, it can be explicitly provided to attach via the command-line, e.g. ...@@ -255,7 +242,7 @@ known, it can be explicitly provided to attach via the command-line, e.g.
final String ipv4Loopback = InternetAddress.loopbackIPv4.address; final String ipv4Loopback = InternetAddress.loopbackIPv4.address;
final String hostname = usesIpv6 ? ipv6Loopback : ipv4Loopback; final String hostname = usesIpv6 ? ipv6Loopback : ipv4Loopback;
if (devicePort == null && debugUri == null) { if (debugPort == null && debugUri == null) {
if (device is FuchsiaDevice) { if (device is FuchsiaDevice) {
final String module = stringArg('module'); final String module = stringArg('module');
if (module == null) { if (module == null) {
...@@ -310,7 +297,7 @@ known, it can be explicitly provided to attach via the command-line, e.g. ...@@ -310,7 +297,7 @@ known, it can be explicitly provided to attach via the command-line, e.g.
buildObservatoryUri( buildObservatoryUri(
device, device,
debugUri?.host ?? hostname, debugUri?.host ?? hostname,
devicePort ?? debugUri.port, debugPort ?? debugUri.port,
hostVmservicePort, hostVmservicePort,
debugUri?.path, debugUri?.path,
) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment