Unverified Commit a664f08a authored by Zachary Anderson's avatar Zachary Anderson Committed by GitHub

In test of --(no-)fatal-infos analyzer flags, pin missing_return to info (#120797)

* In test of --(no-)fatal-infos analyzer flags, pin missing_return to info

* Remove trailing spaces
parent a513d4e7
...@@ -295,6 +295,13 @@ StringBuffer bar = StringBuffer('baz'); ...@@ -295,6 +295,13 @@ StringBuffer bar = StringBuffer('baz');
int analyze() {} int analyze() {}
'''; ''';
final File optionsFile = fileSystem.file(fileSystem.path.join(projectPath, 'analysis_options.yaml'));
optionsFile.writeAsStringSync('''
analyzer:
errors:
missing_return: info
''');
fileSystem.directory(projectPath).childFile('main.dart').writeAsStringSync(infoSourceCode); fileSystem.directory(projectPath).childFile('main.dart').writeAsStringSync(infoSourceCode);
await runCommand( await runCommand(
arguments: <String>['analyze', '--no-pub'], arguments: <String>['analyze', '--no-pub'],
...@@ -305,13 +312,20 @@ int analyze() {} ...@@ -305,13 +312,20 @@ int analyze() {}
exitMessageContains: '1 issue found.', exitMessageContains: '1 issue found.',
exitCode: 1, exitCode: 1,
); );
}, skip: true); // https://github.com/flutter/flutter/issues/120750 });
testWithoutContext('analyze once with no-fatal-infos has info issue finally exit code 0.', () async { testWithoutContext('analyze once with no-fatal-infos has info issue finally exit code 0.', () async {
const String infoSourceCode = ''' const String infoSourceCode = '''
int analyze() {} int analyze() {}
'''; ''';
final File optionsFile = fileSystem.file(fileSystem.path.join(projectPath, 'analysis_options.yaml'));
optionsFile.writeAsStringSync('''
analyzer:
errors:
missing_return: info
''');
fileSystem.directory(projectPath).childFile('main.dart').writeAsStringSync(infoSourceCode); fileSystem.directory(projectPath).childFile('main.dart').writeAsStringSync(infoSourceCode);
await runCommand( await runCommand(
arguments: <String>['analyze', '--no-pub', '--no-fatal-infos'], arguments: <String>['analyze', '--no-pub', '--no-fatal-infos'],
...@@ -321,13 +335,20 @@ int analyze() {} ...@@ -321,13 +335,20 @@ int analyze() {}
], ],
exitMessageContains: '1 issue found.', exitMessageContains: '1 issue found.',
); );
}, skip: true); // https://github.com/flutter/flutter/issues/120750 });
testWithoutContext('analyze once only fatal-warnings has info issue finally exit code 0.', () async { testWithoutContext('analyze once only fatal-warnings has info issue finally exit code 0.', () async {
const String infoSourceCode = ''' const String infoSourceCode = '''
int analyze() {} int analyze() {}
'''; ''';
final File optionsFile = fileSystem.file(fileSystem.path.join(projectPath, 'analysis_options.yaml'));
optionsFile.writeAsStringSync('''
analyzer:
errors:
missing_return: info
''');
fileSystem.directory(projectPath).childFile('main.dart').writeAsStringSync(infoSourceCode); fileSystem.directory(projectPath).childFile('main.dart').writeAsStringSync(infoSourceCode);
await runCommand( await runCommand(
arguments: <String>['analyze', '--no-pub', '--fatal-warnings', '--no-fatal-infos'], arguments: <String>['analyze', '--no-pub', '--fatal-warnings', '--no-fatal-infos'],
...@@ -337,7 +358,7 @@ int analyze() {} ...@@ -337,7 +358,7 @@ int analyze() {}
], ],
exitMessageContains: '1 issue found.', exitMessageContains: '1 issue found.',
); );
}, skip: true); // https://github.com/flutter/flutter/issues/120750 });
testWithoutContext('analyze once only fatal-infos has warning issue finally exit code 0.', () async { testWithoutContext('analyze once only fatal-infos has warning issue finally exit code 0.', () async {
const String warningSourceCode = ''' const String warningSourceCode = '''
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment