Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
a38311e6
Commit
a38311e6
authored
Apr 25, 2019
by
Kate Lovett
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixing duplicate test names.
parent
ba011fd3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
shadow_test.dart
packages/flutter/test/widgets/shadow_test.dart
+2
-2
client.dart
packages/flutter_goldens_client/lib/client.dart
+1
-1
No files found.
packages/flutter/test/widgets/shadow_test.dart
View file @
a38311e6
...
...
@@ -89,7 +89,7 @@ void main() {
);
await
expectLater
(
find
.
byType
(
Container
),
matchesSkiaGoldFile
(
'shadow.PhysicalModel.disabled.png'
),
matchesSkiaGoldFile
(
'shadow.PhysicalModel.disabled.
0.
png'
),
// matchesGoldenFile('shadow.PhysicalModel.disabled.png'),
);
debugDisableShadows
=
false
;
...
...
@@ -129,7 +129,7 @@ void main() {
await
tester
.
pumpWidget
(
build
(
elevation
.
toDouble
()));
await
expectLater
(
find
.
byType
(
Container
),
matchesSkiaGoldFile
(
'shadow.PhysicalModel.disabled.png'
),
matchesSkiaGoldFile
(
'shadow.PhysicalModel.disabled.
1.
png'
),
// matchesGoldenFile('shadow.PhysicalModel.disabled.png'),
);
}
...
...
packages/flutter_goldens_client/lib/client.dart
View file @
a38311e6
...
...
@@ -148,7 +148,7 @@ class SkiaGoldClient {
Future
<
String
>
_getCommitHash
()
async
{
// TODO: Remove after baseline is established and pre-commit works
return
'
b27b3d744670bb9312824ec94353b93e7d0424ea
'
;
return
'
96f15c74adebb221eb044d3fc71b2d62da0046c0
'
;
// if (!flutterRoot.existsSync()) {
// return null;
// } else {
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment