Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
a3362a9f
Unverified
Commit
a3362a9f
authored
Sep 02, 2023
by
Polina Cherkasova
Committed by
GitHub
Sep 02, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
MaterialStatesController should dispatch creation in constructor. (#133826)
This PR also updates other tests to use matcher.
parent
80f737d1
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
20 additions
and
75 deletions
+20
-75
material_states_controller_test.dart
...lutter/test/material/material_states_controller_test.dart
+5
-0
focus_manager_test.dart
packages/flutter/test/widgets/focus_manager_test.dart
+3
-29
router_test.dart
packages/flutter/test/widgets/router_test.dart
+7
-11
scroll_controller_test.dart
packages/flutter/test/widgets/scroll_controller_test.dart
+2
-15
shortcuts_test.dart
packages/flutter/test/widgets/shortcuts_test.dart
+3
-20
No files found.
packages/flutter/test/material/material_states_controller_test.dart
View file @
a3362a9f
...
@@ -4,6 +4,7 @@
...
@@ -4,6 +4,7 @@
import
'package:flutter/material.dart'
;
import
'package:flutter/material.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'
;
void
main
(
)
{
void
main
(
)
{
test
(
'MaterialStatesController constructor'
,
()
{
test
(
'MaterialStatesController constructor'
,
()
{
...
@@ -12,6 +13,10 @@ void main() {
...
@@ -12,6 +13,10 @@ void main() {
expect
(
MaterialStatesController
(<
MaterialState
>{
MaterialState
.
selected
}).
value
,
<
MaterialState
>{
MaterialState
.
selected
});
expect
(
MaterialStatesController
(<
MaterialState
>{
MaterialState
.
selected
}).
value
,
<
MaterialState
>{
MaterialState
.
selected
});
});
});
test
(
'MaterialStatesController dispatches memory events'
,
()
{
expect
(()=>
MaterialStatesController
().
dispose
(),
dispatchesMemoryEvents
(
MaterialStatesController
));
});
test
(
'MaterialStatesController update, listener'
,
()
{
test
(
'MaterialStatesController update, listener'
,
()
{
int
count
=
0
;
int
count
=
0
;
void
valueChanged
()
{
void
valueChanged
()
{
...
...
packages/flutter/test/widgets/focus_manager_test.dart
View file @
a3362a9f
...
@@ -11,6 +11,7 @@ import 'package:flutter/rendering.dart';
...
@@ -11,6 +11,7 @@ import 'package:flutter/rendering.dart';
import
'package:flutter/services.dart'
;
import
'package:flutter/services.dart'
;
import
'package:flutter/widgets.dart'
;
import
'package:flutter/widgets.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'
;
void
main
(
)
{
void
main
(
)
{
final
GlobalKey
widgetKey
=
GlobalKey
();
final
GlobalKey
widgetKey
=
GlobalKey
();
...
@@ -1610,38 +1611,11 @@ void main() {
...
@@ -1610,38 +1611,11 @@ void main() {
});
});
test
(
'
$FocusManager
dispatches object creation in constructor'
,
()
{
test
(
'
$FocusManager
dispatches object creation in constructor'
,
()
{
final
List
<
ObjectEvent
>
events
=
<
ObjectEvent
>[];
expect
(()=>
FocusManager
().
dispose
(),
dispatchesMemoryEvents
(
FocusManager
));
void
listener
(
ObjectEvent
event
)
{
if
(
event
.
object
.
runtimeType
==
FocusManager
)
{
events
.
add
(
event
);
}
}
MemoryAllocations
.
instance
.
addListener
(
listener
);
final
FocusManager
focusManager
=
FocusManager
();
expect
(
events
,
hasLength
(
1
));
focusManager
.
dispose
();
MemoryAllocations
.
instance
.
removeListener
(
listener
);
});
});
test
(
'
$FocusNode
dispatches object creation in constructor'
,
()
{
test
(
'
$FocusNode
dispatches object creation in constructor'
,
()
{
final
List
<
ObjectEvent
>
events
=
<
ObjectEvent
>[];
expect
(()=>
FocusNode
().
dispose
(),
dispatchesMemoryEvents
(
FocusNode
));
void
listener
(
ObjectEvent
event
)
{
if
(
event
.
object
.
runtimeType
==
FocusNode
)
{
events
.
add
(
event
);
}
}
MemoryAllocations
.
instance
.
addListener
(
listener
);
final
FocusNode
focusManager
=
FocusNode
();
expect
(
events
,
hasLength
(
1
));
focusManager
.
dispose
();
MemoryAllocations
.
instance
.
removeListener
(
listener
);
});
});
testWidgets
(
'FocusManager notifies listeners when a widget loses focus because it was removed.'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'FocusManager notifies listeners when a widget loses focus because it was removed.'
,
(
WidgetTester
tester
)
async
{
...
...
packages/flutter/test/widgets/router_test.dart
View file @
a3362a9f
...
@@ -8,6 +8,7 @@ import 'package:flutter/foundation.dart';
...
@@ -8,6 +8,7 @@ import 'package:flutter/foundation.dart';
import
'package:flutter/material.dart'
;
import
'package:flutter/material.dart'
;
import
'package:flutter/services.dart'
;
import
'package:flutter/services.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'
;
void
main
(
)
{
void
main
(
)
{
testWidgets
(
'Simple router basic functionality - synchronized'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'Simple router basic functionality - synchronized'
,
(
WidgetTester
tester
)
async
{
...
@@ -1584,18 +1585,13 @@ testWidgets('ChildBackButtonDispatcher take priority recursively', (WidgetTester
...
@@ -1584,18 +1585,13 @@ testWidgets('ChildBackButtonDispatcher take priority recursively', (WidgetTester
});
});
test
(
'
$PlatformRouteInformationProvider
dispatches object creation in constructor'
,
()
{
test
(
'
$PlatformRouteInformationProvider
dispatches object creation in constructor'
,
()
{
int
eventCount
=
0
;
void
createAndDispose
()
{
void
listener
(
ObjectEvent
event
)
=>
eventCount
++;
PlatformRouteInformationProvider
(
MemoryAllocations
.
instance
.
addListener
(
listener
);
initialRouteInformation:
RouteInformation
(
uri:
Uri
.
parse
(
'http://google.com'
)),
).
dispose
();
final
PlatformRouteInformationProvider
registry
=
PlatformRouteInformationProvider
(
}
initialRouteInformation:
RouteInformation
(
uri:
Uri
.
parse
(
'http://google.com'
)),
);
expect
(
eventCount
,
1
);
registry
.
dispose
();
expect
(
createAndDispose
,
dispatchesMemoryEvents
(
PlatformRouteInformationProvider
));
MemoryAllocations
.
instance
.
removeListener
(
listener
);
});
});
}
}
...
...
packages/flutter/test/widgets/scroll_controller_test.dart
View file @
a3362a9f
...
@@ -4,9 +4,9 @@
...
@@ -4,9 +4,9 @@
import
'dart:ui'
as
ui
;
import
'dart:ui'
as
ui
;
import
'package:flutter/foundation.dart'
;
import
'package:flutter/widgets.dart'
;
import
'package:flutter/widgets.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'
;
import
'states.dart'
;
import
'states.dart'
;
...
@@ -396,19 +396,6 @@ void main() {
...
@@ -396,19 +396,6 @@ void main() {
});
});
test
(
'
$ScrollController
dispatches object creation in constructor'
,
()
{
test
(
'
$ScrollController
dispatches object creation in constructor'
,
()
{
final
List
<
ObjectEvent
>
events
=
<
ObjectEvent
>[];
expect
(()=>
ScrollController
().
dispose
(),
dispatchesMemoryEvents
(
ScrollController
));
void
listener
(
ObjectEvent
event
)
{
if
(
event
.
object
.
runtimeType
==
ScrollController
)
{
events
.
add
(
event
);
}
}
MemoryAllocations
.
instance
.
addListener
(
listener
);
final
ScrollController
controller
=
ScrollController
();
expect
(
events
,
hasLength
(
1
));
controller
.
dispose
();
MemoryAllocations
.
instance
.
removeListener
(
listener
);
});
});
}
}
packages/flutter/test/widgets/shortcuts_test.dart
View file @
a3362a9f
...
@@ -6,6 +6,7 @@ import 'package:flutter/foundation.dart';
...
@@ -6,6 +6,7 @@ import 'package:flutter/foundation.dart';
import
'package:flutter/material.dart'
;
import
'package:flutter/material.dart'
;
import
'package:flutter/services.dart'
;
import
'package:flutter/services.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'
;
void
main
(
)
{
void
main
(
)
{
group
(
LogicalKeySet
,
()
{
group
(
LogicalKeySet
,
()
{
...
@@ -667,16 +668,7 @@ void main() {
...
@@ -667,16 +668,7 @@ void main() {
});
});
test
(
'
$ShortcutManager
dispatches object creation in constructor'
,
()
{
test
(
'
$ShortcutManager
dispatches object creation in constructor'
,
()
{
int
eventCount
=
0
;
expect
(()=>
ShortcutManager
().
dispose
(),
dispatchesMemoryEvents
(
ShortcutManager
));
void
listener
(
ObjectEvent
event
)
=>
eventCount
++;
MemoryAllocations
.
instance
.
addListener
(
listener
);
final
ShortcutManager
registry
=
ShortcutManager
();
expect
(
eventCount
,
1
);
registry
.
dispose
();
MemoryAllocations
.
instance
.
removeListener
(
listener
);
});
});
testWidgets
(
"Shortcuts passes to the next Shortcuts widget if it doesn't map the key"
,
(
WidgetTester
tester
)
async
{
testWidgets
(
"Shortcuts passes to the next Shortcuts widget if it doesn't map the key"
,
(
WidgetTester
tester
)
async
{
...
@@ -1867,16 +1859,7 @@ void main() {
...
@@ -1867,16 +1859,7 @@ void main() {
});
});
test
(
'dispatches object creation in constructor'
,
()
{
test
(
'dispatches object creation in constructor'
,
()
{
int
eventCount
=
0
;
expect
(()=>
ShortcutRegistry
().
dispose
(),
dispatchesMemoryEvents
(
ShortcutRegistry
));
void
listener
(
ObjectEvent
event
)
=>
eventCount
++;
MemoryAllocations
.
instance
.
addListener
(
listener
);
final
ShortcutRegistry
registry
=
ShortcutRegistry
();
expect
(
eventCount
,
1
);
registry
.
dispose
();
MemoryAllocations
.
instance
.
removeListener
(
listener
);
});
});
});
});
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment