Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
a1f03977
Commit
a1f03977
authored
Sep 12, 2017
by
Mikkel Nygaard Ravn
Committed by
GitHub
Sep 12, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Engine artifacts used for snapshots also specified as build inputs (#12014)
parent
f2ab841a
Changes
3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
138 additions
and
139 deletions
+138
-139
flutter.gradle
packages/flutter_tools/gradle/flutter.gradle
+3
-0
build.dart
packages/flutter_tools/lib/src/base/build.dart
+5
-3
build_test.dart
packages/flutter_tools/test/base/build_test.dart
+130
-136
No files found.
packages/flutter_tools/gradle/flutter.gradle
View file @
a1f03977
...
...
@@ -406,6 +406,9 @@ class FlutterTask extends BaseFlutterTask {
if
(
snapshotter
!=
null
)
{
sources
=
sources
.
plus
(
snapshotter
)
}
if
(
localEngineSrcPath
!=
null
)
{
sources
=
sources
.
plus
(
project
.
files
(
"$localEngineSrcPath/$localEngine"
))
}
// Finally, add a dependency on pubspec.yaml as well.
return
sources
.
plus
(
project
.
files
(
'pubspec.yaml'
))
}
...
...
packages/flutter_tools/lib/src/base/build.dart
View file @
a1f03977
...
...
@@ -51,7 +51,6 @@ class GenSnapshot {
'--dependencies=
$depfilePath
'
,
'--print_snapshot_sizes'
,
]..
addAll
(
additionalArgs
);
final
String
snapshotterPath
=
artifacts
.
getArtifactPath
(
Artifact
.
genSnapshot
,
snapshotType
.
platform
,
snapshotType
.
mode
);
return
runCommandAndStreamOutput
(<
String
>[
snapshotterPath
]..
addAll
(
args
));
}
...
...
@@ -250,7 +249,7 @@ class Snapshotter {
await
fs
.
file
(
fingerprintPath
).
writeAsString
(
fingerprint
.
toJson
());
}
catch
(
e
,
s
)
{
// Log exception and continue, this step is a performance improvement only.
print
(
'Error during snapshot fingerprinting:
$e
\n
$s
'
);
print
Status
(
'Error during snapshot fingerprinting:
$e
\n
$s
'
);
}
}
...
...
@@ -260,6 +259,9 @@ class Snapshotter {
'targetPlatform'
:
type
.
platform
?.
toString
()
??
''
,
'entryPoint'
:
mainPath
,
};
return
new
Fingerprint
.
fromBuildInputs
(
properties
,
inputFilePaths
);
final
List
<
String
>
pathsWithSnapshotData
=
inputFilePaths
.
toList
()
..
add
(
artifacts
.
getArtifactPath
(
Artifact
.
vmSnapshotData
))
..
add
(
artifacts
.
getArtifactPath
(
Artifact
.
isolateSnapshotData
));
return
new
Fingerprint
.
fromBuildInputs
(
properties
,
pathsWithSnapshotData
);
}
}
packages/flutter_tools/test/base/build_test.dart
View file @
a1f03977
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment