Unverified Commit a12e242c authored by Manuel's avatar Manuel Committed by GitHub

Improve CupertinoContextMenu to match native more (#117698)

* Change some values

* Change where/when the haptic feedback is happening. Now it's in comparison for me identical.

* Change the type of haptic feedback. Matches correctly now.

* Don't play haptic feedback when user aborts.

* Improve looks. Now it looks exactly alike

* - Move width to variable
- Add test for contextmenu

* Change background color of ContextMenuAction

* Change the colors in the test file

* Make Haptic Feedback optional

* Squashed commit of the following:

commit ce8efb43
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Feb 13 07:29:25 2023 -0500

    ede2a0a3c Roll Skia from c6f1de2239fb to d85501fa487d (1 revision) (flutter/engine#39585) (#120593)

commit b33c76f0
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Feb 13 06:27:23 2023 -0500

    1695b7bbc Bump github/codeql-action from 2.1.39 to 2.2.4 (flutter/engine#39584) (#120588)

commit b0c24e8d
Author: xubaolin <xubaolin@oppo.com>
Date:   Mon Feb 13 18:11:28 2023 +0800

    fix a Slider theme update bug (#120432)

    * fix a Slider theme update bug

    * Code review feedback

commit 53fe8a3f
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Feb 13 02:37:24 2023 -0500

    4107a7b71 Roll Skia from 615965d545f4 to c6f1de2239fb (1 revision) (flutter/engine#39581) (#120580)

commit 3e659cf7
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Feb 13 00:01:18 2023 -0500

    1eef041d4 [Impeller] Source the pipeline color attachment pixel format from RenderPass textures (flutter/engine#39556) (#120576)

commit 238b0dbc
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sun Feb 12 23:09:24 2023 -0500

    Roll Flutter Engine from b7e80ad6ef51 to 1ff345ce5f63 (2 revisions) (#120574)

    * 5ad400e25 Roll Fuchsia Mac SDK from KpTOXssqVhPv2OBZi... to NZAnfCkpbswhYplty... (flutter/engine#39577)

    * 1ff345ce5 Roll Fuchsia Linux SDK from 8fdyKaKQqTPpjcp-L... to R6oclCbqlvHdyGgut... (flutter/engine#39578)

commit 527977b6
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sun Feb 12 08:54:35 2023 -0500

    b7e80ad6e Roll Fuchsia Mac SDK from y35kWL0rP5Nd06lTg... to KpTOXssqVhPv2OBZi... (flutter/engine#39574) (#120559)

commit 6d68eb7b
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sun Feb 12 08:08:24 2023 -0500

    0aa4fcbd2 Roll Skia from ec87ec6fd34f to 615965d545f4 (1 revision) (flutter/engine#39573) (#120558)

commit 7295d4fe
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sun Feb 12 06:22:06 2023 -0500

    9a19d7eea Roll Fuchsia Linux SDK from arbaBzyUE2ok1bGl5... to 8fdyKaKQqTPpjcp-L... (flutter/engine#39572) (#120554)

commit d6ff0f2a
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sun Feb 12 04:49:29 2023 -0500

    fe56a45b4 Roll Dart SDK from c4255cea566a to 1caf3a9ad101 (1 revision) (flutter/engine#39571) (#120552)

commit 274f6cb2
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Feb 11 22:57:09 2023 -0500

    Roll Flutter Engine from 2cba062f9f4c to 05d81c0f2ebe (2 revisions) (#120547)

    * ae44d6f64 Roll Dart SDK from b1836aacc08a to c4255cea566a (1 revision) (flutter/engine#39568)

    * 05d81c0f2 Roll Skia from ac09a28afd34 to ec87ec6fd34f (1 revision) (flutter/engine#39569)

commit f04600bf
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Feb 11 19:35:04 2023 -0500

    Roll Flutter Engine from d8e01097e66b to 2cba062f9f4c (2 revisions) (#120538)

    * 92e86a287 Roll Fuchsia Linux SDK from MVMTNxWJaWdwPWstz... to arbaBzyUE2ok1bGl5... (flutter/engine#39563)

    * 2cba062f9 Roll Fuchsia Mac SDK from FxFPRn_9rSWWAWFw0... to y35kWL0rP5Nd06lTg... (flutter/engine#39565)

commit 0db47bdd
Author: Casey Hillers <chillers@google.com>
Date:   Sat Feb 11 03:44:56 2023 -0800

    Revert "Fix BottomAppBar & BottomSheet M3 shadow (#119819)" (#120492)

    This reverts commit 0a97ef85.

commit 0346f4b1
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Feb 11 06:43:37 2023 -0500

    d8e01097e Roll Fuchsia Mac SDK from 6nMZjuYXTcnD_VZQI... to FxFPRn_9rSWWAWFw0... (flutter/engine#39562) (#120519)

commit bbf8446d
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Feb 11 04:54:59 2023 -0500

    761891200 Roll Dart SDK from 1d26a1d57edf to b1836aacc08a (1 revision) (flutter/engine#39561) (#120513)

commit d27de1de
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Feb 11 03:37:39 2023 -0500

    5efb42971 Roll Fuchsia Linux SDK from 482Njb1v72P7fNyj4... to MVMTNxWJaWdwPWstz... (flutter/engine#39559) (#120512)

commit 61e059f4
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Feb 11 01:36:39 2023 -0500

    Roll Flutter Engine from c3dc68e0e263 to 363355af5158 (2 revisions) (#120511)

    * 4c76e2de5 Roll Dart SDK from 02a5a3bedc5f to 1d26a1d57edf (2 revisions) (flutter/engine#39557)

    * 363355af5 Roll Skia from 6c3097e6f833 to ac09a28afd34 (1 revision) (flutter/engine#39558)

commit e42ab1cb
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 10 23:47:09 2023 -0500

    c3dc68e0e Roll Skia from 70a3a194ec98 to 6c3097e6f833 (1 revision) (flutter/engine#39555) (#120508)

commit 859d57b3
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 10 22:40:49 2023 -0500

    8baee2164 Roll Skia from 5230650dc096 to 70a3a194ec98 (2 revisions) (flutter/engine#39554) (#120507)

commit 4ab2ffd5
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 10 21:42:13 2023 -0500

    Roll Flutter Engine from f737dc868a3e to 3ac3338489d2 (2 revisions) (#120505)

    * b93428ef3 [Impeller] Adds wide gamut support for iOS. (flutter/engine#39111)

    * 3ac333848 Roll Skia from f0fc6aa4d797 to 5230650dc096 (4 revisions) (flutter/engine#39551)

commit b3613c4c
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 10 20:11:35 2023 -0500

    f737dc868 [macOS] Add XCode marks for TextInputPlugin (flutter/engine#39550) (#120501)

commit 941578ea
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 10 19:12:03 2023 -0500

    Roll Flutter Engine from 6660300ea34f to 5e3ff1e5c9b3 (4 revisions) (#120495)

    * 1a3a8a098 Roll Fuchsia Mac SDK from 86sd_NCGPMuQh08NX... to 6nMZjuYXTcnD_VZQI... (flutter/engine#39546)

    * 3dbfc35d3 Roll Dart SDK from 63b8dc1906e5 to 02a5a3bedc5f (8 revisions) (flutter/engine#39547)

    * 0cea03bfe Roll Skia from 640fa258fc75 to f0fc6aa4d797 (1 revision) (flutter/engine#39548)

    * 5e3ff1e5c [Impeller] Don't use unnecessary stencil attachments (flutter/engine#39537)

commit d63c54c9
Author: Flutter GitHub Bot <fluttergithubbot@gmail.com>
Date:   Fri Feb 10 18:11:53 2023 -0500

    roll packages (#120493)

commit 2f9abd20
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 10 17:22:32 2023 -0500

    Roll Flutter Engine from 4104eb5cbc40 to 6660300ea34f (6 revisions) (#120487)

    * 440e6bd6e [Impeller] Use minimal coverage for EntityPass clip restores (flutter/engine#39540)

    * 641d1d049 [web] Fixes invisible platform view compositing edge cases. (flutter/engine#39506)

    * 64414346f Revert "Remove deprecated TextInputClient scribble method code" (flutter/engine#39516)

    * e63404413 Roll Skia from 54342413f5c0 to 640fa258fc75 (3 revisions) (flutter/engine#39544)

    * 7bf8bfd02 add support to run dl_canvas_unittests on GPU surfaces (off by default) (flutter/engine#38993)

    * 6660300ea Use DisplayListMatrixClipTracker in DiffContext (flutter/engine#38010)

commit d5dbcb70
Author: Mouad Debbar <mdebbar@google.com>
Date:   Fri Feb 10 16:24:08 2023 -0500

    Revert "Revert "[web] Move JS content to its own `.js` files (#117691)" (#120275)" (#120363)

    This reverts commit 0fb4406c.

commit 65fd924d
Author: Casey Hillers <chillers@google.com>
Date:   Fri Feb 10 12:29:31 2023 -0800

    [conductor] Remove CiYaml model (#120458)

    * [conductor] Remove CiYaml model

    * Remove package:yaml

    * Update pubspec checksum

commit 52ab2993
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 10 15:09:29 2023 -0500

    Roll Flutter Engine from add9e11edb66 to 4104eb5cbc40 (14 revisions) (#120470)

    * bf38bf6cf Bump to Chrome 111. (flutter/engine#39525)

    * d76023b53 Roll Skia from 128d82c8931d to 59c9ef67fa34 (3 revisions) (flutter/engine#39529)

    * da0e1463a Roll Skia from 59c9ef67fa34 to 4013995114e1 (2 revisions) (flutter/engine#39530)

    * 5203b6ff6 Roll Skia from 4013995114e1 to 182d5daf78dc (1 revision) (flutter/engine#39531)

    * b3e9642c6 Add Animated PNG demuxer (flutter/engine#31098)

    * 54665882c [Impeller] Generate a Metal library symbols file for shader debugging. (flutter/engine#39532)

    * 931bf7a47 Roll Skia from 182d5daf78dc to 299221eaa3a9 (1 revision) (flutter/engine#39533)

    * 3ad331a1a Roll Fuchsia Mac SDK from s0lx1q5xbqV1jkRZM... to 86sd_NCGPMuQh08NX... (flutter/engine#39534)

    * 616485bf9 Roll Skia from 299221eaa3a9 to 261f573f16db (1 revision) (flutter/engine#39535)

    * e1e5289b6 Roll Skia from 261f573f16db to badcdf5635ab (1 revision) (flutter/engine#39538)

    * f98e4f138 Ignore invalid filters when constructing an image compose filter (flutter/engine#39528)

    * 14c8e6bde Roll Fuchsia Linux SDK from ibtVZPawJl1jwt5Sg... to 482Njb1v72P7fNyj4... (flutter/engine#39541)

    * c9574d51a Roll Skia from badcdf5635ab to 54342413f5c0 (1 revision) (flutter/engine#39542)

    * 4104eb5cb Revert "[macOS] Make FlutterEngine support multiple views (#37976)" (flutter/engine#39536)

commit 780c9a8d
Author: Kate Lovett <katelovett@google.com>
Date:   Fri Feb 10 23:03:01 2023 +0300

    Remove deprecated SystemChrome.setEnabledSystemUIOverlays (#119576)

commit b2e37c65
Author: Casey Hillers <chillers@google.com>
Date:   Fri Feb 10 11:01:04 2023 -0800

    [conductor] Tag engine versions (#120419)

    * [conductor] Tag engine versions

    * Move tag to repository

commit 25c2c22d
Author: Pascal Welsch <pascal@welsch.dev>
Date:   Fri Feb 10 18:39:58 2023 +0100

    Delete Chrome temp cache after closing (#119062)

    * Delete Chrome temp cache after closeing

    * Update packages/flutter_tools/lib/src/web/chrome.dart
Co-authored-by: 's avatarChristopher Fujino <fujino@google.com>

    ---------
Co-authored-by: 's avatarChristopher Fujino <fujino@google.com>

commit 298c874e
Author: Michael Goderbauer <goderbauer@google.com>
Date:   Fri Feb 10 09:35:37 2023 -0800

    Fix classes that shouldn't be extended/instantiated/mixedin (#120409)

commit 858f94cf
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 10 12:33:57 2023 -0500

    Roll Plugins from 73986f4cc857 to 02571ec0dd36 (3 revisions) (#120443)

    * 2daa07275 Update .cirrus.yml (flutter/plugins#7134)

    * b3c7582da [google_sign_in] Slight cleanup in GoogleSignInPlugin (flutter/plugins#7013)

    * 02571ec0d Manual roll Flutter from 2303f422 to e3471f08 (24 revisions) (flutter/plugins#7147)

commit b0d04ea4
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 10 12:32:45 2023 -0500

    add9e11ed Fix position of BackdropFilter above PlatformView (flutter/engine#39244) (#120415)

commit f05a555b
Author: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Date:   Fri Feb 10 18:32:43 2023 +0100

    Fix lerping for `NavigationRailThemeData` icon themes (#120066)

    * Fix lerping for NavigationRail icon themes

    * fix typo

commit 5dbd2810
Author: Renzo Olivares <rmolivares@renzo-olivares.dev>
Date:   Fri Feb 10 09:31:07 2023 -0800

    Use String.codeUnitAt instead of String.codeUnits[] in ParagraphBoundary (#120234)

    * paragraph-boundary-opt

    * address comments

    * address comments

    ---------
Co-authored-by: 's avatarRenzo Olivares <roliv@google.com>

commit 96823590
Author: Xilai Zhang <xilaizhang@google.com>
Date:   Fri Feb 10 09:29:09 2023 -0800

    post submit only (#120411)

commit 001c4951
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 9 20:14:10 2023 -0500

    Roll Flutter Engine from 9a40a384997d to e1d0032029e4 (6 revisions) (#120414)

    * 081b9fc2d [Windows] Prepare keyboard & text input plugins for multi-view (flutter/engine#39464)

    * b9073d13e [macOS] Make FlutterEngine support multiple views (flutter/engine#37976)

    * 028deae48 [ios] Convert `int` in Dart to `long long` in Objective-C. (flutter/engine#39331)

    * 8f52c598b Roll Skia from e238cde8581d to 128d82c8931d (5 revisions) (flutter/engine#39524)

    * c3c7b2478 Fix classes that shouldn't be extended/instantiated/mixedin (flutter/engine#39517)

    * e1d003202 Roll Fuchsia Linux SDK from cn89DIQTewbdhBTO-... to ibtVZPawJl1jwt5Sg... (flutter/engine#39526)

commit e3471f08
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 9 18:50:11 2023 -0500

    Roll Flutter Engine from 40e17fb5244c to 9a40a384997d (3 revisions) (#120403)

    * fd110e068 Reland "[macos] Move TextInputPlugin outside of visible area" (flutter/engine#39194)

    * e50569ba5 Remove unused .ci.yaml properties (flutter/engine#39501)

    * 9a40a3849 [Impeller] Support blit passes on Vulkan. (flutter/engine#39438)

commit f945ad99
Author: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Date:   Fri Feb 10 00:05:44 2023 +0100

    Resolve dwarf paths to enable source-code mapping of stacktraces (#114767)

    * feat: add "--resolve-dwarf-paths" to gen_snapshot

    * chore: update tests

commit fecd5c96
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 9 18:03:39 2023 -0500

    Roll Flutter Engine from 39c41c40a4bc to 40e17fb5244c (3 revisions) (#120397)

    * 24bde68a4 Roll Fuchsia Mac SDK from 4cSuz7lZeOIfzhUHg... to s0lx1q5xbqV1jkRZM... (flutter/engine#39520)

    * de841f63d Enable UIA in Window (flutter/engine#39513)

    * 40e17fb52 Roll Skia from db81bd26f149 to e238cde8581d (1 revision) (flutter/engine#39522)

commit 425ab5dc
Author: Jonah Williams <jonahwilliams@google.com>
Date:   Thu Feb 9 12:58:57 2023 -0800

    Remove test that verifies we can switch to stateless (#120390)

commit 2239f6c8
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 9 15:47:09 2023 -0500

    Roll Flutter Engine from 603fd71f4749 to 39c41c40a4bc (3 revisions) (#120393)

    * 8ae722400 Only run malioc analysis for a couple of GPU types (flutter/engine#39515)

    * 326f4fcf1 Roll Skia from 1544d3a123bc to db81bd26f149 (2 revisions) (flutter/engine#39519)

    * 39c41c40a Manual roll ICU from 2cce76fd67af to 266a46937f05 (1 revision) (flutter/engine#39518)

commit 1faa9500
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 9 14:20:21 2023 -0500

    Roll Flutter Engine from eb346ba63f69 to 603fd71f4749 (2 revisions) (#120381)

    * 3483e33b3 Roll buildroot to 0180f883 (flutter/engine#39503)

    * 603fd71f4 Roll Skia from 970c33b0f43e to 1544d3a123bc (2 revisions) (flutter/engine#39514)

commit 91dc513a
Author: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
Date:   Thu Feb 9 10:41:09 2023 -0800

    Add missing parameters to `CheckboxListTile` (#120118)

    * Add missing parameters to CheckboxListTile

    * Update test message and api doc

    * Reorder parameters

    ---------
Co-authored-by: 's avatarQun Cheng <quncheng@google.com>

commit c8c86214
Author: Michael Thomsen <mit@google.com>
Date:   Thu Feb 9 19:40:32 2023 +0100

    Clean up null safety messages (#120350)

commit 3fdd6ee4
Author: chunhtai <47866232+chunhtai@users.noreply.github.com>
Date:   Thu Feb 9 10:38:47 2023 -0800

    Reland "Overlay always applies clip (#113770)" (#116674)

    * Reland "Overlay always applies clip (#113770)"

    This reverts commit d0afbd72.

    * Root navigator will not clip

commit 1546fa08
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Thu Feb 9 10:34:02 2023 -0800

    [flutter_tools] toolExit on sdkmanager exit during doctor --android-licenses (#120330)

    * tool exit on sdk manager exit and add test

    * be more specific about error message

commit 42b20cf9
Author: Hans Muller <hans.muller@gmail.com>
Date:   Thu Feb 9 10:34:01 2023 -0800

    Added ListTile.titleAlignment, ListTileThemeData.titleAlignment (#119872)

    * added ListTile.textAlignment

    * changed titlesHeight to titleHeight

    * fixed a typo

    * Add tests and example

    * Update tests

    * update example test

    ---------
Co-authored-by: 's avatartahatesser <tessertaha@gmail.com>

commit 0521c60c
Author: Daco Harkes <dacoharkes@google.com>
Date:   Thu Feb 9 19:32:52 2023 +0100

    Support --local-engine=ios_debug_sim (#119524)

    Fixes:

    * https://github.com/flutter/flutter/issues/119523

commit 5e506aeb
Author: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
Date:   Thu Feb 9 10:32:49 2023 -0800

    Add missing parameters to `SwitchListTile` (#120115)

    * Add missing parameters to SwitchListTile

    * Update SwitchListTile doc

    * Update doc for existing APIs

    * Address comment

    * Fix typo

    ---------
Co-authored-by: 's avatarQun Cheng <quncheng@google.com>

commit 99961267
Author: Eilidh Southren <esouthren@google.com>
Date:   Thu Feb 9 16:51:26 2023 +0000

    Add proper disabled values for input chips (#120192)

    * add proper disabled values for input chips

    * added test

commit cd380633
Author: Daco Harkes <dacoharkes@google.com>
Date:   Thu Feb 9 17:37:09 2023 +0100

    Update gallery.dart (#120366)

    Incorporating:

    * https://github.com/flutter/flutter/issues/120260

commit 468e21c5
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 9 11:17:08 2023 -0500

    Manual roll Flutter Engine from 2f2e2e27cb28 to eb346ba63f69 (7 revisions) (#120364)

    * 58abb04e0 increase first frame timeout (flutter/engine#39504)

    * e5d61519f Update shader_optimization.md (flutter/engine#39497)

    * b0816a4bc Roll Skia from 638bfdc9e23c to 1762c093d086 (8 revisions) (flutter/engine#39507)

    * 31ec7f29c Roll Skia from 1762c093d086 to 5899b39484db (1 revision) (flutter/engine#39508)

    * 35934fd54 Roll Fuchsia Mac SDK from vV4hr9qgSXTVhRzEr... to 4cSuz7lZeOIfzhUHg... (flutter/engine#39509)

    * 0cfdd8a22 Roll Skia from 5899b39484db to 970c33b0f43e (1 revision) (flutter/engine#39510)

    * eb346ba63 Roll Fuchsia Linux SDK from B6PQF-BmeXvmNZJy5... to cn89DIQTewbdhBTO-... (flutter/engine#39511)

commit 0e7c5a88
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 9 11:11:18 2023 -0500

    Roll Plugins from f59c08db3f27 to 73986f4cc857 (5 revisions) (#120362)

    * 84ad624e3 Manual roll Flutter from e8eac0d0 to 2303f422 (23 revisions) (flutter/plugins#7132)

    * d8812bc75 [ci] Complete architecture switch for iOS (flutter/plugins#7066)

    * 703111040 [google_maps_flutter_android] Fixes points losing precision when converting to LatLng (flutter/plugins#7101)

    * 435c46f21 [camera] availableCameras() implementation for CameraX re-write (flutter/plugins#6945)

    * 73986f4cc [image_picker_android] Name picked files to match the original filenames where possible  (flutter/plugins#6096)

commit dee226ef
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 9 01:51:04 2023 -0500

    Manual roll Flutter Engine from 89c8a1393d4b to 2f2e2e27cb28 (3 revisions) (#120333)

    * 24fcdc5d2 [Impeller] Fix sampling management problems (flutter/engine#39483)

    * 4270d7445 Revert "Revert "[ios_platform_view] MaskView pool to reuse maskViews. (#38989)" (#39490)" (flutter/engine#39498)

    * 2f2e2e27c Manual roll Dart SDK from 9c68f2a74491 to 63b8dc1906e5 (3 revisions) (flutter/engine#39502)

commit b1c4d568
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Wed Feb 8 16:55:05 2023 -0800

    Fix widget inspector null check (#120143)

    * add failing test

    * fix

    * remove extra whitespace

    * fix test failure

    * disable trackrebuilddirtywidgets in teardown

    * remove no-shuffle annotation

    * fix

commit 0fb4406c
Author: Kevin Chisholm <kevinjchisholm@google.com>
Date:   Wed Feb 8 18:17:29 2023 -0600

    Revert "[web] Move JS content to its own `.js` files (#117691)" (#120275)

    This reverts commit e03029ef.

commit ef854a3d
Author: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Date:   Wed Feb 8 15:24:42 2023 -0800

    [Tool] [Windows] Output build duration (#120311)

    * [Tool][Windows] Output build duration

    * Tweak

    * Format

commit b4908f37
Author: Drew Roen <102626803+drewroengoogle@users.noreply.github.com>
Date:   Wed Feb 8 16:29:30 2023 -0600

    Update .cirrus.yml (#120315)

commit 4ddf0a89
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Wed Feb 8 17:06:12 2023 -0500

    Manual roll Flutter Engine from cc4ca6a06ab3 to 89c8a1393d4b (6 revisions) (#120319)

    * ef9d3e9ad Roll Skia from d52b1a24c407 to 99a797d497fe (1 revision) (flutter/engine#39489)

    * 6a2de773e Revert "[ios_platform_view] MaskView pool to reuse maskViews. (#38989)" (flutter/engine#39490)

    * 62b49804f Disable mouse-input-test (flutter/engine#39492)

    * 28c3c8139 Roll Skia from 99a797d497fe to 638bfdc9e23c (4 revisions) (flutter/engine#39494)

    * 0d5653352 Roll Fuchsia Linux SDK from HGN3rmf37VA5Sc0e1... to B6PQF-BmeXvmNZJy5... (flutter/engine#39493)

    * 89c8a1393 Migrate iOS and Android to use pushRouteInformation (flutter/engine#39372)

commit 4a966088
Author: Andrew Kolos <andrewrkolos@gmail.com>
Date:   Wed Feb 8 21:41:19 2023 +0000

    Reland "Stop recursively including assets from asset directories" (#120312)

    * stop recursively including assets from asset directories

    * remove unused imports

    * lint

commit 2303f422
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Wed Feb 8 14:24:12 2023 -0500

    Manual roll Flutter Engine from bdc5b6b768f6 to cc4ca6a06ab3 (8 revisions) (#120309)

    * 6c9f0c00d [macOS] Support text input autocomplete (flutter/engine#39460)

    * 08f50504d Roll Skia from f30529658275 to 7cac214d0f4b (1 revision) (flutter/engine#39478)

    * 9aa088df0 Roll Fuchsia Linux SDK from aRqjqB76Z2gNQsrTA... to HGN3rmf37VA5Sc0e1... (flutter/engine#39480)

    * 24fd06e79 [Impeller] Fix stroke cap drawing not correct. (flutter/engine#39481)

    * c0b1b2ccf Roll Fuchsia Mac SDK from uYw6cCpJIpQa42G4O... to vV4hr9qgSXTVhRzEr... (flutter/engine#39485)

    * 586378ff1 Roll Skia from 7cac214d0f4b to 4d064e82ce8e (1 revision) (flutter/engine#39486)

    * 81f6c3393 Roll Skia from 4d064e82ce8e to d52b1a24c407 (4 revisions) (flutter/engine#39487)

    * cc4ca6a06 Manual roll Dart SDK from a507a9057730 to 9c68f2a74491 (11 revisions) (flutter/engine#39488)

commit 212bac80
Author: Hans Muller <hans.muller@gmail.com>
Date:   Wed Feb 8 10:53:55 2023 -0800

    Revert "Update `ExpansionTile` to support Material 3 & add an example (#119712)" (#120300)

    This reverts commit e8eac0d0.

commit 51227a9a
Author: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
Date:   Wed Feb 8 10:53:24 2023 -0800

    Add missing parameters to `RadioListTile` (#120117)

commit 3a514175
Author: Camille Simon <43054281+camsim99@users.noreply.github.com>
Date:   Wed Feb 8 10:51:52 2023 -0800

    Remove Android spell check integration test (#120144)

commit ec289f1e
Author: Gabriel Terwesten <gabriel@terwesten.net>
Date:   Wed Feb 8 19:51:50 2023 +0100

    Don't call `PlatformViewCreatedCallback`s after `AndroidViewController` is disposed (#116854)

    * Don't call `PlatformViewCreatedCallback`s after `AndroidViewController` is disposed

    Before this change it was possible that, if a `AndroidViewController` was disposed before we got the notification that the platform view was created, `PlatformViewCreatedCallback`s where called even after calling `AndroidViewController.dispose`.

    Also makes `_PlatformViewLinkState._onPlatformViewCreated` more carful to only call `setState` when mounted.

    Closes #84628
    Closes #96384

    * Allow all widgets to remove listeners from controller

    * Remove assert

    * Add expectations to test

commit bfea22db
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Wed Feb 8 13:05:54 2023 -0500

    Roll Plugins from 6f985d57b04b to f59c08db3f27 (3 revisions) (#120303)

    * 40c2e1169 [local_auth_android] update java complie sdk version to green tree (flutter/plugins#7121)

    * 81c6fd07a Update release tooling to give a workaround for predictable failing case https://github.com/flutter/flutter/issues/120116 (flutter/plugins#7111)

    * f59c08db3 Roll Flutter from 3c3c9a1b to e8eac0d0 (21 revisions) (flutter/plugins#7122)

commit 0a97ef85
Author: Eilidh Southren <esouthren@google.com>
Date:   Wed Feb 8 18:04:21 2023 +0000

    Fix BottomAppBar & BottomSheet M3 shadow (#119819)

    * remove m3 shadows

    * fix

    * fix that test over there

commit 0588b925
Author: MarchMore <59848602+MarchMore@users.noreply.github.com>
Date:   Wed Feb 8 19:01:11 2023 +0100

    Removed "if" on resolving text color at "SnackBarAction" (#120050)

    * Removed "if" on resolving text color at "SnackBarAction"

    Removed multiple "if" for "resolveForegroundColor" method at "SnackBarAction". At least one of the multiple "if" ("defaults.actionTextColor is MaterialStateColor") led to not applying a custom set color (e.g. MaterialColor "Colors.red") for the action text when using Material 3.

    The second "if" ("snackBarTheme.actionTextColor is MaterialStateColor") also makes no sense then as the set color of the Theme would lead to the same blocking behaviour of manual color assignment.

    The last remaining "if" ("widget.textColor is MaterialStateColor") will be unnecessary if the other "if" will be removed, as it will be resolved in the code right afterwards.

    The three "if" also seems to block the usage of the custom text color or the color at all if the widget is in the "MaterialState.disabled" state.

    * Adjusted recent modifications to SnackBarAction's text color resolution

    * Now the "widget.textColor" is checked if it is set.
      * If it is a MaterialStateColor, it will be used
      * Otherwise continue with normal resolution (It will be used in the resolution anyways because it's set)

    * Repeat same steps with "snackBarTheme.actionTextColor" if previous was not set

    * Repeat same steps with "defaults.actionTextColor" if previous was not set

    * Reverted the auto formatting changes

    * Added two test cases to "snack_bar_test"

     * Test for setting a MaterialColor to a SnackBarAction' label (M3)
     * Test for setting a MaterialStateColor to a SnackBarAction' label (M3)

    * Renamed test cases "Snackbar labels can be colored"

commit 75ca31b0
Author: Hans Muller <hans.muller@gmail.com>
Date:   Wed Feb 8 08:52:41 2023 -0800

    Correct Badge interpretation of its alignment parameter (#119853)

commit d8154fde
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Wed Feb 8 11:00:29 2023 -0500

    Manual roll Flutter Engine from f310ffd1461a to bdc5b6b768f6 (12 revisions) (#120261)

    * 0e25c0a1c [impeller] ensure full glyphs respect alpha (flutter/engine#39377)

    * 684cfe292 Add helpers for updating arm tools in CIPD (flutter/engine#39458)

    * e6cf1c532 Roll Skia from 87dbc81b421f to bd48f82dcabb (8 revisions) (flutter/engine#39459)

    * bf8547dd9 Override _accessibilityHitTest to fix IOS 16 semantics issues  (flutter/engine#38794)

    * 2e225eb6b Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (flutter/engine#39462)

    * ca05af79e [Windows] Remove accessibility root assumptions (flutter/engine#39441)

    * 3e9eb95ea Roll Skia from bd48f82dcabb to f30529658275 (7 revisions) (flutter/engine#39463)

    * 85958c2ea Update malioc analysis golden file (flutter/engine#39461)

    * 7098858dc Roll Fuchsia Mac SDK from zYEsaCaA1cokDUU43... to uYw6cCpJIpQa42G4O... (flutter/engine#39466)

    * bc8d3fca7 Revert "Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (#39462)" (flutter/engine#39470)

    * 28837b3ad Revert "Revert "Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (#39462)" (#39470)" (flutter/engine#39475)

    * bdc5b6b76 Revert "Revert "Revert "Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (#39462)" (#39470)" (#39475)" (flutter/engine#39477)

commit 7f578fb0
Author: Mouad Debbar <mdebbar@google.com>
Date:   Wed Feb 8 10:42:02 2023 -0500

    Revert "Stop recursively including assets from asset folders (#120167)" (#120283)

    This reverts commit da36bd6f.

commit 3f98c0f8
Author: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
Date:   Tue Feb 7 23:55:24 2023 -0800

    Add trackOutlineColor for Switch and SwitchListTile (#120140)

    * Add trackOutlineColor for Switch and SwitchListTile

    * Update tests

    * Update test

    * Clean up unnecessary StatefulBUilder in tests

    * Fix failed test

    ---------
Co-authored-by: 's avatarQun Cheng <quncheng@google.com>

commit 6e7f5803
Author: xubaolin <xubaolin@oppo.com>
Date:   Wed Feb 8 12:37:24 2023 +0800

    fix a TextFormField bug (#120182)

    * fix a TextFormField bug

    * review feedback

commit 1e6e6d41
Author: Zachary Anderson <zanderso@users.noreply.github.com>
Date:   Tue Feb 7 20:18:32 2023 -0800

    Revert "Roll Flutter Engine from f310ffd1461a to 7098858dc0a5 (9 revisions) (#120251)" (#120257)

    This reverts commit f94fa7ea.

commit 99b6bd8c
Author: Renzo Olivares <rmolivares@renzo-olivares.dev>
Date:   Tue Feb 7 18:55:26 2023 -0800

    Add support for extending selection to paragraph on ctrl + shift + arrow up/down on Non-Apple platforms (#120151)

    * Add support for extending selection to paragraph on ctrl + shift + arrow up/down for common keyboard actions

    * Add ctrl + shift + arrow up/down common text editing shortcuts/actions

    * fix analyzer

    ---------
Co-authored-by: 's avatarRenzo Olivares <roliv@google.com>

commit f94fa7ea
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Feb 7 21:38:11 2023 -0500

    Roll Flutter Engine from f310ffd1461a to 7098858dc0a5 (9 revisions) (#120251)

    * 0e25c0a1c [impeller] ensure full glyphs respect alpha (flutter/engine#39377)

    * 684cfe292 Add helpers for updating arm tools in CIPD (flutter/engine#39458)

    * e6cf1c532 Roll Skia from 87dbc81b421f to bd48f82dcabb (8 revisions) (flutter/engine#39459)

    * bf8547dd9 Override _accessibilityHitTest to fix IOS 16 semantics issues  (flutter/engine#38794)

    * 2e225eb6b Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (flutter/engine#39462)

    * ca05af79e [Windows] Remove accessibility root assumptions (flutter/engine#39441)

    * 3e9eb95ea Roll Skia from bd48f82dcabb to f30529658275 (7 revisions) (flutter/engine#39463)

    * 85958c2ea Update malioc analysis golden file (flutter/engine#39461)

    * 7098858dc Roll Fuchsia Mac SDK from zYEsaCaA1cokDUU43... to uYw6cCpJIpQa42G4O... (flutter/engine#39466)

commit cd125e1f
Author: Greg Price <gnprice@gmail.com>
Date:   Tue Feb 7 17:17:23 2023 -0800

    Add test for RenderProxyBoxMixin; clarify doc, resolve TODO (#117664)

    * Add test for RenderProxyBoxMixin; clarify doc, resolve TODO

    The TODO comment suggested this mixin would no longer be needed once
    a Dart issue on inherited constructors was fixed:
      https://github.com/dart-lang/sdk/issues/31543
    That issue is now long since fixed, so I went to go carry out the TODO.

    But in doing so, I realized that the mixin's documentation was more
    right than the TODO comment: even with that issue fixed, there is a
    legitimate use case for this mixin, namely to reuse the implementation
    of RenderProxyBox in a class that also inherits from some other base
    class.  Moreover, searching GitHub I found an example of a library
    that makes real use of that capability.

    So I think the right resolution is to accept that this separation
    is useful and delete the TODO.

    Then, add a test with an extremely simplified sketch of that
    real-world example.  In case someone in the future attempts to
    simplify this mixin away, the test will point us at the use case
    that would be broken by such a change.

    Also remove the only in-tree use of the mixin, which was redundant;
    and expand the mixin's documentation to advise about that case.

    * Tweak formatting
Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>

    * Cut comments

    ---------
Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>

commit 98b3e48e
Author: Greg Price <gnprice@gmail.com>
Date:   Tue Feb 7 16:04:23 2023 -0800

    Fix hang on successful dev/bots/analyze.dart (#117660)

    Fixes #117659

    It turns out this was due to the output-suppression timer introduced
    recently as part of cleaning up the output (#109206); on success, the
    script would wait 10 minutes for the timeout to expire.  This didn't
    affect CI because this feature doesn't apply in CI (as detected by
    lack of color on stdout.)

    Fix the issue by cleaning up the timer on success in the same way
    as on failure.

    While here, clean up the final summary messages slightly,
    and also cut the trailing space that printProgress was leaving
    on each line.

commit aed9b4ad
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Tue Feb 7 13:42:20 2023 -0800

    Revert "Revert "Fix unable to find bundled Java version (#119244)" (#119981)" (#120107)

    This reverts commit f7c2bd05.

commit 5be7f663
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Feb 7 15:28:28 2023 -0500

    f310ffd14 Roll Skia from 3b1401c4870d to 87dbc81b421f (4 revisions) (flutter/engine#39457) (#120214)

commit 10895888
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Tue Feb 7 12:10:18 2023 -0800

    un-pin package:intl (#119900)

commit 0b0450fb
Author: Justin McCandless <jmccandless@google.com>
Date:   Tue Feb 7 11:52:51 2023 -0800

    Web tab selection (#119583)

    Correct selection behavior when tabbing into a field on the web.

commit 1c225675
Author: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
Date:   Tue Feb 7 11:16:24 2023 -0800

    Update to v0.158 of the token database. (#120149)

    * Update to v0.158 of the token database.

    * Update checkbox template

    * Fix DatePickerTheme test

    ---------
Co-authored-by: 's avatarQun Cheng <quncheng@google.com>

commit e8eac0d0
Author: Taha Tesser <tessertaha@gmail.com>
Date:   Tue Feb 7 18:21:18 2023 +0200

    Update `ExpansionTile` to support Material 3 & add an example (#119712)

commit da36bd6f
Author: Andrew Kolos <andrewrkolos@gmail.com>
Date:   Tue Feb 7 11:20:23 2023 -0500

    Stop recursively including assets from asset folders (#120167)

    * add test

    * fix

    * use preexisting testFileSystem

    * fix variant tests

    * Revert "use preexisting testFileSystem"

    This reverts commit b6df288ef4a6ff007ecd984e98a1a3f2001ad242.

    * nit: grammar

commit f2e89755
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Feb 7 11:10:08 2023 -0500

    b67690f69 Roll Skia from 6babb6a1afe6 to 3b1401c4870d (1 revision) (flutter/engine#39455) (#120198)

commit e03029ef
Author: Mouad Debbar <mdebbar@google.com>
Date:   Tue Feb 7 10:51:52 2023 -0500

    [web] Move JS content to its own `.js` files (#117691)

commit 3f5b105f
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Feb 7 10:51:26 2023 -0500

    Roll Plugins from d065e4e0a82a to 6f985d57b04b (10 revisions) (#120193)

    * 883864599 [image_picker] GIF files will animate without permissions. PNG and GIF files will retain their image type if missing permissions. (flutter/plugins#7084)

    * 7a63dbc8f [camera] flip/change camera while recording - platform interface (flutter/plugins#7011)

    * c6be93605 Roll Flutter from b8f5394a to 3c3c9a1b (3 revisions) (flutter/plugins#7107)

    * eb0a6b562 [gh_actions]: Bump github/codeql-action from 2.1.37 to 2.2.1 (flutter/plugins#7059)

    * dc0d3a02b [camerax] Wrap methods necessary for preview implementation (flutter/plugins#7046)

    * c9f6bee71 [local_auth]: Bump core from 1.8.0 to 1.9.0 in /packages/local_auth/local_auth_android/android (flutter/plugins#6393)

    * f5957bde8 [webview_flutter_web] Avoids XHR when possible. (flutter/plugins#7090)

    * 55f257382 [Espresso] Update expressio dependencies  (flutter/plugins#7108)

    * 76ea8c8ce [url_launcher_ios] Update minimum Flutter version to 3.3 and iOS 11 (flutter/plugins#7110)

    * 6f985d57b Redistribute ownership of cross-platform plugin components (flutter/plugins#7093)

commit d7f742e9
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Feb 7 10:22:29 2023 -0500

    Roll Flutter Engine from 5aadda2f40b1 to e432b82f49f3 (3 revisions) (#120191)

    * ca47bbc7e Roll Skia from 83da27e4cd3a to 6babb6a1afe6 (1 revision) (flutter/engine#39451)

    * cabdc9e23 Roll Fuchsia Mac SDK from jD_N9MDLvRtOuBMgY... to zYEsaCaA1cokDUU43... (flutter/engine#39453)

    * e432b82f4 Roll Fuchsia Linux SDK from wlbzrDXNCXQZV0QdG... to aRqjqB76Z2gNQsrTA... (flutter/engine#39454)

commit a6ea6445
Author: Konstantin Sokolovskyi <sokolovskyi.konstantin@gmail.com>
Date:   Tue Feb 7 14:45:50 2023 +0100

    Fix cut button creation in 'buttonItemsForToolbarOptions' (#119822)

    * Fix cut button creation in buttonItemsForToolbarOptions

    * Remove extra spaces in tests

    * Replace fails with expects, Add periods in the comments

commit 16441f4b
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Feb 7 06:00:32 2023 -0500

    5aadda2f4 Roll Skia from 419bb63e733d to 83da27e4cd3a (1 revision) (flutter/engine#39448) (#120172)

commit 7a6f1d81
Author: Eilidh Southren <esouthren@google.com>
Date:   Tue Feb 7 10:53:36 2023 +0000

    M3 segmented buttons token fixes (#120095)

    * add icon button property override

    * Revert "add icon button property override"

    This reverts commit 6c7f4d30671f417d0f4a311bdb186bd4ebc456c8.

    * segmented button updates

    * button changes

    * fix

    * put that thing back where it came from

    * template updates

    * analyzer fixes

    * rename parameter

    * analyzer fixes

    * string interpolation fix

    * template updates

    * test updates

commit a808ba05
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Feb 7 02:22:27 2023 -0500

    39f5e4cba Roll Skia from 7e2c9f54c0fd to 419bb63e733d (1 revision) (flutter/engine#39447) (#120159)

commit 1d0cbbb2
Author: xubaolin <xubaolin@oppo.com>
Date:   Tue Feb 7 14:10:06 2023 +0800

    fix a [SelectableRegion] crash bug (#120076)

    * fix a crash bug

    * review feedback

commit cf3fc017
Author: Renzo Olivares <rmolivares@renzo-olivares.dev>
Date:   Mon Feb 6 21:40:18 2023 -0800

    remove deprecated accentTextTheme and accentIconTheme from ThemeData (#119360)
Co-authored-by: 's avatarRenzo Olivares <roliv@google.com>

commit 845f7bb4
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Feb 6 22:10:30 2023 -0500

    Roll Flutter Engine from 2a104cdfcdf8 to 165126e7034c (13 revisions) (#120150)

    * ec45e72a2 Roll Dart SDK from a507a9057730 to f18aa4402c1a (3 revisions) (flutter/engine#39395)

    * 1f0cb90da Roll Skia from 45a4fdcc0cb0 to 1bc762cbb8ce (1 revision) (flutter/engine#39397)

    * b19b263de Roll Fuchsia Mac SDK from j6dhXDhI_KUUyqTSF... to f7zsdfKoUWP6RD8S_... (flutter/engine#39398)

    * a6cc2517b Roll Fuchsia Linux SDK from Z6Bdg2fbH4n5ptsKZ... to V9ahWWCSVIMrpc9LX... (flutter/engine#39399)

    * af02efb3f Revert "Roll Dart SDK from a507a9057730 to f18aa4402c1a (3 revisions) (#39395)" (flutter/engine#39422)

    * aa0ff2173 Migrate engine_v2_builds to python3. (flutter/engine#39404)

    * a87b7455a Use jdk 11 in the engine. (flutter/engine#39375)

    * 75722215e Fix cpp-wrappers archive. (flutter/engine#39400)

    * 696049ef1 Roll Fuchsia Mac SDK from f7zsdfKoUWP6RD8S_... to jD_N9MDLvRtOuBMgY... (flutter/engine#39439)

    * 0c61605a7 Roll Fuchsia Linux SDK from V9ahWWCSVIMrpc9LX... to wlbzrDXNCXQZV0QdG... (flutter/engine#39435)

    * 6024bef6b Roll Skia from 1bc762cbb8ce to 7e2c9f54c0fd (23 revisions) (flutter/engine#39440)

    * 0315d0601 [Windows] Fix the 'engine restart resets keyboard' test (flutter/engine#39380)

    * 165126e70 iOS keyboard animation synchronization (flutter/engine#37604)

commit 71971f22
Author: Jenn Magder <magder@google.com>
Date:   Mon Feb 6 18:56:38 2023 -0800

    Run `verify_binaries_codesigned` task on release branches (#120141)

    * Run verify_binaries_codesigned on release branches

    * Revert branches

commit e62abfae
Author: Sam Rawlins <srawlins@google.com>
Date:   Mon Feb 6 17:52:30 2023 -0800

    Remove unreachable_from_main linter rule (#120110)

    * Remove unreachable_from_main linter rule

    * Comment out

    * Update analysis_options.yaml

    ---------
Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>

commit e627e8d8
Author: Jenn Magder <magder@google.com>
Date:   Mon Feb 6 15:52:52 2023 -0800

    Force web_tool_tests to run on x64 builders (#120128)

commit 575ced6c
Author: Justin McCandless <jmccandless@google.com>
Date:   Mon Feb 6 15:51:11 2023 -0800

    Fix context menu web examples (#120104)

    The context menu examples on the docs site now work on the web.

commit ec524ed0
Author: 林洵锋 <linxunfeng@yeah.net>
Date:   Tue Feb 7 06:50:07 2023 +0800

    Fix flutter_tools stuck when using custom LLDB prompt (#119443)

    * Fix flutter_tools stuck when using custom LLDB prompt

    * Remove trailing space character

    * Fix local variable name

    * Add comment

    * Remove trailing space character

    * Update packages/flutter_tools/lib/src/ios/ios_deploy.dart
Co-authored-by: 's avatarJenn Magder <magder@google.com>

    * Update packages/flutter_tools/lib/src/ios/ios_deploy.dart
Co-authored-by: 's avatarJenn Magder <magder@google.com>

    * Remove trailing space character

    ---------
Co-authored-by: 's avatarJenn Magder <magder@google.com>

commit 40b5e4cb
Author: Haroon Awan <43820531+HaroonAwan@users.noreply.github.com>
Date:   Mon Feb 6 21:45:39 2023 +0500

    Added "insertAll" and "removeAll" methods to AnimatedList (#115545)

    * Added "insertAll" and "removeAll" method to AnimatedList

    * Fixed doc

    * Changes in documentation asked by reviewwer

    * Removed unnecessary asserts.

    * Doc changes asked by reviewer.

    * Doc changes.

    ---------
Co-authored-by: 's avatarRashid Khabeer <rkhabeer84@gmail.com>

commit 7bf1e99e
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Feb 6 10:51:51 2023 -0500

    Roll Plugins from 9302d87ee545 to d065e4e0a82a (6 revisions) (#120084)

    * 97a05241e [camera_android] Default to legacy recording profile when EncoderProfiles unavailable (flutter/plugins#7073)

    * a59517a03 Roll Flutter from d2788080 to c5e8757f (54 revisions) (flutter/plugins#7092)

    * bde2ff0d7 Roll Flutter (stable) from b06b8b271095 to 7048ed95a5ad (5 revisions) (flutter/plugins#7091)

    * 1e58ab0f0 [in_app_pur]: Bump billing from 5.0.0 to 5.1.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6701)

    * a5f40d751 Roll Flutter from c5e8757f to b8f5394a (22 revisions) (flutter/plugins#7105)

    * d065e4e0a [gh_actions]: Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter/plugins#6936)

commit 1bec87b4
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Mon Feb 6 07:51:47 2023 -0800

    Update Android TESTOWNERS (#119960)

    Updates the tests that were passed temporarily to me in #109717 to
    @reidbaker

commit 3c3c9a1b
Author: Eilidh Southren <esouthren@google.com>
Date:   Mon Feb 6 14:39:14 2023 +0000

    [M3] Add ListTile's iconColor property support for icon buttons (#120075)

    * add icon button property override

    * list tile changes

    * add imports

    * add newlines

    * whitespace

commit 47a06746
Author: Ben Konyi <bkonyi@google.com>
Date:   Mon Feb 6 09:23:35 2023 -0500

    Reland "Add --serve-observatory flag to run, attach, and test (#118402)"  (#119737)

    This reverts commit 254a796b.

commit bbca7ff6
Author: Taha Tesser <tessertaha@gmail.com>
Date:   Mon Feb 6 11:02:37 2023 +0200

    Add Material 3 `SwitchListTile` example and update existing examples (#119714)

    * Add Material 3 `SwitchListTile` example and update existing examples

    * Update examples with `useMaterial3: true` and update example descriptions.

    * add a `ColorScheme` colour

commit b8f5394a
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Sat Feb 4 23:06:19 2023 -0800

    [flutter_tools] Fix Future error handling ArgumentError in doctor --android-licenses (#119977)

    * wip

    * write test

    * make error handling printError

    * remove diff

commit 2e39badf
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sun Feb 5 02:04:10 2023 -0500

    Roll Flutter Engine from 6bd500c38ea8 to 2a104cdfcdf8 (2 revisions) (#120022)

    * 65678e026 Roll Fuchsia Linux SDK from D0jJKibnSzSOs68QJ... to Z6Bdg2fbH4n5ptsKZ... (flutter/engine#39393)

    * 2a104cdfc Roll Skia from 8de8c6287254 to 45a4fdcc0cb0 (1 revision) (flutter/engine#39394)

commit 5187b45e
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Feb 4 19:24:12 2023 -0500

    Roll Flutter Engine from c7a4bbab0e75 to 6bd500c38ea8 (2 revisions) (#120018)

    * f2d3dbda0 Roll Fuchsia Linux SDK from y0pMcSL4ejAh7JYTq... to D0jJKibnSzSOs68QJ... (flutter/engine#39386)

    * 6bd500c38 Roll Fuchsia Mac SDK from hcZFTTKMN0k4lXjfs... to j6dhXDhI_KUUyqTSF... (flutter/engine#39390)

commit f10e625e
Author: Brandon DeRosier <bdero@google.com>
Date:   Sat Feb 4 15:29:59 2023 -0800

    De-flake adapter integration test (#120016)

commit 61f6a0bc
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Feb 4 03:08:35 2023 -0500

    Roll Flutter Engine from 1b132e44194d to c7a4bbab0e75 (6 revisions) (#119990)

    * 49f2d98d2 Roll Skia from f083b79aa388 to 5d8a7ed8acfe (3 revisions) (flutter/engine#39381)

    * 88fda68f4 Roll Skia from 5d8a7ed8acfe to 8de8c6287254 (1 revision) (flutter/engine#39382)

    * 23f53e5ef [fuchsia] Add output_path property to customize output path of .so files (flutter/engine#39007)

    * 87ed27470 Roll Fuchsia Mac SDK from _6bmpi47oMZC-msOI... to hcZFTTKMN0k4lXjfs... (flutter/engine#39384)

    * d3edcc985 Roll Dart SDK from de912d108ebb to a507a9057730 (2 revisions) (flutter/engine#39385)

    * c7a4bbab0 [Impeller] Make text appear less emboldened (flutter/engine#39383)

commit 5241d38f
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 22:32:28 2023 -0500

    Roll Flutter Engine from e1b265bb52aa to 1b132e44194d (8 revisions) (#119980)

    * 2ddbff9b6 [Impeller] Append to existing atlas if room exists, reuse texture (flutter/engine#38253)

    * 9dd2e9c98 [fuchsia] fdio_service_connect no longer provides rights which we need (flutter/engine#39374)

    * 9dde1563c [impeller] drawVertices blend mode (flutter/engine#38985)

    * 18750d245 [ios] Lock refresh rate to 80fps when threads are merged (flutter/engine#39172)

    * fe259c2ba Roll Skia from 83a3d8b16c94 to f083b79aa388 (5 revisions) (flutter/engine#39376)

    * 4fdbb0a36 [Impeller] Retain embolden/skew font properties when rendering text glyphs (flutter/engine#39378)

    * 868234df1 Roll Dart SDK from b7a0c75d4470 to de912d108ebb (1 revision) (flutter/engine#39379)

    * 1b132e441 [iOS] Ensure FlutterView's background color is not nil to avoid CAMetalLayer nextDrawable being time-consuming (flutter/engine#39359)

commit c8e75a8d
Author: godofredoc <godofredoc@google.com>
Date:   Fri Feb 3 19:32:26 2023 -0800

    Do not run customer testing on release candidate branches. (#119979)

    These tests try to use a commit contemporary to the framework commit in
    customer repositories. This won't work because a CP to the framework
    release candidate branch may be recent even though the release candidate
    branch can be months old.

commit f7c2bd05
Author: godofredoc <godofredoc@google.com>
Date:   Fri Feb 3 18:57:53 2023 -0800

    Revert "Fix unable to find bundled Java version (#119244)" (#119981)

    This reverts commit 57fd50f8.

commit 57fd50f8
Author: crasowas <110958409+crasowas@users.noreply.github.com>
Date:   Sat Feb 4 10:04:04 2023 +0800

    Fix unable to find bundled Java version (#119244)

commit 909dc300
Author: Jenn Magder <magder@google.com>
Date:   Fri Feb 3 17:52:05 2023 -0800

    Verify Mac artifact codesigning on x64 and arm64 (#119971)

    * Verify Mac artifact codesigning on x64 and arm64

    * mac_arm64

commit 0fbef469
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 18:31:03 2023 -0500

    e1b265bb5 Roll Skia from 07a95bb37760 to 83a3d8b16c94 (5 revisions) (flutter/engine#39373) (#119967)

commit c24904dd
Author: Jenn Magder <magder@google.com>
Date:   Fri Feb 3 14:38:53 2023 -0800

    Run macOS benchmarks in prod pool to upload metrics (#119963)

commit c52215e9
Author: Jenn Magder <magder@google.com>
Date:   Fri Feb 3 14:37:48 2023 -0800

    Run Mac hostonly tests on any available arch (#119884)

    * Run Mac hostonly tests on any available arch

    * Exception for framework tests

commit 3f02d4b4
Author: Callum Moffat <smartercallum@gmail.com>
Date:   Fri Feb 3 17:29:00 2023 -0500

    Tweak to floating-cursor-end behaviour (#119893)

    * Tweak to floating-cursor-end behaviour

    * Simplify

commit 51b05ac7
Author: Jenn Magder <magder@google.com>
Date:   Fri Feb 3 13:36:48 2023 -0800

    Add mac_benchmark ci.yaml property (#119871)

    * Add mac_benchmark ci.yaml property

    * Remove presubmit

    * Bringup

    * Comma

    * gems

    * Test animated_complex_opacity_perf_macos__e2e_summary in presubmit

    * Try top-level mac_model

    * Move dependencies back into tasks

    * Add signing dependency

    * Revert animated_complex_opacity_perf_macos__e2e_summary test

commit 16f81e65
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 16:27:10 2023 -0500

    Roll Flutter Engine from 33d932efc68e to 110c643d6ac2 (3 revisions) (#119957)

    * 7e7a8a8b0 [impellerc] sort uniforms on metal backend  (flutter/engine#39366)

    * 16617b0a9 Roll Fuchsia Linux SDK from CAyoT0SrHHyXCMF31... to y0pMcSL4ejAh7JYTq... (flutter/engine#39371)

    * 110c643d6 Roll Skia from 62dcca5b175a to 07a95bb37760 (10 revisions) (flutter/engine#39369)

commit 9a7e1870
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Fri Feb 3 11:24:41 2023 -0800

    [flutter_tools] fix Cannot delete file ENOENT from fuchsia_asset_builder (#119867)

    * fix

    * add test

commit be4c8c0e
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 14:12:54 2023 -0500

    33d932efc Add gen_snapshot to windows flutter artifact. (flutter/engine#39353) (#119951)

commit b65ae62c
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 13:26:08 2023 -0500

    Roll Flutter Engine from c39047ffb2a6 to 745d7efb5736 (3 revisions) (#119943)

    * 90427769f Fire UIA event on Checkbox state change (flutter/engine#39346)

    * dae0ebd00 Roll Dart SDK from be795cc64bd7 to b7a0c75d4470 (1 revision) (flutter/engine#39363)

    * 745d7efb5 Roll Fuchsia Mac SDK from 2xyEsodtHgcamPwX4... to _6bmpi47oMZC-msOI... (flutter/engine#39364)

commit 00b0d550
Author: Justin McCandless <jmccandless@google.com>
Date:   Fri Feb 3 10:14:59 2023 -0800

    Fix iOS context menu position when flipped below (#119565)

    * Fix anchorBelow calculation, and share toolbar padding constant

    * Fix constant references in test

    * Test below position when padding is not offset by content distance

commit 96c8c697
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 12:37:02 2023 -0500

    Roll Flutter Engine from 0fb48ce5b118 to c39047ffb2a6 (2 revisions) (#119939)

    * 2e1c10382 Roll Skia from ee68f3edfa96 to 62dcca5b175a (1 revision) (flutter/engine#39362)

    * c39047ffb Roll buildroot to 39b486f7 (flutter/engine#39361)

commit 7177c413
Author: Taha Tesser <tessertaha@gmail.com>
Date:   Fri Feb 3 18:27:43 2023 +0200

    Add Material 3 `RadioListTile` example and update existing examples (#119716)

    * Add Material 3 `RadioListTile` example and update existing examples

    * Update examples with `useMaterial3: true` and update example descriptions.

    * add a `ColorScheme` colour

commit c5e8757f
Author: Eilidh Southren <esouthren@google.com>
Date:   Fri Feb 3 14:35:12 2023 +0000

    Add M3 support for iconbuttons in error state in TextFields (#119925)

    * add m3 iconbutton override

    * changes

    * spring cleaning

    * whitespace fix

    * sneaky whitespaces

commit e0b2138b
Author: Polina Cherkasova <polinach@google.com>
Date:   Fri Feb 3 06:31:47 2023 -0800

    Dispose OverlayEntry in TooltipState. (#117291)

commit fc8ea562
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 08:54:27 2023 -0500

    0fb48ce5b Roll Dart SDK from 69452c5012d9 to be795cc64bd7 (1 revision) (flutter/engine#39360) (#119926)

commit a5d8a4a7
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 05:07:21 2023 -0500

    67d35267c [Impeller] Use minimal coverage for stencil restores after overdraw prevention (flutter/engine#39358) (#119910)

commit 6b83eff5
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 03:15:16 2023 -0500

    Roll Flutter Engine from e3fe6dade964 to 655530e3fd15 (5 revisions) (#119905)

    * 7422df491 [impellerc] sort uniforms on metal backend (flutter/engine#39345)

    * d94924742 Roll Fuchsia Linux SDK from pWloCaRzjLEAUvQEz... to CAyoT0SrHHyXCMF31... (flutter/engine#39354)

    * f4fbbe38c Roll Skia from a4079ec4c399 to ee68f3edfa96 (1 revision) (flutter/engine#39355)

    * 6425ae2b5 Revert "[impellerc] sort uniforms on metal backend (#39345)" (flutter/engine#39356)

    * 655530e3f Roll Dart SDK from 283b05994d68 to 69452c5012d9 (1 revision) (flutter/engine#39357)

commit 69421c16
Author: Jonah Williams <jonahwilliams@google.com>
Date:   Thu Feb 2 23:28:57 2023 -0800

    [framework] use shader tiling instead of repeated calls to drawImage (#119495)

    * [framework] use shader tiling instead of repeated calls to drawImage

    * ++

    * ++

    * review and test updates

    * ++

    * Update decoration_image.dart

    * Update decoration_image.dart

    * ++

    * ++

    * ++

    * ++

    * ++

    * Update painting.dart

    * Update decoration_test.dart

commit f3effce6
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Feb 3 00:07:10 2023 -0500

    Roll Flutter Engine from 2696fff8716d to e3fe6dade964 (3 revisions) (#119892)

    * a2f53699c Roll Dart SDK from 73b03bb636d3 to 283b05994d68 (2 revisions) (flutter/engine#39349)

    * 0e38e5304 Roll Skia from 4f0166baf5a4 to a4079ec4c399 (1 revision) (flutter/engine#39351)

    * e3fe6dade Roll Fuchsia Mac SDK from rqjJA8z_K0gdGcsvA... to 2xyEsodtHgcamPwX4... (flutter/engine#39352)

commit bc45b185
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 2 21:37:03 2023 -0500

    2696fff87 Roll Skia from c2d81db3ef41 to 4f0166baf5a4 (13 revisions) (flutter/engine#39348) (#119879)

commit 3570cce5
Author: Kate Lovett <katelovett@google.com>
Date:   Fri Feb 3 04:34:17 2023 +0300

    Remove deprecated kind in GestureRecognizer et al (#119572)

    * Remove deprecated kind in GestureRecognizer et al

    * Fix null case

commit a27802e2
Author: Kevin Moore <kevmoo@users.noreply.github.com>
Date:   Thu Feb 2 17:27:23 2023 -0800

    flutter_tool: remove explicit length header in HTTP response (#119869)

    This is already handled by pkg:shelf
    There is some subtlety with String here, since String.length might not
    align with the size in bytes over the wire, depending on the contents
    and the encoding

    Best to just let pkg:shelf handle it

commit c6264605
Author: Greg Spencer <gspencergoog@users.noreply.github.com>
Date:   Thu Feb 2 17:27:20 2023 -0800

    Make `_focusDebug` not interpolate in debug mode (#119680)

    * Make _focusDebug not interpolate in debug mode

    * Add test

    * Revert undesired change

    * Fix test to fail before too

    * Remove accidental skips

    * Switch to using a generating closure for arguments.

    * Remove a word

commit 66b2ca63
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 2 19:55:07 2023 -0500

    Roll Flutter Engine from 616ecd8be3de to 2871970337df (3 revisions) (#119870)

    * a77e7bcb9 [web] Update the within() matcher to be more useful (flutter/engine#39288)

    * dbf401f97 [Impeller] Don't ceil subpass texture sizes (flutter/engine#39336)

    * 287197033 Bump ninja version to 1.11.1 (flutter/engine#39347)

commit 9b86a485
Author: Jessica Pereira <je.mary0804@gmail.com>
Date:   Thu Feb 2 21:15:58 2023 -0300

    Fix gets removedItem instead of its index (#119638)

    * fix: gets removedItem instead of its index
    add: sliver_animated_list.0_test.dart

    * fix: sliver_animated_list.0_test.dart

    * fix: pr comments

    * fix test import
Co-authored-by: 's avatarTaha Tesser <tessertaha@gmail.com>

    ---------
Co-authored-by: 's avatarTaha Tesser <tessertaha@gmail.com>

commit d875899a
Author: Jenn Magder <magder@google.com>
Date:   Thu Feb 2 16:14:42 2023 -0800

    Bump test Chrome version for Mac arm support (#119773)

commit cfdc3585
Author: Flutter GitHub Bot <fluttergithubbot@gmail.com>
Date:   Thu Feb 2 18:59:49 2023 -0500

    roll packages (#119865)

commit 72f9cf54
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Feb 2 18:08:27 2023 -0500

    Roll Flutter Engine from ae38c9585a61 to 616ecd8be3de (3 revisions) (#119859)

    * 510ecfa93 Don't rely on timings for dimension_provider unit test. (flutter/engine#39343)

    * b1ccae745 Roll Skia from 60242c4ea6a7 to c2d81db3ef41 (5 revisions) (flutter/engine#39344)

    * 616ecd8be [Web][HTML] Add mirrored characters support for RTL languages (flutter/engine#39162)

commit d820aec7
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Thu Feb 2 13:38:08 2023 -0800

    Manual pub roll with dwds fix (#119575)

    * roll packages

    * fix dwds

    * empty

    ---------
Co-authored-by: 's avatarfluttergithubbot <fluttergithubbot@gmail.com>

commit 8387c238
Author: Danny Tuppeny <danny@tuppeny.com>
Date:   Thu Feb 2 21:28:12 2023 +0000

    [flutter_tools] Use base DAP detach and ensure correct output (#119076)

commit 22bbdf03
Author: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com>
Date:   Thu Feb 2 12:56:05 2023 -0800

    Android defines target update (#119766)

    * Round 2 with dimensions

    * Try with stringified keys

    * Forgot a comma

    * trying a list of maps.

    * Try key value pairs

    * Try with kvm only

    * try with swarming_dimensions

    * Updated with fix in swarming.star

    * Attempting to remove the bring up property to verify test is running.

    * Remove android from target tags to avoid adb command automatically running in test_utils call.

    * Remove the duplicated dependencies in the defines target that exist in the platform

commit d63987f7
Author: Jesús S Guerrero <jesus_sguerrero@hotmail.com>
Date:   Thu Feb 2 14:04:06 2023 -0600

    Parser machine logs (#118707)

    * remove file reporter optional

    * decouple stack trace from metric collections

    * update tests; add collect metrics option

    * add failed tests property

    * add test for multiple stack failed

    * change path on result

    * create factory method

    * throw exception when test file failed to generate

    * remove catch of file exception

    * handle when no stacktrace on file reporter

commit d4b68984
Author: Mouad Debbar <mdebbar@google.com>
Date:   Thu Feb 2 14:49:18 2023 -0500

    [web] Put all index.html operations in one place (#118188)

    * [web] Put all index.html operations i…

* Change the width of the spacer

* Remove whitespaces

* Change the future to a listener

* Extract the callback to have the functionality to remove and add it dynamically to the controller. Fix not having to meet the value 0.500 exactly, only the first above 0.5.

* Change wording
Co-authored-by: 's avatarChris Bracken <chris@bracken.jp>

---------
Co-authored-by: 's avatarChris Bracken <chris@bracken.jp>
parent ef49f566
...@@ -8,6 +8,7 @@ import 'dart:ui' as ui; ...@@ -8,6 +8,7 @@ import 'dart:ui' as ui;
import 'package:flutter/foundation.dart'; import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart' show kMinFlingVelocity; import 'package:flutter/gestures.dart' show kMinFlingVelocity;
import 'package:flutter/scheduler.dart'; import 'package:flutter/scheduler.dart';
import 'package:flutter/services.dart' show HapticFeedback;
import 'package:flutter/widgets.dart'; import 'package:flutter/widgets.dart';
import 'colors.dart'; import 'colors.dart';
...@@ -137,6 +138,7 @@ class CupertinoContextMenu extends StatefulWidget { ...@@ -137,6 +138,7 @@ class CupertinoContextMenu extends StatefulWidget {
super.key, super.key,
required this.actions, required this.actions,
required Widget this.child, required Widget this.child,
this.enableHapticFeedback = false,
@Deprecated( @Deprecated(
'Use CupertinoContextMenu.builder instead. ' 'Use CupertinoContextMenu.builder instead. '
'This feature was deprecated after v3.4.0-34.1.pre.', 'This feature was deprecated after v3.4.0-34.1.pre.',
...@@ -157,6 +159,7 @@ class CupertinoContextMenu extends StatefulWidget { ...@@ -157,6 +159,7 @@ class CupertinoContextMenu extends StatefulWidget {
super.key, super.key,
required this.actions, required this.actions,
required this.builder, required this.builder,
this.enableHapticFeedback = false,
}) : assert(actions.isNotEmpty), }) : assert(actions.isNotEmpty),
child = null, child = null,
previewBuilder = null; previewBuilder = null;
...@@ -388,6 +391,13 @@ class CupertinoContextMenu extends StatefulWidget { ...@@ -388,6 +391,13 @@ class CupertinoContextMenu extends StatefulWidget {
/// This parameter cannot be null or empty. /// This parameter cannot be null or empty.
final List<Widget> actions; final List<Widget> actions;
/// If true, clicking on the [CupertinoContextMenuAction]s will
/// produce haptic feedback.
///
/// Uses [HapticFeedback.heavyImpact] when activated.
/// Defaults to false.
final bool enableHapticFeedback;
/// A function that returns an alternative widget to show when the /// A function that returns an alternative widget to show when the
/// [CupertinoContextMenu] is open. /// [CupertinoContextMenu] is open.
/// ///
...@@ -481,6 +491,15 @@ class _CupertinoContextMenuState extends State<CupertinoContextMenu> with Ticker ...@@ -481,6 +491,15 @@ class _CupertinoContextMenuState extends State<CupertinoContextMenu> with Ticker
_openController.addStatusListener(_onDecoyAnimationStatusChange); _openController.addStatusListener(_onDecoyAnimationStatusChange);
} }
void _listenerCallback() {
if (_openController.status != AnimationStatus.reverse &&
_openController.value >= _midpoint &&
widget.enableHapticFeedback) {
HapticFeedback.heavyImpact();
_openController.removeListener(_listenerCallback);
}
}
// Determine the _ContextMenuLocation based on the location of the original // Determine the _ContextMenuLocation based on the location of the original
// child in the screen. // child in the screen.
// //
...@@ -583,24 +602,28 @@ class _CupertinoContextMenuState extends State<CupertinoContextMenu> with Ticker ...@@ -583,24 +602,28 @@ class _CupertinoContextMenuState extends State<CupertinoContextMenu> with Ticker
} }
void _onTap() { void _onTap() {
_openController.removeListener(_listenerCallback);
if (_openController.isAnimating && _openController.value < _midpoint) { if (_openController.isAnimating && _openController.value < _midpoint) {
_openController.reverse(); _openController.reverse();
} }
} }
void _onTapCancel() { void _onTapCancel() {
_openController.removeListener(_listenerCallback);
if (_openController.isAnimating && _openController.value < _midpoint) { if (_openController.isAnimating && _openController.value < _midpoint) {
_openController.reverse(); _openController.reverse();
} }
} }
void _onTapUp(TapUpDetails details) { void _onTapUp(TapUpDetails details) {
_openController.removeListener(_listenerCallback);
if (_openController.isAnimating && _openController.value < _midpoint) { if (_openController.isAnimating && _openController.value < _midpoint) {
_openController.reverse(); _openController.reverse();
} }
} }
void _onTapDown(TapDownDetails details) { void _onTapDown(TapDownDetails details) {
_openController.addListener(_listenerCallback);
setState(() { setState(() {
_childHidden = true; _childHidden = true;
}); });
...@@ -1370,8 +1393,6 @@ class _ContextMenuRouteStaticState extends State<_ContextMenuRouteStatic> with T ...@@ -1370,8 +1393,6 @@ class _ContextMenuRouteStaticState extends State<_ContextMenuRouteStatic> with T
); );
return SafeArea( return SafeArea(
child: Padding(
padding: const EdgeInsets.all(_kPadding),
child: Align( child: Align(
alignment: Alignment.topLeft, alignment: Alignment.topLeft,
child: GestureDetector( child: GestureDetector(
...@@ -1393,7 +1414,6 @@ class _ContextMenuRouteStaticState extends State<_ContextMenuRouteStatic> with T ...@@ -1393,7 +1414,6 @@ class _ContextMenuRouteStaticState extends State<_ContextMenuRouteStatic> with T
), ),
), ),
), ),
),
); );
} }
} }
...@@ -1414,12 +1434,13 @@ class _ContextMenuSheet extends StatelessWidget { ...@@ -1414,12 +1434,13 @@ class _ContextMenuSheet extends StatelessWidget {
final _ContextMenuLocation _contextMenuLocation; final _ContextMenuLocation _contextMenuLocation;
final Orientation _orientation; final Orientation _orientation;
static const double _kMenuWidth = 250.0;
// Get the children, whose order depends on orientation and // Get the children, whose order depends on orientation and
// contextMenuLocation. // contextMenuLocation.
List<Widget> getChildren(BuildContext context) { List<Widget> getChildren(BuildContext context) {
final Widget menu = Flexible( final Widget menu = SizedBox(
fit: FlexFit.tight, width: _kMenuWidth,
flex: 2,
child: IntrinsicHeight( child: IntrinsicHeight(
child: ClipRRect( child: ClipRRect(
borderRadius: const BorderRadius.all(Radius.circular(13.0)), borderRadius: const BorderRadius.all(Radius.circular(13.0)),
...@@ -1432,9 +1453,12 @@ class _ContextMenuSheet extends StatelessWidget { ...@@ -1432,9 +1453,12 @@ class _ContextMenuSheet extends StatelessWidget {
decoration: BoxDecoration( decoration: BoxDecoration(
border: Border( border: Border(
top: BorderSide( top: BorderSide(
color: CupertinoDynamicColor.resolve(_borderColor, context), color: CupertinoDynamicColor.resolve(
width: 0.5, _borderColor,
) context,
),
width: 0.4,
),
), ),
), ),
position: DecorationPosition.foreground, position: DecorationPosition.foreground,
......
...@@ -48,18 +48,18 @@ class CupertinoContextMenuAction extends StatefulWidget { ...@@ -48,18 +48,18 @@ class CupertinoContextMenuAction extends StatefulWidget {
class _CupertinoContextMenuActionState extends State<CupertinoContextMenuAction> { class _CupertinoContextMenuActionState extends State<CupertinoContextMenuAction> {
static const Color _kBackgroundColor = CupertinoDynamicColor.withBrightness( static const Color _kBackgroundColor = CupertinoDynamicColor.withBrightness(
color: Color(0xFFEEEEEE), color: Color(0xFFF1F1F1),
darkColor: Color(0xFF212122), darkColor: Color(0xFF212122),
); );
static const Color _kBackgroundColorPressed = CupertinoDynamicColor.withBrightness( static const Color _kBackgroundColorPressed = CupertinoDynamicColor.withBrightness(
color: Color(0xFFDDDDDD), color: Color(0xFFDDDDDD),
darkColor: Color(0xFF3F3F40), darkColor: Color(0xFF3F3F40),
); );
static const double _kButtonHeight = 56.0; static const double _kButtonHeight = 43;
static const TextStyle _kActionSheetActionStyle = TextStyle( static const TextStyle _kActionSheetActionStyle = TextStyle(
fontFamily: '.SF UI Text', fontFamily: '.SF UI Text',
inherit: false, inherit: false,
fontSize: 20.0, fontSize: 16.0,
fontWeight: FontWeight.w400, fontWeight: FontWeight.w400,
color: CupertinoColors.black, color: CupertinoColors.black,
textBaseline: TextBaseline.alphabetic, textBaseline: TextBaseline.alphabetic,
...@@ -125,9 +125,11 @@ class _CupertinoContextMenuActionState extends State<CupertinoContextMenuAction> ...@@ -125,9 +125,11 @@ class _CupertinoContextMenuActionState extends State<CupertinoContextMenuAction>
? CupertinoDynamicColor.resolve(_kBackgroundColorPressed, context) ? CupertinoDynamicColor.resolve(_kBackgroundColorPressed, context)
: CupertinoDynamicColor.resolve(_kBackgroundColor, context), : CupertinoDynamicColor.resolve(_kBackgroundColor, context),
), ),
padding: const EdgeInsets.symmetric( padding: const EdgeInsets.only(
vertical: 16.0, top: 8,
horizontal: 10.0, bottom: 8,
left: 15.5,
right: 17.5,
), ),
child: DefaultTextStyle( child: DefaultTextStyle(
style: _textStyle, style: _textStyle,
...@@ -141,6 +143,7 @@ class _CupertinoContextMenuActionState extends State<CupertinoContextMenuAction> ...@@ -141,6 +143,7 @@ class _CupertinoContextMenuActionState extends State<CupertinoContextMenuAction>
Icon( Icon(
widget.trailingIcon, widget.trailingIcon,
color: _textStyle.color, color: _textStyle.color,
size: 21.0,
), ),
], ],
), ),
......
...@@ -12,11 +12,13 @@ import '../rendering/mock_canvas.dart'; ...@@ -12,11 +12,13 @@ import '../rendering/mock_canvas.dart';
void main() { void main() {
// Constants taken from _ContextMenuActionState. // Constants taken from _ContextMenuActionState.
const CupertinoDynamicColor kBackgroundColor = CupertinoDynamicColor.withBrightness( const CupertinoDynamicColor kBackgroundColor =
color: Color(0xFFEEEEEE), CupertinoDynamicColor.withBrightness(
color: Color(0xFFF1F1F1),
darkColor: Color(0xFF212122), darkColor: Color(0xFF212122),
); );
const CupertinoDynamicColor kBackgroundColorPressed = CupertinoDynamicColor.withBrightness( const CupertinoDynamicColor kBackgroundColorPressed =
CupertinoDynamicColor.withBrightness(
color: Color(0xFFDDDDDD), color: Color(0xFFDDDDDD),
darkColor: Color(0xFF3F3F40), darkColor: Color(0xFF3F3F40),
); );
...@@ -84,43 +86,55 @@ void main() { ...@@ -84,43 +86,55 @@ void main() {
testWidgets('turns grey when pressed and held', (WidgetTester tester) async { testWidgets('turns grey when pressed and held', (WidgetTester tester) async {
await tester.pumpWidget(getApp()); await tester.pumpWidget(getApp());
expect(find.byType(CupertinoContextMenuAction), paints..rect(color: kBackgroundColor.color)); expect(find.byType(CupertinoContextMenuAction),
paints..rect(color: kBackgroundColor.color));
final Offset actionCenterLight = tester.getCenter(find.byType(CupertinoContextMenuAction)); final Offset actionCenterLight =
final TestGesture gestureLight = await tester.startGesture(actionCenterLight); tester.getCenter(find.byType(CupertinoContextMenuAction));
final TestGesture gestureLight =
await tester.startGesture(actionCenterLight);
await tester.pump(); await tester.pump();
expect(find.byType(CupertinoContextMenuAction), paints..rect(color: kBackgroundColorPressed.color)); expect(find.byType(CupertinoContextMenuAction),
paints..rect(color: kBackgroundColorPressed.color));
await gestureLight.up(); await gestureLight.up();
await tester.pump(); await tester.pump();
expect(find.byType(CupertinoContextMenuAction), paints..rect(color: kBackgroundColor.color)); expect(find.byType(CupertinoContextMenuAction),
paints..rect(color: kBackgroundColor.color));
await tester.pumpWidget(getApp(brightness: Brightness.dark)); await tester.pumpWidget(getApp(brightness: Brightness.dark));
expect(find.byType(CupertinoContextMenuAction), paints..rect(color: kBackgroundColor.darkColor)); expect(find.byType(CupertinoContextMenuAction),
paints..rect(color: kBackgroundColor.darkColor));
final Offset actionCenterDark = tester.getCenter(find.byType(CupertinoContextMenuAction)); final Offset actionCenterDark =
tester.getCenter(find.byType(CupertinoContextMenuAction));
final TestGesture gestureDark = await tester.startGesture(actionCenterDark); final TestGesture gestureDark = await tester.startGesture(actionCenterDark);
await tester.pump(); await tester.pump();
expect(find.byType(CupertinoContextMenuAction), paints..rect(color: kBackgroundColorPressed.darkColor)); expect(find.byType(CupertinoContextMenuAction),
paints..rect(color: kBackgroundColorPressed.darkColor));
await gestureDark.up(); await gestureDark.up();
await tester.pump(); await tester.pump();
expect(find.byType(CupertinoContextMenuAction), paints..rect(color: kBackgroundColor.darkColor)); expect(find.byType(CupertinoContextMenuAction),
paints..rect(color: kBackgroundColor.darkColor));
}); });
testWidgets('icon and textStyle colors are correct out of the box', (WidgetTester tester) async { testWidgets('icon and textStyle colors are correct out of the box',
(WidgetTester tester) async {
await tester.pumpWidget(getApp()); await tester.pumpWidget(getApp());
expect(getTextStyle(tester).color, CupertinoColors.label); expect(getTextStyle(tester).color, CupertinoColors.label);
expect(getIcon(tester).color, CupertinoColors.label); expect(getIcon(tester).color, CupertinoColors.label);
}); });
testWidgets('icon and textStyle colors are correct for destructive actions', (WidgetTester tester) async { testWidgets('icon and textStyle colors are correct for destructive actions',
(WidgetTester tester) async {
await tester.pumpWidget(getApp(isDestructiveAction: true)); await tester.pumpWidget(getApp(isDestructiveAction: true));
expect(getTextStyle(tester).color, kDestructiveActionColor); expect(getTextStyle(tester).color, kDestructiveActionColor);
expect(getIcon(tester).color, kDestructiveActionColor); expect(getIcon(tester).color, kDestructiveActionColor);
}); });
testWidgets('textStyle is correct for defaultAction', (WidgetTester tester) async { testWidgets('textStyle is correct for defaultAction',
(WidgetTester tester) async {
await tester.pumpWidget(getApp(isDefaultAction: true)); await tester.pumpWidget(getApp(isDefaultAction: true));
expect(getTextStyle(tester).fontWeight, kDefaultActionWeight); expect(getTextStyle(tester).fontWeight, kDefaultActionWeight);
}); });
...@@ -130,17 +144,21 @@ void main() { ...@@ -130,17 +144,21 @@ void main() {
(WidgetTester tester) async { (WidgetTester tester) async {
/// Cupertino context menu action without "onPressed" callback. /// Cupertino context menu action without "onPressed" callback.
await tester.pumpWidget(getApp()); await tester.pumpWidget(getApp());
final Offset contextMenuAction = tester.getCenter(find.text('I am a CupertinoContextMenuAction')); final Offset contextMenuAction =
final TestGesture gesture = await tester.createGesture(kind: PointerDeviceKind.mouse, pointer: 1); tester.getCenter(find.text('I am a CupertinoContextMenuAction'));
final TestGesture gesture =
await tester.createGesture(kind: PointerDeviceKind.mouse, pointer: 1);
await gesture.addPointer(location: contextMenuAction); await gesture.addPointer(location: contextMenuAction);
await tester.pumpAndSettle(); await tester.pumpAndSettle();
expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1), SystemMouseCursors.basic); expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1),
SystemMouseCursors.basic);
// / Cupertino context menu action with "onPressed" callback. // / Cupertino context menu action with "onPressed" callback.
await tester.pumpWidget(getApp(onPressed: (){})); await tester.pumpWidget(getApp(onPressed: () {}));
await gesture.moveTo(const Offset(10, 10)); await gesture.moveTo(const Offset(10, 10));
await tester.pumpAndSettle(); await tester.pumpAndSettle();
expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1), SystemMouseCursors.basic); expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1),
SystemMouseCursors.basic);
await gesture.moveTo(contextMenuAction); await gesture.moveTo(contextMenuAction);
await tester.pumpAndSettle(); await tester.pumpAndSettle();
......
...@@ -583,6 +583,49 @@ void main() { ...@@ -583,6 +583,49 @@ void main() {
final ClipRRect previewWidget = tester.firstWidget(findStaticDefaultPreview()) as ClipRRect; final ClipRRect previewWidget = tester.firstWidget(findStaticDefaultPreview()) as ClipRRect;
expect(previewWidget.borderRadius, equals(BorderRadius.circular(12.0))); expect(previewWidget.borderRadius, equals(BorderRadius.circular(12.0)));
}); });
testWidgets('CupertinoContextMenu width is correct', (WidgetTester tester) async {
final Widget child = getChild();
await tester.pumpWidget(getContextMenu(child: child));
expect(find.byWidget(child), findsOneWidget);
final Rect childRect = tester.getRect(find.byWidget(child));
expect(find.byWidgetPredicate((Widget w) => '${w.runtimeType}' == '_DecoyChild'), findsNothing);
// Start a press on the child.
final TestGesture gesture = await tester.startGesture(childRect.center);
await tester.pump();
// The _DecoyChild is showing directly on top of the child.
expect(findDecoyChild(child), findsOneWidget);
Rect decoyChildRect = tester.getRect(findDecoyChild(child));
expect(childRect, equals(decoyChildRect));
expect(find.byWidgetPredicate((Widget w) => '${w.runtimeType}' == '_DecoyChild'), findsOneWidget);
// After a small delay, the _DecoyChild has begun to animate.
await tester.pump(const Duration(milliseconds: 400));
decoyChildRect = tester.getRect(findDecoyChild(child));
expect(childRect, isNot(equals(decoyChildRect)));
// Eventually the decoy fully scales by _kOpenSize.
await tester.pump(const Duration(milliseconds: 800));
decoyChildRect = tester.getRect(findDecoyChild(child));
expect(childRect, isNot(equals(decoyChildRect)));
expect(decoyChildRect.width, childRect.width * kOpenScale);
// Then the CupertinoContextMenu opens.
await tester.pumpAndSettle();
await gesture.up();
await tester.pumpAndSettle();
expect(findStatic(), findsOneWidget);
// The CupertinoContextMenu has the correct width and height.
final CupertinoContextMenu widget = tester.widget(find.byType(CupertinoContextMenu));
for (final Widget action in widget.actions) {
// The value of the height is 80 because of the font and icon size.
expect(tester.getSize(find.byWidget(action)).width, 250);
}
});
}); });
group("Open layout differs depending on child's position on screen", () { group("Open layout differs depending on child's position on screen", () {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment