Commit a0666f33 authored by Todd Volkert's avatar Todd Volkert Committed by GitHub

Update Process.exitCode setter to not use @override (#7434)

As of Dart SDK 1.22.0-dev.5.0, `Process.exitCode` is no longer
mutable (that SDK version picks up https://github.com/dart-lang/sdk/commit/e5a16b1ca56414af3008afb8833660f95a9d06da).
This change allows the tools code to pass analysis in sdk versions both
before and after that change, to allow for analysis against both the host and
target sdks.
parent 2ee04c92
......@@ -491,8 +491,10 @@ class _RecordingProcess implements Process {
@override
Future<int> get exitCode => delegate.exitCode;
@override
set exitCode(Future<int> exitCode) => delegate.exitCode = exitCode;
// TODO(tvolkert): Remove this once the dart sdk in both the target and
// the host have picked up dart-lang/sdk@e5a16b1
@override // ignore: OVERRIDE_ON_NON_OVERRIDING_SETTER
set exitCode(Future<int> exitCode) => throw new UnsupportedError('set exitCode');
@override
Stream<List<int>> get stdout {
......@@ -827,7 +829,9 @@ class _ReplayProcess implements Process {
@override
Future<int> get exitCode => _exitCodeCompleter.future;
@override
// TODO(tvolkert): Remove this once the dart sdk in both the target and
// the host have picked up dart-lang/sdk@e5a16b1
@override // ignore: OVERRIDE_ON_NON_OVERRIDING_SETTER
set exitCode(Future<int> exitCode) => throw new UnsupportedError('set exitCode');
@override
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment