Cache caret parameters (#38821)

9da68fcd · Gary Qian · GitHub · b7abf56a · 9da68fcd
Unverified Commit 9da68fcd authored Aug 20, 2019 by Gary Qian Committed by GitHub Aug 20, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

text_painter.dart packages/flutter/lib/src/painting/text_painter.dart +4 -0

No files found.
--- a/packages/flutter/lib/src/painting/text_painter.dart
+++ b/packages/flutter/lib/src/painting/text_painter.dart
@@ -782,6 +782,10 @@ class TextPainter {
      offset: rect != null ? Offset(rect.left, rect.top) : _emptyOffset,
      fullHeight: rect != null ? rect.bottom - rect.top : null,
    );
+
+    // Cache the input parameters to prevent repeat work later.
+    _previousCaretPosition = position;
+    _previousCaretPrototype = caretPrototype;
  }

  /// Returns a list of rects that bound the given selection.