Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
9d70d9d5
Unverified
Commit
9d70d9d5
authored
Jul 09, 2021
by
Jonah Williams
Committed by
GitHub
Jul 09, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] fix -n workaround (#86142)
parent
75f6d03b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
19 additions
and
2 deletions
+19
-2
format.dart
packages/flutter_tools/lib/src/commands/format.dart
+2
-2
format_test.dart
...tter_tools/test/commands.shard/permeable/format_test.dart
+17
-0
No files found.
packages/flutter_tools/lib/src/commands/format.dart
View file @
9d70d9d5
...
...
@@ -47,8 +47,8 @@ class FormatCommand extends FlutterCommand {
}
else
{
command
.
addAll
(<
String
>[
for
(
String
arg
in
argResults
.
rest
)
if
(
arg
==
'--dry-run'
)
'--output=
show
'
if
(
arg
==
'--dry-run'
||
arg
==
'-n'
)
'--output=
none
'
else
arg
]);
...
...
packages/flutter_tools/test/commands.shard/permeable/format_test.dart
View file @
9d70d9d5
...
...
@@ -59,6 +59,23 @@ void main() {
expect
(
shouldNotFormatted
,
nonFormatted
);
});
testUsingContext
(
'dry-run with -n'
,
()
async
{
final
String
projectPath
=
await
createProject
(
tempDir
);
final
File
srcFile
=
globals
.
fs
.
file
(
globals
.
fs
.
path
.
join
(
projectPath
,
'lib'
,
'main.dart'
));
final
String
nonFormatted
=
srcFile
.
readAsStringSync
().
replaceFirst
(
'main()'
,
'main( )'
);
srcFile
.
writeAsStringSync
(
nonFormatted
);
final
FormatCommand
command
=
FormatCommand
(
verboseHelp:
false
);
final
CommandRunner
<
void
>
runner
=
createTestCommandRunner
(
command
);
await
runner
.
run
(<
String
>[
'format'
,
'-n'
,
srcFile
.
path
]);
final
String
shouldNotFormatted
=
srcFile
.
readAsStringSync
();
expect
(
shouldNotFormatted
,
nonFormatted
);
});
testUsingContext
(
'dry-run with set-exit-if-changed'
,
()
async
{
final
String
projectPath
=
await
createProject
(
tempDir
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment