Unverified Commit 99023f06 authored by Michael Goderbauer's avatar Michael Goderbauer Committed by GitHub

Fix missed ignores (#79071)

parent c1e1343d
...@@ -151,10 +151,10 @@ class AutomaticNotchedShape extends NotchedShape { ...@@ -151,10 +151,10 @@ class AutomaticNotchedShape extends NotchedShape {
final ShapeBorder? guest; final ShapeBorder? guest;
@override @override
Path getOuterPath(Rect hostRect, Rect? guestRect) { // ignore: avoid_renaming_method_parameters, the Path getOuterPath(Rect hostRect, Rect? guestRect) { // ignore: avoid_renaming_method_parameters
// parameters are renamed over the baseclass because they would clash // The parameters of this method are renamed over the baseclass because they
// with properties of this object, and the use of all four of them in // would clash with properties of this object, and the use of all four of
// the code below is really confusing if they have the same names. // them in the code below is really confusing if they have the same names.
final Path hostPath = host.getOuterPath(hostRect); final Path hostPath = host.getOuterPath(hostRect);
if (guest != null && guestRect != null) { if (guest != null && guestRect != null) {
final Path guestPath = guest!.getOuterPath(guestRect); final Path guestPath = guest!.getOuterPath(guestRect);
......
...@@ -68,7 +68,6 @@ void main() { ...@@ -68,7 +68,6 @@ void main() {
LogicalKeyboardKey.keyC, LogicalKeyboardKey.keyC,
LogicalKeyboardKey.keyD, LogicalKeyboardKey.keyD,
); );
// ignore: prefer_const_literals_to_create_immutables, https://github.com/dart-lang/linter/issues/2026
final LogicalKeySet setFromSet = LogicalKeySet.fromSet(<LogicalKeyboardKey>{ final LogicalKeySet setFromSet = LogicalKeySet.fromSet(<LogicalKeyboardKey>{
LogicalKeyboardKey.keyA, LogicalKeyboardKey.keyA,
LogicalKeyboardKey.keyB, LogicalKeyboardKey.keyB,
...@@ -124,7 +123,6 @@ void main() { ...@@ -124,7 +123,6 @@ void main() {
LogicalKeyboardKey.keyB, LogicalKeyboardKey.keyB,
LogicalKeyboardKey.keyA, LogicalKeyboardKey.keyA,
); );
// ignore: prefer_const_literals_to_create_immutables, https://github.com/dart-lang/linter/issues/2026
final LogicalKeySet set4 = LogicalKeySet.fromSet(<LogicalKeyboardKey>{ final LogicalKeySet set4 = LogicalKeySet.fromSet(<LogicalKeyboardKey>{
LogicalKeyboardKey.keyD, LogicalKeyboardKey.keyD,
LogicalKeyboardKey.keyC, LogicalKeyboardKey.keyC,
...@@ -140,7 +138,6 @@ void main() { ...@@ -140,7 +138,6 @@ void main() {
expect(map.containsKey(LogicalKeySet(LogicalKeyboardKey.keyA)), isTrue); expect(map.containsKey(LogicalKeySet(LogicalKeyboardKey.keyA)), isTrue);
expect( expect(
set2, set2,
// ignore: prefer_const_literals_to_create_immutables, https://github.com/dart-lang/linter/issues/2026
equals(LogicalKeySet.fromSet(<LogicalKeyboardKey>{ equals(LogicalKeySet.fromSet(<LogicalKeyboardKey>{
LogicalKeyboardKey.keyA, LogicalKeyboardKey.keyA,
LogicalKeyboardKey.keyB, LogicalKeyboardKey.keyB,
......
...@@ -8,8 +8,6 @@ import 'logger.dart'; ...@@ -8,8 +8,6 @@ import 'logger.dart';
import 'platform.dart'; import 'platform.dart';
import 'terminal.dart'; import 'terminal.dart';
// ignore_for_file: non_constant_identifier_names
const String fire = '🔥'; const String fire = '🔥';
const String image = '🖼️'; const String image = '🖼️';
const int maxLineWidth = 84; const int maxLineWidth = 84;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment