Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
99023f06
Unverified
Commit
99023f06
authored
Mar 25, 2021
by
Michael Goderbauer
Committed by
GitHub
Mar 25, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix missed ignores (#79071)
parent
c1e1343d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
4 additions
and
9 deletions
+4
-9
notched_shapes.dart
packages/flutter/lib/src/painting/notched_shapes.dart
+4
-4
shortcuts_test.dart
packages/flutter/test/widgets/shortcuts_test.dart
+0
-3
command_help.dart
packages/flutter_tools/lib/src/base/command_help.dart
+0
-2
No files found.
packages/flutter/lib/src/painting/notched_shapes.dart
View file @
99023f06
...
...
@@ -151,10 +151,10 @@ class AutomaticNotchedShape extends NotchedShape {
final
ShapeBorder
?
guest
;
@override
Path
getOuterPath
(
Rect
hostRect
,
Rect
?
guestRect
)
{
// ignore: avoid_renaming_method_parameters
, the
//
parameters are renamed over the baseclass because they would clash
// w
ith properties of this object, and the use of all four of them in
// the code below is really confusing if they have the same names.
Path
getOuterPath
(
Rect
hostRect
,
Rect
?
guestRect
)
{
// ignore: avoid_renaming_method_parameters
//
The parameters of this method are renamed over the baseclass because they
// w
ould clash with properties of this object, and the use of all four of
// the
m in the
code below is really confusing if they have the same names.
final
Path
hostPath
=
host
.
getOuterPath
(
hostRect
);
if
(
guest
!=
null
&&
guestRect
!=
null
)
{
final
Path
guestPath
=
guest
!.
getOuterPath
(
guestRect
);
...
...
packages/flutter/test/widgets/shortcuts_test.dart
View file @
99023f06
...
...
@@ -68,7 +68,6 @@ void main() {
LogicalKeyboardKey
.
keyC
,
LogicalKeyboardKey
.
keyD
,
);
// ignore: prefer_const_literals_to_create_immutables, https://github.com/dart-lang/linter/issues/2026
final
LogicalKeySet
setFromSet
=
LogicalKeySet
.
fromSet
(<
LogicalKeyboardKey
>{
LogicalKeyboardKey
.
keyA
,
LogicalKeyboardKey
.
keyB
,
...
...
@@ -124,7 +123,6 @@ void main() {
LogicalKeyboardKey
.
keyB
,
LogicalKeyboardKey
.
keyA
,
);
// ignore: prefer_const_literals_to_create_immutables, https://github.com/dart-lang/linter/issues/2026
final
LogicalKeySet
set4
=
LogicalKeySet
.
fromSet
(<
LogicalKeyboardKey
>{
LogicalKeyboardKey
.
keyD
,
LogicalKeyboardKey
.
keyC
,
...
...
@@ -140,7 +138,6 @@ void main() {
expect
(
map
.
containsKey
(
LogicalKeySet
(
LogicalKeyboardKey
.
keyA
)),
isTrue
);
expect
(
set2
,
// ignore: prefer_const_literals_to_create_immutables, https://github.com/dart-lang/linter/issues/2026
equals
(
LogicalKeySet
.
fromSet
(<
LogicalKeyboardKey
>{
LogicalKeyboardKey
.
keyA
,
LogicalKeyboardKey
.
keyB
,
...
...
packages/flutter_tools/lib/src/base/command_help.dart
View file @
99023f06
...
...
@@ -8,8 +8,6 @@ import 'logger.dart';
import
'platform.dart'
;
import
'terminal.dart'
;
// ignore_for_file: non_constant_identifier_names
const
String
fire
=
'🔥'
;
const
String
image
=
'🖼️'
;
const
int
maxLineWidth
=
84
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment