Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
98a15d03
Unverified
Commit
98a15d03
authored
Jun 28, 2021
by
Hans Muller
Committed by
GitHub
Jun 28, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remved ButtonBar references from material tests (#85472)
parent
d63cb833
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
12 deletions
+6
-12
dialog_test.dart
packages/flutter/test/material/dialog_test.dart
+2
-2
scaffold_test.dart
packages/flutter/test/material/scaffold_test.dart
+4
-9
snack_bar_test.dart
packages/flutter/test/material/snack_bar_test.dart
+0
-1
No files found.
packages/flutter/test/material/dialog_test.dart
View file @
98a15d03
...
...
@@ -47,8 +47,8 @@ RenderParagraph _getTextRenderObjectFromDialog(WidgetTester tester, String text)
}
// What was the AlertDialog's ButtonBar when many of these tests were written,
// is now a
Container with an OverflowBar child. The Container's size and location
// match the original ButtonBar's size and location.
// is now a
Padding widget with an OverflowBar child. The Padding widget's size
//
and location
match the original ButtonBar's size and location.
Finder
_findButtonBar
(
)
{
return
find
.
ancestor
(
of:
find
.
byType
(
OverflowBar
),
matching:
find
.
byType
(
Padding
)).
first
;
}
...
...
packages/flutter/test/material/scaffold_test.dart
View file @
98a15d03
...
...
@@ -493,8 +493,10 @@ void main() {
),
),
);
expect
(
tester
.
getBottomLeft
(
_findButtonBar
()),
const
Offset
(
10.0
,
560.0
));
expect
(
tester
.
getBottomRight
(
_findButtonBar
()),
const
Offset
(
770.0
,
560.0
));
final
Finder
buttonsBar
=
find
.
ancestor
(
of:
find
.
byType
(
OverflowBar
),
matching:
find
.
byType
(
Padding
)).
first
;
expect
(
tester
.
getBottomLeft
(
buttonsBar
),
const
Offset
(
10.0
,
560.0
));
expect
(
tester
.
getBottomRight
(
buttonsBar
),
const
Offset
(
770.0
,
560.0
));
});
testWidgets
(
'Persistent bottom buttons bottom padding is not consumed by viewInsets'
,
(
WidgetTester
tester
)
async
{
...
...
@@ -2371,10 +2373,3 @@ class _CustomPageRoute<T> extends PageRoute<T> {
return
child
;
}
}
// What was the Scaffold's ButtonBar when many of these tests were written,
// is now a Container with an OverflowBar child. The Container's size and location
// match the original ButtonBar's size and location.
Finder
_findButtonBar
(
)
{
return
find
.
ancestor
(
of:
find
.
byType
(
OverflowBar
),
matching:
find
.
byType
(
Container
)).
first
;
}
packages/flutter/test/material/snack_bar_test.dart
View file @
98a15d03
...
...
@@ -744,7 +744,6 @@ void main() {
popupMenuTheme:
const
PopupMenuThemeData
(
color:
Colors
.
black
),
bannerTheme:
const
MaterialBannerThemeData
(
backgroundColor:
Colors
.
black
),
dividerTheme:
const
DividerThemeData
(
color:
Colors
.
black
),
buttonBarTheme:
const
ButtonBarThemeData
(
alignment:
MainAxisAlignment
.
start
),
bottomNavigationBarTheme:
const
BottomNavigationBarThemeData
(
type:
BottomNavigationBarType
.
fixed
),
timePickerTheme:
const
TimePickerThemeData
(
backgroundColor:
Colors
.
black
),
textButtonTheme:
TextButtonThemeData
(
style:
TextButton
.
styleFrom
(
primary:
Colors
.
red
)),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment