Commit 973304d5 authored by Collin Jackson's avatar Collin Jackson

Fix sliver padding assertion failure that sometimes happens during startup...

Fix sliver padding assertion failure that sometimes happens during startup because the app is temporarily built with zero size
parent 00214fa7
...@@ -146,7 +146,7 @@ class RenderSliverPadding extends RenderSliver with RenderObjectWithChildMixin<R ...@@ -146,7 +146,7 @@ class RenderSliverPadding extends RenderSliver with RenderObjectWithChildMixin<R
scrollOffset: math.max(0.0, constraints.scrollOffset - beforePadding), scrollOffset: math.max(0.0, constraints.scrollOffset - beforePadding),
overlap: 0.0, overlap: 0.0,
remainingPaintExtent: constraints.remainingPaintExtent - calculatePaintOffset(constraints, from: 0.0, to: beforePadding), remainingPaintExtent: constraints.remainingPaintExtent - calculatePaintOffset(constraints, from: 0.0, to: beforePadding),
crossAxisExtent: constraints.crossAxisExtent - crossAxisPadding, crossAxisExtent: math.max(0.0, constraints.crossAxisExtent - crossAxisPadding),
), ),
parentUsesSize: true, parentUsesSize: true,
); );
......
...@@ -156,6 +156,24 @@ void main() { ...@@ -156,6 +156,24 @@ void main() {
expect(find.text('5'), findsNothing); expect(find.text('5'), findsNothing);
}); });
testWidgets('ListView can build out of overflow padding', (WidgetTester tester) async {
await tester.pumpWidget(
new Center(
child: new SizedBox(
width: 0.0,
height: 0.0,
child: new ListView(
padding: const EdgeInsets.all(8.0),
children: <Widget>[
const Text('padded'),
],
),
),
),
);
expect(find.text('padded'), findsOneWidget);
});
testWidgets('ListView with itemExtent in unbounded context', (WidgetTester tester) async { testWidgets('ListView with itemExtent in unbounded context', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
new SingleChildScrollView( new SingleChildScrollView(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment