Unverified Commit 96b72232 authored by yaakovschectman's avatar yaakovschectman Committed by GitHub

Preliminary PR for engine changes for Tristate checkboxes (#110859)

* Honor mixed state

* Prepare for change to engine

* Unused vars

* Remove comments

* Skip test for now

* Comment for skip

* Compartmentalize changes

* Justification comments
parent 632c3532
...@@ -519,7 +519,7 @@ void _defineTests() { ...@@ -519,7 +519,7 @@ void _defineTests() {
); );
expect(semantics, hasSemantics(expectedSemantics, ignoreRect: true, ignoreTransform: true)); expect(semantics, hasSemantics(expectedSemantics, ignoreRect: true, ignoreTransform: true));
semantics.dispose(); semantics.dispose();
}); }, skip: true); // [intended] https://github.com/flutter/flutter/issues/110107
group('diffing', () { group('diffing', () {
testWidgets('complains about duplicate keys', (WidgetTester tester) async { testWidgets('complains about duplicate keys', (WidgetTester tester) async {
......
...@@ -632,7 +632,7 @@ void main() { ...@@ -632,7 +632,7 @@ void main() {
expect(semantics, hasSemantics(expectedSemantics, ignoreId: true)); expect(semantics, hasSemantics(expectedSemantics, ignoreId: true));
semantics.dispose(); semantics.dispose();
}); }, skip: true); // [intended] https://github.com/flutter/flutter/issues/110107
testWidgets('Actions can be replaced without triggering semantics update', (WidgetTester tester) async { testWidgets('Actions can be replaced without triggering semantics update', (WidgetTester tester) async {
final SemanticsTester semantics = SemanticsTester(tester); final SemanticsTester semantics = SemanticsTester(tester);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment