Merge pull request #681 from eseidelGoogle/trace

Make trace --stop fail if the adb pull fails.

Merge pull request #681 from eseidelGoogle/trace
Make trace --stop fail if the adb pull fails.
95eac98f · Eric Seidel · 853c42fc · 5b2cc1ae · 95eac98f
Commit 95eac98f authored Dec 02, 2015 by Eric Seidel
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

device.dart packages/flutter_tools/lib/src/device.dart +2 -1

No files found.
--- a/packages/flutter_tools/lib/src/device.dart
+++ b/packages/flutter_tools/lib/src/device.dart
@@ -875,8 +875,9 @@ class AndroidDevice extends Device {
    }

    if (tracePath != null) {
+      runCheckedSync(adbCommandForDevice(['root']));
      runSync(adbCommandForDevice(['shell', 'run-as', apk.id, 'chmod', '777', tracePath]));
-      runSync(adbCommandForDevice(['pull', tracePath]));
+      runCheckedSync(adbCommandForDevice(['pull', tracePath]));
      runSync(adbCommandForDevice(['shell', 'rm', tracePath]));
      return path.basename(tracePath);
    }