Unverified Commit 93a74ca9 authored by Alexandre Ardhuin's avatar Alexandre Ardhuin Committed by GitHub

remove unused members in executable libs (#107464)

parent cfff88b2
...@@ -34,8 +34,6 @@ Element? findElementOfExactWidgetTypeGoingUp(Element node, Type targetType) { ...@@ -34,8 +34,6 @@ Element? findElementOfExactWidgetTypeGoingUp(Element node, Type targetType) {
return result; return result;
} }
final RegExp materialIconAssetNameColorExtractor = RegExp(r'[^/]+/ic_.+_(white|black)_[0-9]+dp\.png');
void checkIconColor(WidgetTester tester, String label, Color color) { void checkIconColor(WidgetTester tester, String label, Color color) {
final Element listTile = findElementOfExactWidgetTypeGoingUp(tester.element(find.text(label)), ListTile)!; final Element listTile = findElementOfExactWidgetTypeGoingUp(tester.element(find.text(label)), ListTile)!;
final Element asset = findElementOfExactWidgetTypeGoingDown(listTile, RichText)!; final Element asset = findElementOfExactWidgetTypeGoingDown(listTile, RichText)!;
......
...@@ -32,8 +32,6 @@ late final String dart; ...@@ -32,8 +32,6 @@ late final String dart;
/// The path to the `pub` executable; set at the top of `main` /// The path to the `pub` executable; set at the top of `main`
late final String pub; late final String pub;
final String pubCache = path.join(flutterRoot, '.pub-cache');
/// When you call this, you can pass additional arguments to pass custom /// When you call this, you can pass additional arguments to pass custom
/// arguments to flutter analyze. For example, you might want to call this /// arguments to flutter analyze. For example, you might want to call this
/// script with the parameter --dart-sdk to use custom dart sdk. /// script with the parameter --dart-sdk to use custom dart sdk.
......
...@@ -35,7 +35,6 @@ final String flutterRoot = path.dirname(path.dirname(path.dirname(path.fromUri(P ...@@ -35,7 +35,6 @@ final String flutterRoot = path.dirname(path.dirname(path.dirname(path.fromUri(P
final String flutter = path.join(flutterRoot, 'bin', 'flutter$bat'); final String flutter = path.join(flutterRoot, 'bin', 'flutter$bat');
final String dart = path.join(flutterRoot, 'bin', 'cache', 'dart-sdk', 'bin', 'dart$exe'); final String dart = path.join(flutterRoot, 'bin', 'cache', 'dart-sdk', 'bin', 'dart$exe');
final String pubCache = path.join(flutterRoot, '.pub-cache'); final String pubCache = path.join(flutterRoot, '.pub-cache');
final String toolRoot = path.join(flutterRoot, 'packages', 'flutter_tools');
final String engineVersionFile = path.join(flutterRoot, 'bin', 'internal', 'engine.version'); final String engineVersionFile = path.join(flutterRoot, 'bin', 'internal', 'engine.version');
final String flutterPluginsVersionFile = path.join(flutterRoot, 'bin', 'internal', 'flutter_plugins.version'); final String flutterPluginsVersionFile = path.join(flutterRoot, 'bin', 'internal', 'flutter_plugins.version');
...@@ -1812,31 +1811,6 @@ void adjustEnvironmentToEnableFlutterAsserts(Map<String, String> environment) { ...@@ -1812,31 +1811,6 @@ void adjustEnvironmentToEnableFlutterAsserts(Map<String, String> environment) {
environment['FLUTTER_TOOL_ARGS'] = toolsArgs.trim(); environment['FLUTTER_TOOL_ARGS'] = toolsArgs.trim();
} }
Map<String, String> _initGradleEnvironment() {
final String? androidSdkRoot = (Platform.environment['ANDROID_HOME']?.isEmpty ?? true)
? Platform.environment['ANDROID_SDK_ROOT']
: Platform.environment['ANDROID_HOME'];
if (androidSdkRoot == null || androidSdkRoot.isEmpty) {
print('${red}Could not find Android SDK; set ANDROID_SDK_ROOT.$reset');
exit(1);
}
return <String, String>{
'ANDROID_HOME': androidSdkRoot!,
'ANDROID_SDK_ROOT': androidSdkRoot,
};
}
final Map<String, String> gradleEnvironment = _initGradleEnvironment();
void deleteFile(String path) {
// This is technically a race condition but nobody else should be running
// while this script runs, so we should be ok. (Sadly recursive:true does not
// obviate the need for existsSync, at least on Windows.)
final File file = File(path);
if (file.existsSync())
file.deleteSync();
}
enum CiProviders { enum CiProviders {
cirrus, cirrus,
luci, luci,
...@@ -1865,18 +1839,6 @@ CiProviders? get ciProvider { ...@@ -1865,18 +1839,6 @@ CiProviders? get ciProvider {
return null; return null;
} }
/// Returns the name of the branch being tested.
String get branchName {
switch(ciProvider) {
case CiProviders.cirrus:
return Platform.environment['CIRRUS_BRANCH']!;
case CiProviders.luci:
return Platform.environment['LUCI_BRANCH']!;
case null:
return '';
}
}
/// Checks the given file's contents to determine if they match the allowed /// Checks the given file's contents to determine if they match the allowed
/// pattern for version strings. /// pattern for version strings.
/// ///
......
...@@ -14,7 +14,6 @@ ...@@ -14,7 +14,6 @@
import 'dart:async'; import 'dart:async';
import 'dart:convert'; import 'dart:convert';
import 'dart:io' hide Platform; import 'dart:io' hide Platform;
import 'dart:typed_data';
import 'package:args/args.dart'; import 'package:args/args.dart';
import 'package:path/path.dart' as path; import 'package:path/path.dart' as path;
...@@ -210,8 +209,6 @@ class ProcessRunner { ...@@ -210,8 +209,6 @@ class ProcessRunner {
} }
} }
typedef HttpReader = Future<Uint8List> Function(Uri url, {Map<String, String> headers});
class ArchiveUnpublisher { class ArchiveUnpublisher {
ArchiveUnpublisher( ArchiveUnpublisher(
this.tempDir, this.tempDir,
......
...@@ -12,10 +12,6 @@ import 'package:path/path.dart' as path; ...@@ -12,10 +12,6 @@ import 'package:path/path.dart' as path;
final String platformLineSep = Platform.isWindows ? '\r\n': '\n'; final String platformLineSep = Platform.isWindows ? '\r\n': '\n';
final String gradlew = Platform.isWindows ? 'gradlew.bat' : 'gradlew';
final String gradlewExecutable = Platform.isWindows ? '.\\$gradlew' : './$gradlew';
/// Tests that AARs can be built on module projects. /// Tests that AARs can be built on module projects.
Future<void> main() async { Future<void> main() async {
await task(() async { await task(() async {
......
...@@ -8,7 +8,6 @@ import 'package:flutter_devicelab/framework/utils.dart'; ...@@ -8,7 +8,6 @@ import 'package:flutter_devicelab/framework/utils.dart';
import 'package:flutter_devicelab/tasks/perf_tests.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart';
const String kPackageName = 'com.example.macrobenchmarks'; const String kPackageName = 'com.example.macrobenchmarks';
const String kActivityName = 'com.example.macrobenchmarks.MainActivity';
class FastScrollHeavyGridViewMemoryTest extends MemoryTest { class FastScrollHeavyGridViewMemoryTest extends MemoryTest {
FastScrollHeavyGridViewMemoryTest() FastScrollHeavyGridViewMemoryTest()
......
...@@ -8,7 +8,6 @@ import 'package:flutter_devicelab/framework/utils.dart'; ...@@ -8,7 +8,6 @@ import 'package:flutter_devicelab/framework/utils.dart';
import 'package:flutter_devicelab/tasks/perf_tests.dart'; import 'package:flutter_devicelab/tasks/perf_tests.dart';
const String kPackageName = 'com.example.macrobenchmarks'; const String kPackageName = 'com.example.macrobenchmarks';
const String kActivityName = 'com.example.macrobenchmarks.MainActivity';
class FastScrollLargeImagesMemoryTest extends MemoryTest { class FastScrollLargeImagesMemoryTest extends MemoryTest {
FastScrollLargeImagesMemoryTest() FastScrollLargeImagesMemoryTest()
......
...@@ -16,9 +16,6 @@ Future<void> main() async { ...@@ -16,9 +16,6 @@ Future<void> main() async {
await task(const NewGalleryChromeRunTest().run); await task(const NewGalleryChromeRunTest().run);
} }
/// URI for the New Flutter Gallery repository.
const String galleryRepo = 'https://github.com/flutter/gallery.git';
/// After the gallery loads, a duration of [durationToWaitForError] /// After the gallery loads, a duration of [durationToWaitForError]
/// is waited, allowing any possible exceptions to be thrown. /// is waited, allowing any possible exceptions to be thrown.
const Duration durationToWaitForError = Duration(seconds: 5); const Duration durationToWaitForError = Duration(seconds: 5);
......
...@@ -145,8 +145,6 @@ CommandArgs cmd({ ...@@ -145,8 +145,6 @@ CommandArgs cmd({
); );
} }
typedef ExitErrorFactory = dynamic Function();
@immutable @immutable
class CommandArgs { class CommandArgs {
const CommandArgs({ required this.command, this.arguments, this.environment }); const CommandArgs({ required this.command, this.arguments, this.environment });
......
...@@ -10,11 +10,9 @@ import 'package:file/file.dart'; ...@@ -10,11 +10,9 @@ import 'package:file/file.dart';
import 'package:file/local.dart'; import 'package:file/local.dart';
import 'package:package_config/package_config.dart'; import 'package:package_config/package_config.dart';
import 'package:path/path.dart' as path; import 'package:path/path.dart' as path;
import 'package:process/process.dart';
import 'package:vm_snapshot_analysis/program_info.dart'; import 'package:vm_snapshot_analysis/program_info.dart';
import 'package:vm_snapshot_analysis/v8_profile.dart'; import 'package:vm_snapshot_analysis/v8_profile.dart';
const ProcessManager processManager = LocalProcessManager();
const FileSystem fs = LocalFileSystem(); const FileSystem fs = LocalFileSystem();
Future<void> main(List<String> args) async { Future<void> main(List<String> args) async {
......
...@@ -11,9 +11,11 @@ final Completer<void> _assetImageCompleter = Completer<void>(); ...@@ -11,9 +11,11 @@ final Completer<void> _assetImageCompleter = Completer<void>();
final Completer<void> _networkImageCompleter = Completer<void>(); final Completer<void> _networkImageCompleter = Completer<void>();
/// Notifies that Image.asset used in the test app loaded the image. /// Notifies that Image.asset used in the test app loaded the image.
@visibleForTesting
Future<void> get whenAssetImageLoads => _assetImageCompleter.future; Future<void> get whenAssetImageLoads => _assetImageCompleter.future;
/// Notifies that Image.network used in the test app loaded the image. /// Notifies that Image.network used in the test app loaded the image.
@visibleForTesting
Future<void> get whenNetworkImageLoads => _networkImageCompleter.future; Future<void> get whenNetworkImageLoads => _networkImageCompleter.future;
Future<void> main() async { Future<void> main() async {
......
...@@ -4,15 +4,6 @@ ...@@ -4,15 +4,6 @@
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
class ColorTestingDemo extends StatelessWidget {
const ColorTestingDemo({ super.key });
static const String routeName = '/color_demo';
@override
Widget build(BuildContext context) => const ColorDemoHome();
}
class ColorDemoHome extends StatelessWidget { class ColorDemoHome extends StatelessWidget {
const ColorDemoHome({super.key}); const ColorDemoHome({super.key});
......
...@@ -11,24 +11,6 @@ void main() { ...@@ -11,24 +11,6 @@ void main() {
)); ));
} }
class DemoButton extends StatelessWidget {
const DemoButton({super.key, required this.name});
final String name;
void _handleOnPressed() {
print('Button $name pressed.');
}
@override
Widget build(BuildContext context) {
return TextButton(
onPressed: () => _handleOnPressed(),
child: Text(name),
);
}
}
class HoverDemo extends StatefulWidget { class HoverDemo extends StatefulWidget {
const HoverDemo({super.key}); const HoverDemo({super.key});
......
...@@ -16,7 +16,6 @@ import 'dartdoc_checker.dart'; ...@@ -16,7 +16,6 @@ import 'dartdoc_checker.dart';
const String kDocsRoot = 'dev/docs'; const String kDocsRoot = 'dev/docs';
const String kPublishRoot = '$kDocsRoot/doc'; const String kPublishRoot = '$kDocsRoot/doc';
const String kSnippetsRoot = 'dev/snippets';
const String kDummyPackageName = 'Flutter'; const String kDummyPackageName = 'Flutter';
const String kPlatformIntegrationPackageName = 'platform_integration'; const String kPlatformIntegrationPackageName = 'platform_integration';
......
...@@ -17,7 +17,6 @@ import 'package:path/path.dart' as path; ...@@ -17,7 +17,6 @@ import 'package:path/path.dart' as path;
import 'package:platform/platform.dart'; import 'package:platform/platform.dart';
import 'package:process/process.dart'; import 'package:process/process.dart';
const bool kIsWeb = identical(0, 0.0);
FileSystem filesystem = const LocalFileSystem(); FileSystem filesystem = const LocalFileSystem();
ProcessManager processManager = const LocalProcessManager(); ProcessManager processManager = const LocalProcessManager();
Platform platform = const LocalPlatform(); Platform platform = const LocalPlatform();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment