Unverified Commit 93a3ce7a authored by Dan Field's avatar Dan Field Committed by GitHub

Disable flaky tests on Windows (#36317)

parent aa9a1151
...@@ -16,11 +16,7 @@ import 'feedback_tester.dart'; ...@@ -16,11 +16,7 @@ import 'feedback_tester.dart';
void main() { void main() {
group('showDatePicker', () { group('showDatePicker', () {
_tests(); _tests();
}, });
// Skip on Windows because this test is quite flaky when run on Windows,
// until https://github.com/flutter/flutter/issues/19696 is fixed.
skip: isWindows || isBrowser,
);
} }
void _tests() { void _tests() {
...@@ -106,7 +102,7 @@ void _tests() { ...@@ -106,7 +102,7 @@ void _tests() {
await tester.tap(find.text('17')); await tester.tap(find.text('17'));
await tester.pumpAndSettle(); await tester.pumpAndSettle();
expect(_selectedDate, equals(DateTime(2016, DateTime.august, 17))); expect(_selectedDate, equals(DateTime(2016, DateTime.august, 17)));
}); }, skip: isWindows); // TODO(dnfield): these are flaky on Windows https://github.com/flutter/flutter#19696
testWidgets('render picker with intrinsic dimensions', (WidgetTester tester) async { testWidgets('render picker with intrinsic dimensions', (WidgetTester tester) async {
await tester.pumpWidget( await tester.pumpWidget(
...@@ -132,7 +128,7 @@ void _tests() { ...@@ -132,7 +128,7 @@ void _tests() {
), ),
); );
await tester.pump(const Duration(seconds: 5)); await tester.pump(const Duration(seconds: 5));
}); }, skip: isWindows); // TODO(dnfield): these are flaky on Windows https://github.com/flutter/flutter#19696
Future<void> preparePicker(WidgetTester tester, Future<void> callback(Future<DateTime> date)) async { Future<void> preparePicker(WidgetTester tester, Future<void> callback(Future<DateTime> date)) async {
BuildContext buttonContext; BuildContext buttonContext;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment