Commit 91dbb3c9 authored by Jason Simmons's avatar Jason Simmons Committed by GitHub

roll engine and update tools for the removal of dart:jni (#9137)

parent a54979e1
0005285781cd8eab7a43571bccdaad8354c6faa4 4c05830aafb75c2893ea98bfd932ac95e883bce2
...@@ -11,7 +11,6 @@ import 'globals.dart'; ...@@ -11,7 +11,6 @@ import 'globals.dart';
enum Artifact { enum Artifact {
dartIoEntriesTxt, dartIoEntriesTxt,
dartVmEntryPointsTxt, dartVmEntryPointsTxt,
dartVmEntryPointsAndroidTxt,
genSnapshot, genSnapshot,
flutterTester, flutterTester,
snapshotDart, snapshotDart,
...@@ -26,8 +25,6 @@ String _artifactToFileName(Artifact artifact) { ...@@ -26,8 +25,6 @@ String _artifactToFileName(Artifact artifact) {
return 'dart_io_entries.txt'; return 'dart_io_entries.txt';
case Artifact.dartVmEntryPointsTxt: case Artifact.dartVmEntryPointsTxt:
return 'dart_vm_entry_points.txt'; return 'dart_vm_entry_points.txt';
case Artifact.dartVmEntryPointsAndroidTxt:
return 'dart_vm_entry_points_android.txt';
case Artifact.genSnapshot: case Artifact.genSnapshot:
return 'gen_snapshot'; return 'gen_snapshot';
case Artifact.flutterTester: case Artifact.flutterTester:
...@@ -94,7 +91,6 @@ class CachedArtifacts extends Artifacts { ...@@ -94,7 +91,6 @@ class CachedArtifacts extends Artifacts {
switch (artifact) { switch (artifact) {
case Artifact.dartIoEntriesTxt: case Artifact.dartIoEntriesTxt:
case Artifact.dartVmEntryPointsTxt: case Artifact.dartVmEntryPointsTxt:
case Artifact.dartVmEntryPointsAndroidTxt:
assert(mode != BuildMode.debug, 'Artifact $artifact only available in non-debug mode.'); assert(mode != BuildMode.debug, 'Artifact $artifact only available in non-debug mode.');
return fs.path.join(engineDir, _artifactToFileName(artifact)); return fs.path.join(engineDir, _artifactToFileName(artifact));
case Artifact.genSnapshot: case Artifact.genSnapshot:
...@@ -192,7 +188,6 @@ class LocalEngineArtifacts extends Artifacts { ...@@ -192,7 +188,6 @@ class LocalEngineArtifacts extends Artifacts {
case Artifact.dartIoEntriesTxt: case Artifact.dartIoEntriesTxt:
return fs.path.join(_engineSrcPath, 'dart', 'runtime', 'bin', _artifactToFileName(artifact)); return fs.path.join(_engineSrcPath, 'dart', 'runtime', 'bin', _artifactToFileName(artifact));
case Artifact.dartVmEntryPointsTxt: case Artifact.dartVmEntryPointsTxt:
case Artifact.dartVmEntryPointsAndroidTxt:
return fs.path.join(_engineSrcPath, 'flutter', 'runtime', _artifactToFileName(artifact)); return fs.path.join(_engineSrcPath, 'flutter', 'runtime', _artifactToFileName(artifact));
case Artifact.snapshotDart: case Artifact.snapshotDart:
return fs.path.join(_engineSrcPath, 'flutter', 'lib', 'snapshot', _artifactToFileName(artifact)); return fs.path.join(_engineSrcPath, 'flutter', 'lib', 'snapshot', _artifactToFileName(artifact));
......
...@@ -147,20 +147,15 @@ Future<String> _buildAotSnapshot( ...@@ -147,20 +147,15 @@ Future<String> _buildAotSnapshot(
final String skyEnginePkg = _getSdkExtensionPath(packageMap, 'sky_engine'); final String skyEnginePkg = _getSdkExtensionPath(packageMap, 'sky_engine');
final String uiPath = fs.path.join(skyEnginePkg, 'dart_ui', 'ui.dart'); final String uiPath = fs.path.join(skyEnginePkg, 'dart_ui', 'ui.dart');
final String jniPath = fs.path.join(skyEnginePkg, 'dart_jni', 'jni.dart');
final String vmServicePath = fs.path.join(skyEnginePkg, 'sdk_ext', 'vmservice_io.dart'); final String vmServicePath = fs.path.join(skyEnginePkg, 'sdk_ext', 'vmservice_io.dart');
final List<String> filePaths = <String>[ final List<String> filePaths = <String>[
vmEntryPoints, vmEntryPoints,
ioEntryPoints, ioEntryPoints,
uiPath, uiPath,
jniPath,
vmServicePath, vmServicePath,
]; ];
// These paths are used only on Android.
String vmEntryPointsAndroid;
// These paths are used only on iOS. // These paths are used only on iOS.
String snapshotDartIOS; String snapshotDartIOS;
String assembly; String assembly;
...@@ -169,10 +164,6 @@ Future<String> _buildAotSnapshot( ...@@ -169,10 +164,6 @@ Future<String> _buildAotSnapshot(
case TargetPlatform.android_arm: case TargetPlatform.android_arm:
case TargetPlatform.android_x64: case TargetPlatform.android_x64:
case TargetPlatform.android_x86: case TargetPlatform.android_x86:
vmEntryPointsAndroid = artifacts.getArtifactPath(Artifact.dartVmEntryPointsAndroidTxt, platform, buildMode);
filePaths.addAll(<String>[
vmEntryPointsAndroid,
]);
break; break;
case TargetPlatform.ios: case TargetPlatform.ios:
snapshotDartIOS = artifacts.getArtifactPath(Artifact.snapshotDart, platform, buildMode); snapshotDartIOS = artifacts.getArtifactPath(Artifact.snapshotDart, platform, buildMode);
...@@ -206,7 +197,6 @@ Future<String> _buildAotSnapshot( ...@@ -206,7 +197,6 @@ Future<String> _buildAotSnapshot(
'--isolate_snapshot_data=$isolateSnapshotData', '--isolate_snapshot_data=$isolateSnapshotData',
'--packages=${packageMap.packagesPath}', '--packages=${packageMap.packagesPath}',
'--url_mapping=dart:ui,$uiPath', '--url_mapping=dart:ui,$uiPath',
'--url_mapping=dart:jni,$jniPath',
'--url_mapping=dart:vmservice_sky,$vmServicePath', '--url_mapping=dart:vmservice_sky,$vmServicePath',
'--print_snapshot_sizes', '--print_snapshot_sizes',
'--dependencies=$dependencies', '--dependencies=$dependencies',
...@@ -225,7 +215,6 @@ Future<String> _buildAotSnapshot( ...@@ -225,7 +215,6 @@ Future<String> _buildAotSnapshot(
'--snapshot_kind=app-aot-blobs', '--snapshot_kind=app-aot-blobs',
'--vm_snapshot_instructions=$vmSnapshotInstructions', '--vm_snapshot_instructions=$vmSnapshotInstructions',
'--isolate_snapshot_instructions=$isolateSnapshotInstructions', '--isolate_snapshot_instructions=$isolateSnapshotInstructions',
'--embedder_entry_points_manifest=$vmEntryPointsAndroid',
'--no-sim-use-hardfp', // Android uses the softfloat ABI. '--no-sim-use-hardfp', // Android uses the softfloat ABI.
'--no-use-integer-division', // Not supported by the Pixel in 32-bit mode. '--no-use-integer-division', // Not supported by the Pixel in 32-bit mode.
]); ]);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment